From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Hesselbarth Subject: Re: [PATCH] arm64: dts: berlin4ct: Add L2 cache topology Date: Wed, 6 Jul 2016 19:49:01 +0200 Message-ID: <577D448D.8030701@gmail.com> References: <1466066418-1141-1-git-send-email-jszhang@marvell.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1466066418-1141-1-git-send-email-jszhang-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jisheng Zhang , robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, catalin.marinas-5wv7dgnIgG8@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 16.06.2016 10:40, Jisheng Zhang wrote: > This patch adds the L2 cache topology for berlin4ct which has 1MB L2 > cache. > > Signed-off-by: Jisheng Zhang > --- > arch/arm64/boot/dts/marvell/berlin4ct.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/marvell/berlin4ct.dtsi b/arch/arm64/boot/dts/marvell/berlin4ct.dtsi > index 099ad93..c9e3a98 100644 > --- a/arch/arm64/boot/dts/marvell/berlin4ct.dtsi > +++ b/arch/arm64/boot/dts/marvell/berlin4ct.dtsi [...] > @@ -92,9 +95,14 @@ > device_type = "cpu"; > reg = <0x3>; > enable-method = "psci"; > + next-level-cache = <&L2_0>; > cpu-idle-states = <&CPU_SLEEP_0>; > }; > > + L2_0: l2-cache0 { Jisheng, The node name should just have a generic name that reflects the purpose of the unit it represents, i.e. s/l2-cache0/cache/ nits: - What is that "0" for? Please remove if there is no good reason. - Does the node label need to be upper-case? Please make it lower case. Sebastian > + compatible = "cache"; > + }; > + > idle-states { > entry-method = "psci"; > CPU_SLEEP_0: cpu-sleep-0 { > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html