From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.215.58.158 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793628145; b=I6JSNOXC1gLSBK2gm7qksF2jmxXy3qOgAo1QKZDiTAI8pkyusCpdglTl3sRPQ9hx+RiF O5VOK2MZb8CNAzVB9rDjTEEIs2P5FJEW7+OevxanLSLJ5xTD2gqMWpKtGXE2T7kM/7DCc K4VrHmO4wSkupKDYHVND0BCCfV7TLvDASzo8wxjq5e9vPAPte3apbG7zBzbxOanhGY0l3 5mDBnLyCqAV8fwwOaGlw4udYWd7jVbGQPq8anwIMkelSOq33fygV+SndxHHz2KKYng/sA G1rMqOJwVMBudk4kfP9nKOEq74Qzip5I7dDyc6qqTWRVtgfla/GZDnV/jnAih3odQ7Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793628145; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:Content-Language:From:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=rrDt8/qG+jvKZq+V2MNsQBcgRe5gnhLdJ83DrJanIU0=; b=pIFJGPrHuvJaTwrTeBbHNrq7hoLeJY+q3XYA1bBEciCovNMfZ3khF/Sn2dxlIE4DqHm9 cy8vPKfLtRMT3oCS9zlzDRbOGo0AM5d8gaXj09GpPZMT9eGcHt5y8ANyPXKC48wdcuq/J Q3BGinzAJcYMZ9VRrqQiAmRpchfnxCy1JovKSRQzWMcS7JxzNoIWvUGILzeQg0gu1iWTP XkhfpWw/4D1o9dGp+Cxnss2akZgy5UORIsK1H65DszpX6fGey2yNaWmx+IlPqG9KH/pz7 JpkbIG7wogOTFoaatBhTZZYgpDllJrehpwvkCD9nC7k9KDpQEGSroze56C3Zugck9SA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=m6qnEhOg; arc=none smtp.remote-ip=95.215.58.158 Received: from mta1.migadu.com (out-158.mta1.migadu.com [95.215.58.158]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BDE7606A327 for ; Mon, 2 Nov 2026 14:02:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 6BDE7606A327 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=m6qnEhOg X-Envelope-To: devicetree@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=+GKTSizLrrZQBsZt056y5c/KPEn+gWcclfGVamWBXAE=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1793628141; v=1; x=1794232941; b=m6qnEhOg8/7wJnc/sV3n4A+UeJe0ESULsytD7G8zc8NVwxrKzga8kFA/K/P2ON4987ImgqJG 0/gSAlRWBTPPdmFDPkKIh/Pybujg+qtO5OVUyl1/N78WwzgQ/5xVWqY/GkTfz/uvEyTib/QJrNU /Zc71WzYgOWdoPscP0eABqac= X-Envelope-To: devicetree@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 308c65e25e6731cd; Mon, 02 Nov 2026 14:02:14 +0000 X-Mizu-Trace-ID: 308c65e25e6731cd X-Migadu-Flow: FLOW_OUT Message-ID: <5782a7a2-3fb4-4d74-aae9-e1ff0d0d4393@linux.dev> Date: Mon, 2 Nov 2026 14:02:13 +0000 X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 12/14] drm/tidss: Add support for AM62P display subsystem To: Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Nishanth Menon , Vignesh Raghavendra , Swamil Jain , Devarsh Thakkar , Louis Chauvet Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20261029-beagley-ai-display-v4-0-dc7f2b532478@ideasonboard.com> <20261029-beagley-ai-display-v4-12-dc7f2b532478@ideasonboard.com> Content-Language: en-US From: Aradhya Bhatia In-Reply-To: <20261029-beagley-ai-display-v4-12-dc7f2b532478@ideasonboard.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Tomi, On 29/10/26 10:18, Tomi Valkeinen wrote: > From: Swamil Jain > > The DSS controller on TI's AM62P SoC features two instances of the TI > DSS. Each DSS instance supports two video ports, similar to the DSS > controller found on the TI AM62X SoC. This allows three independent > video streams to be supported: OLDI, DPI, and DSI. > > Since the DSS instances on AM62P are architecturally similar to those > on the AM62X DSS controller, the existing dispc_am625_feats > configuration can be reused for the AM62P DSS support. > > This commit adds the necessary device tree compatibility entry for > "ti,am62p-dss" in the tidss driver, pointing to dispc_am625_feats, > thereby enabling DSS support on AM62P devices. > > Signed-off-by: Swamil Jain > Signed-off-by: Tomi Valkeinen Reviewed-by: Aradhya Bhatia > --- > drivers/gpu/drm/tidss/tidss_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/tidss/tidss_drv.c b/drivers/gpu/drm/tidss/tidss_drv.c > index 44b0b009c29a..8e3cbfb5ef87 100644 > --- a/drivers/gpu/drm/tidss/tidss_drv.c > +++ b/drivers/gpu/drm/tidss/tidss_drv.c > @@ -240,6 +240,7 @@ static const struct of_device_id tidss_of_table[] = { > { .compatible = "ti,am625-dss", .data = &dispc_am625_feats, }, > { .compatible = "ti,am62a7-dss", .data = &dispc_am62a7_feats, }, On a separate note, Now that `vp_bus_type` support has been dropped, the only thing different `dispc_am62a7_feats` has from `dispc_am625_feats` is the subrev macro. The DSS in AM62A7 SoC is functionally same with that in AM625 SoC; the only difference being the absence of both the OLDI TXes in AM62A7. The dt-bindings enforce that rule. The only place subrev DISPC_AM625 is used, and subrev DISPC_AM62A7 is not, is for an OLDI reset done log print. if (dispc->feat->subrev == DISPC_AM625 || dispc->feat->subrev == DISPC_AM65X) dev_dbg(dispc->dev, "OLDI RESETDONE %d,%d,%d\n", REG_GET(dispc, DSS_SYSSTATUS, GENMASK(5, 5)), REG_GET(dispc, DSS_SYSSTATUS, GENMASK(6, 6)), REG_GET(dispc, DSS_SYSSTATUS, GENMASK(7, 7))); Should we consider some workaround for this print, so that we can entirely drop `dispc_am62a7_feats`? -- Regards Aradhya