From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wan Zongshun Subject: Re: [PATCH v2 02/10] irqchip: add irqchip driver for nuc900 Date: Mon, 11 Jul 2016 10:19:03 +0800 Message-ID: <57830217.3030800@iommu.org> References: <1468135649-19980-1-git-send-email-vw@iommu.org> <1468135649-19980-3-git-send-email-vw@iommu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-clk-owner@vger.kernel.org To: Paul Gortmaker Cc: devicetree@vger.kernel.org, Jason Cooper , Arnd Bergmann , Daniel Lezcano , Russell King , LKML , p.zabel@pengutronix.de, Thomas Gleixner , Wan Zongshun , linux-clk@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org On 2016=E5=B9=B407=E6=9C=8811=E6=97=A5 05:51, Paul Gortmaker wrote: > On Sun, Jul 10, 2016 at 3:27 AM, Wan Zongshun wrote: >> This patch is to add irqchip driver support for nuc900 plat, >> current this driver only supports nuc970 SoC. >> >> Signed-off-by: Wan Zongshun >> --- >> arch/arm/mach-w90x900/include/mach/irqs.h | 5 + >> drivers/irqchip/Makefile | 1 + >> drivers/irqchip/irq-nuc900.c | 150 ++++++++++++++++++= ++++++++++++ >> 3 files changed, 156 insertions(+) >> create mode 100644 drivers/irqchip/irq-nuc900.c >> >> diff --git a/arch/arm/mach-w90x900/include/mach/irqs.h b/arch/arm/ma= ch-w90x900/include/mach/irqs.h >> index 9d5cba3..3b035c6 100644 >> --- a/arch/arm/mach-w90x900/include/mach/irqs.h >> +++ b/arch/arm/mach-w90x900/include/mach/irqs.h >> @@ -59,7 +59,12 @@ >> #define IRQ_KPI W90X900_IRQ(29) >> #define IRQ_P2SGROUP W90X900_IRQ(30) >> #define IRQ_ADC W90X900_IRQ(31) >> + >> +#if !defined(CONFIG_SOC_NUC900) >> #define NR_IRQS (IRQ_ADC+1) >> +#else >> +#define NR_IRQS 62 >> +#endif >> >> /*for irq group*/ >> >> diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile >> index 38853a1..9ccd5af8a 100644 >> --- a/drivers/irqchip/Makefile >> +++ b/drivers/irqchip/Makefile >> @@ -69,3 +69,4 @@ obj-$(CONFIG_PIC32_EVIC) +=3D irq-pic= 32-evic.o >> obj-$(CONFIG_MVEBU_ODMI) +=3D irq-mvebu-odmi.o >> obj-$(CONFIG_LS_SCFG_MSI) +=3D irq-ls-scfg-msi.o >> obj-$(CONFIG_EZNPS_GIC) +=3D irq-eznps.o >> +obj-$(CONFIG_SOC_NUC970) +=3D irq-nuc900.o >> diff --git a/drivers/irqchip/irq-nuc900.c b/drivers/irqchip/irq-nuc9= 00.c >> new file mode 100644 >> index 0000000..c4b2e39 >> --- /dev/null >> +++ b/drivers/irqchip/irq-nuc900.c >> @@ -0,0 +1,150 @@ >> +/* >> + * Copyright 2016 Wan Zongshun >> + * >> + * The code contained herein is licensed under the GNU General Publ= ic >> + * License. You may obtain a copy of the GNU General Public License >> + * Version 2 or later at the following locations: >> + * >> + * http://www.opensource.org/licenses/gpl-license.html >> + * http://www.gnu.org/copyleft/gpl.html >> + */ >> + >> +#include > > Why do you include module.h when I don't see anything modular in > this driver? Okay, I can delete it. > > Paul. > -- > >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +#include >> +#include >> + > > [...] > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > >