devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jaehoon Chung <jh80.chung@samsung.com>
To: Shawn Lin <shawn.lin@rock-chips.com>, linux-mmc@vger.kernel.org
Cc: ulf.hansson@linaro.org, linux-kernel@vger.kernel.org,
	Rob Herrin <robh+dt@kernel.org>,
	mark.rutland@arm.com, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] mmc: dw_mmc: remove the deprecated "supports-highspeed" property
Date: Fri, 29 Jul 2016 12:34:44 +0900	[thread overview]
Message-ID: <579ACED4.2010900@samsung.com> (raw)
In-Reply-To: <0dc812a2-8b80-03cf-b253-58f7f45ab72b@rock-chips.com>

Hi Shawn,

On 07/29/2016 11:44 AM, Shawn Lin wrote:
> 在 2016/7/28 17:55, Jaehoon Chung 写道:
>> Remvoe the deprecated "supports-highspeed" property.
>> DWMMC controller will not use this property anymore.
>>
> 
> We had set up a flag day to remove these deprecated property
> long time agao.
> 
> It doesn't *break* old dtb which may(not ?) still boot up new
> kernel code as we just make it suffer from lower speed, then
> I think it's time for them to migrate to the new property anyway.

Thanks for reviewing!

Best Regards,
Jaehoon Chung

> 
> So,
> 
> Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>
> 
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>> ---
>>  drivers/mmc/host/dw_mmc.c | 5 -----
>>  1 file changed, 5 deletions(-)
>>
>> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
>> index 1b719a6..e9faedd 100644
>> --- a/drivers/mmc/host/dw_mmc.c
>> +++ b/drivers/mmc/host/dw_mmc.c
>> @@ -2890,11 +2890,6 @@ static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host)
>>              return ERR_PTR(ret);
>>      }
>>
>> -    if (of_find_property(np, "supports-highspeed", NULL)) {
>> -        dev_info(dev, "supports-highspeed property is deprecated.\n");
>> -        pdata->caps |= MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED;
>> -    }
>> -
>>      return pdata;
>>  }
>>
>>
> 
> 


      reply	other threads:[~2016-07-29  3:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-28  9:55 [PATCH 1/2] ARM: dts: zx: remove the slot sub-nodes relevant to dwmmc controller Jaehoon Chung
2016-07-28  9:55 ` [PATCH 2/2] mmc: dw_mmc: remove the deprecated "supports-highspeed" property Jaehoon Chung
2016-07-29  2:44   ` Shawn Lin
2016-07-29  3:34     ` Jaehoon Chung [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=579ACED4.2010900@samsung.com \
    --to=jh80.chung@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=shawn.lin@rock-chips.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).