Re: [PATCH 1/2 v2] hwmon: (ltc4151) Make shunt-resistor configurable

[Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>]

On 07/30/2016 09:11 AM, Daniel Golle wrote:
> Hi Guenter,
>
> On Sat, Jul 30, 2016 at 09:00:14AM -0700, Guenter Roeck wrote:
>> Daniel,
>>
>> On 07/25/2016 04:56 AM, Daniel Golle wrote:
>>> Allow to specify the resistance of the attached shunt via DT by
>>> adding the shunt-resistor property. Fall-back to the previous
>>> default (1 mOhm) if unset.
>>>
>>> Signed-off-by: Daniel Golle <daniel-g5gK2j5usbvCyp4qypjU+w@public.gmane.org>
>>
>> Please resend with the property name changed as asked for by Rob.
>
> Ok, will do. I originally copy-pasted the property name from ina209,
> so I reckon it's supposed to be changed there as well...?
>

One can not simply change an existing property. We would have to deprecate
the old one, define a replacement, and have the driver support both. For
ina2xx, it would have to be done in the iio driver as well.

Sure, if you feel up to it, feel free to prepare a set of patches to do that.

Note that Documentation/devicetree/bindings/property-units.txt documents
that -micro-ohms should be used.

Thanks,
Guenter

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html