From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sekhar Nori Subject: Re: [PATCH 3/4] ARM: dts: da850-lcdk: Add NAND to DT Date: Wed, 10 Aug 2016 14:01:57 +0530 Message-ID: <57AAE67D.4000404@ti.com> References: <20160809171518.22690-1-kbeldan@baylibre.com> <20160809171518.22690-4-kbeldan@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160809171518.22690-4-kbeldan@baylibre.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Karl Beldan , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Mark Rutland , Karl Beldan , Kevin Hilman , linux-kernel@vger.kernel.org, Russell King , Rob Herring , Santosh Shilimkar List-Id: devicetree@vger.kernel.org On Tuesday 09 August 2016 10:45 PM, Karl Beldan wrote: > This adds DT support for the NAND connected to the SoC AEMIF. > The parameters (timings, ecc) are the same as what the board ships with > (default AEMIF timings, 1bit ECC) and improvements will be handled in > due course. I disagree that we need to be compatible to the software that ships with the board. Thats software was last updated 3 years ago. Instead I would concern with what the hardware supports. So, if the hardware can support 4-bit ECC, I would use that. If driver is broken for 4-bit ECC, please fix that up first. > This passed elementary tests hashing a 20MB file on top of ubifs on my > LCDK. > > Signed-off-by: Karl Beldan Thanks, Sekhar