From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: Aw: [PATCH] [v8] net: emac: emac gigabit ethernet controller driver Date: Fri, 12 Aug 2016 15:39:23 -0500 Message-ID: <57AE33FB.5080905@codeaurora.org> References: <1470951245-13665-1-git-send-email-timur@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: netdev-owner@vger.kernel.org To: Lino Sanfilippo Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, sdharia@codeaurora.org, shankerd@codeaurora.org, vikrams@codeaurora.org, cov@codeaurora.org, gavidov@codeaurora.org, robh+dt@kernel.org, andrew@lunn.ch, bjorn.andersson@linaro.org, mlangsdo@redhat.com, jcm@redhat.com, agross@codeaurora.org, davem@davemloft.net, f.fainelli@gmail.com List-Id: devicetree@vger.kernel.org Lino Sanfilippo wrote: > You can either extend the refill function by one gfp_t parameter and then call it > with GFP_KERNEL for the initial rx buffer allocation when the hw is brought up and > then with GFP_ATOMIC for refilling in the NAPI handler. Or simply always use GFP_ATOMIC. > In the latter case the additional parameter is not needed of course and you can > use netdev_alloc_skb_ip_align() instead of __netdev_alloc_skb_ip_align(). I will change this to use netdev_alloc_skb_ip_align(). Thanks. -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.