From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <57C676FA.6060700@gmail.com> Date: Wed, 31 Aug 2016 14:19:38 +0800 From: Caesar Wang MIME-Version: 1.0 Subject: Re: [PATCH 3/4] arm64: dts: rockchip: support gmac for rk3399 References: <1472589008-7713-1-git-send-email-wxt@rock-chips.com> <1472589008-7713-4-git-send-email-wxt@rock-chips.com> <1912883.KWCSTxJEHB@diego> In-Reply-To: <1912883.KWCSTxJEHB@diego> Content-Type: multipart/alternative; boundary="------------090005010303030200060107" To: =?ISO-8859-1?Q?Heiko_St=FCbner?= Cc: Caesar Wang , Mark Rutland , devicetree@vger.kernel.org, Brian Norris , Xing Zheng , Masahiro Yamada , netdev@vger.kernel.org, dbasehore@chromium.org, Will Deacon , Douglas Anderson , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , Roger Chen , Catalin Marinas , Shunqian Zheng , Jianqun Xu , Elaine Zhang , linux-arm-kernel@lists.infradead.org, David Wu List-ID: This is a multi-part message in MIME format. --------------090005010303030200060107 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Hi Heiko, Thanks the response quickly. On 2016?08?31? 06:07, Heiko St�bner wrote: > Am Mittwoch, 31. August 2016, 04:30:06 schrieb Caesar Wang: >> This patch adds needed gamc information for rk3399, >> also support the gmac pd. >> >> Signed-off-by: Roger Chen >> Signed-off-by: Caesar Wang >> --- >> >> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 90 >> ++++++++++++++++++++++++++++++++ 1 file changed, 90 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index 32aebc8..53ac651 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> @@ -200,6 +200,26 @@ >> }; >> }; >> >> + gmac: eth@fe300000 { >> + compatible = "rockchip,rk3399-gmac"; >> + reg = <0x0 0xfe300000 0x0 0x10000>; >> + rockchip,grf = <&grf>; > should move below the reset-names . Done. > >> + interrupts = ; >> + interrupt-names = "macirq"; >> + clocks = <&cru SCLK_MAC>, <&cru SCLK_MAC_RX>, >> + <&cru SCLK_MAC_TX>, <&cru SCLK_MACREF>, >> + <&cru SCLK_MACREF_OUT>, <&cru ACLK_GMAC>, >> + <&cru PCLK_GMAC>; >> + clock-names = "stmmaceth", "mac_clk_rx", >> + "mac_clk_tx", "clk_mac_ref", >> + "clk_mac_refout", "aclk_mac", >> + "pclk_mac"; >> + resets = <&cru SRST_A_GMAC>; >> + reset-names = "stmmaceth"; >> + power-domains = <&power RK3399_PD_GMAC>; > The driver core should handle regular power-domain handling on device creation > already, right? So I should be able to apply patches 3 and 4 even without the > dwmac patches, right? Yup, the patches 3 and 4 needn't depand on the dwmac driver. > > Also if resending please move power-domains above resets Done. - Caesar > > > Heiko > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip --------------090005010303030200060107 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Hi Heiko,

Thanks the response quickly.

On 2016年08月31日 06:07, Heiko Stübner wrote:
Am Mittwoch, 31. August 2016, 04:30:06 schrieb Caesar Wang:

This patch adds needed gamc information for rk3399,
also support the gmac pd.

Signed-off-by: Roger Chen <roger.chen@rock-chips.com>
Signed-off-by: Caesar Wang <wxt@rock-chips.com>
---

 arch/arm64/boot/dts/rockchip/rk3399.dtsi | 90
++++++++++++++++++++++++++++++++ 1 file changed, 90 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index 32aebc8..53ac651 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
@@ -200,6 +200,26 @@
 		};
 	};

+	gmac: eth@fe300000 {
+		compatible = "rockchip,rk3399-gmac";
+		reg = <0x0 0xfe300000 0x0 0x10000>;
+		rockchip,grf = <&grf>;

should move below the reset-names .

Done.



+		interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>;
+		interrupt-names = "macirq";
+		clocks = <&cru SCLK_MAC>, <&cru SCLK_MAC_RX>,
+			 <&cru SCLK_MAC_TX>, <&cru SCLK_MACREF>,
+			 <&cru SCLK_MACREF_OUT>, <&cru ACLK_GMAC>,
+			 <&cru PCLK_GMAC>;
+		clock-names = "stmmaceth", "mac_clk_rx",
+			      "mac_clk_tx", "clk_mac_ref",
+			      "clk_mac_refout", "aclk_mac",
+			      "pclk_mac";
+		resets = <&cru SRST_A_GMAC>;
+		reset-names = "stmmaceth";
+		power-domains = <&power RK3399_PD_GMAC>;

The driver core should handle regular power-domain handling on device creation 
already, right? So I should be able to apply patches 3 and 4 even without the 
dwmac patches, right?

Yup,  the patches 3 and 4 needn't depand on the dwmac driver. 


Also if resending please move power-domains above resets

Done.

-
Caesar


Heiko

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

--------------090005010303030200060107--