Re: [PATCH v3 3/4] arm: dts: qcom: apq8064: Add display DT nodes

[Archit Taneja <architt@codeaurora.org>]

On 9/14/2016 3:14 AM, Stephen Boyd wrote:
> On 09/13/2016 08:21 AM, Archit Taneja wrote:
>> APQ8064 contains a MDP4 based display controller. It contains a HDMI, LVDS
>> and 2 DSI outputs.
>>
>> Add display DT nodes for MDP4, HDMI TX and HDMI PHY. MDP4 based display
>> blocks have a flat device hierarchy.
>>
>> Nodes for other outputs will be added later.
>>
>> Cc: Rob Herring <robh@kernel.org>
>> Cc: devicetree@vger.kernel.org
>>
>> Tested-by: John Stultz <john.stultz@linaro.org>
>> Signed-off-by: Archit Taneja <architt@codeaurora.org>
>> ---
>>   arch/arm/boot/dts/qcom-apq8064.dtsi | 91 +++++++++++++++++++++++++++++++++++++
>>   1 file changed, 91 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi
>> index 74a9b6c..b688fb6 100644
>> --- a/arch/arm/boot/dts/qcom-apq8064.dtsi
>> +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi
>> @@ -955,6 +955,97 @@
>>   			reset-names = "axi", "ahb", "por", "pci", "phy";
>>   			status = "disabled";
>>   		};
>> +
>> +		hdmi: hdmi-tx@4a00000 {
>> +			compatible = "qcom,hdmi-tx-8960";
>> +			reg = <0x04a00000 0x2f0>;
>> +			reg-names = "core_physical";
>> +			interrupts = <GIC_SPI 79 IRQ_TYPE_NONE>;
>
> Please specify the IRQ_TYPE that isn't NONE here.
>
>> +			clocks = <&mmcc HDMI_APP_CLK>,
>> +				 <&mmcc HDMI_M_AHB_CLK>,
>> +				 <&mmcc HDMI_S_AHB_CLK>;
>> +			clock-names = "core_clk",
>> +				      "master_iface_clk",
>> +				      "slave_iface_clk";
>> +
>> +			phys = <&hdmi_phy>;
>> +			phy-names = "hdmi-phy";
>> +
>> +			ports {
>> +				#address-cells = <1>;
>> +				#size-cells = <0>;
>> +
>> +				port@0 {
>> +					reg = <0>;
>> +					hdmi_in: endpoint {
>> +					};
>> +				};
>> +
>> +				port@1 {
>> +					reg = <1>;
>> +					hdmi_out: endpoint {
>> +					};
>> +				};
>> +			};
>> +		};
>> +
>> +		hdmi_phy: hdmi-phy@4a00400 {
>> +			compatible = "qcom,hdmi-phy-8960";
>> +			reg = <0x4a00400 0x60>,
>> +			      <0x4a00500 0x100>;
>> +			reg-names = "hdmi_phy",
>> +				    "hdmi_pll";
>> +
>> +			clocks = <&mmcc HDMI_S_AHB_CLK>;
>> +			clock-names = "slave_iface_clk";
>> +		};
>> +
>> +		mdp: mdp@5100000 {
>> +			compatible = "qcom,mdp4";
>> +			reg = <0x05100000 0xf0000>;
>> +			interrupts = <GIC_SPI 75 IRQ_TYPE_NONE>;
>
> Same comment here.

Will fix this.

Thanks,
Archit


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel