devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: qcom: Drop undocumented "svid" property
@ 2023-05-31  2:49 Bjorn Andersson
  2023-05-31  9:24 ` Neil Armstrong
  2023-07-10  5:07 ` Bjorn Andersson
  0 siblings, 2 replies; 3+ messages in thread
From: Bjorn Andersson @ 2023-05-31  2:49 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
	devicetree, linux-kernel

The Linux typec_mux implementation required that a property named "svid"
was present in the remote node of the of_graph for a match to be found.

With the introduction of commit '4aebc4f89f00 ("usb: typec: mux: Clean up
mux_fwnode_match()")', the implementation is aligned with the binding
and this property can be dropped - and the associated DeviceTree
validation warning resolved.

Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
---

The referred to patch is present in usb-next.

 arch/arm64/boot/dts/qcom/sc8280xp-crd.dts                  | 2 --
 arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 2 --
 arch/arm64/boot/dts/qcom/sm8350-hdk.dts                    | 1 -
 arch/arm64/boot/dts/qcom/sm8450-hdk.dts                    | 1 -
 4 files changed, 6 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
index cd7e0097d8bc..4594ef4c1f38 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
+++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
@@ -229,7 +229,6 @@ usb0-sbu-mux {
 
 		mode-switch;
 		orientation-switch;
-		svid = /bits/ 16 <0xff01>;
 
 		port {
 			usb0_sbu_mux: endpoint {
@@ -249,7 +248,6 @@ usb1-sbu-mux {
 
 		mode-switch;
 		orientation-switch;
-		svid = /bits/ 16 <0xff01>;
 
 		port {
 			usb1_sbu_mux: endpoint {
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
index 5ae057ad6438..a93170e57229 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
+++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
@@ -329,7 +329,6 @@ usb0-sbu-mux {
 
 		mode-switch;
 		orientation-switch;
-		svid = /bits/ 16 <0xff01>;
 
 		port {
 			usb0_sbu_mux: endpoint {
@@ -349,7 +348,6 @@ usb1-sbu-mux {
 
 		mode-switch;
 		orientation-switch;
-		svid = /bits/ 16 <0xff01>;
 
 		port {
 			usb1_sbu_mux: endpoint {
diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
index d3788bd72ac3..0c4829e876f3 100644
--- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
+++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
@@ -348,7 +348,6 @@ typec-mux@42 {
 		vcc-supply = <&vreg_bob>;
 		mode-switch;
 		orientation-switch;
-		svid = /bits/ 16 <0xff01>;
 
 		ports {
 			#address-cells = <1>;
diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
index d5aeb7319776..c9676e7f2c69 100644
--- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
+++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
@@ -517,7 +517,6 @@ typec-mux@42 {
 		vcc-supply = <&vreg_bob>;
 		mode-switch;
 		orientation-switch;
-		svid = /bits/ 16 <0xff01>;
 
 		ports {
 			#address-cells = <1>;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: Drop undocumented "svid" property
  2023-05-31  2:49 [PATCH] arm64: dts: qcom: Drop undocumented "svid" property Bjorn Andersson
@ 2023-05-31  9:24 ` Neil Armstrong
  2023-07-10  5:07 ` Bjorn Andersson
  1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2023-05-31  9:24 UTC (permalink / raw)
  To: Bjorn Andersson, Bjorn Andersson, Konrad Dybcio
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
	devicetree, linux-kernel

On 31/05/2023 04:49, Bjorn Andersson wrote:
> The Linux typec_mux implementation required that a property named "svid"
> was present in the remote node of the of_graph for a match to be found.
> 
> With the introduction of commit '4aebc4f89f00 ("usb: typec: mux: Clean up
> mux_fwnode_match()")', the implementation is aligned with the binding
> and this property can be dropped - and the associated DeviceTree
> validation warning resolved.
> 
> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
> ---
> 
> The referred to patch is present in usb-next.
> 

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: Drop undocumented "svid" property
  2023-05-31  2:49 [PATCH] arm64: dts: qcom: Drop undocumented "svid" property Bjorn Andersson
  2023-05-31  9:24 ` Neil Armstrong
@ 2023-07-10  5:07 ` Bjorn Andersson
  1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2023-07-10  5:07 UTC (permalink / raw)
  To: Konrad Dybcio, Bjorn Andersson
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
	devicetree, linux-kernel


On Tue, 30 May 2023 19:49:44 -0700, Bjorn Andersson wrote:
> The Linux typec_mux implementation required that a property named "svid"
> was present in the remote node of the of_graph for a match to be found.
> 
> With the introduction of commit '4aebc4f89f00 ("usb: typec: mux: Clean up
> mux_fwnode_match()")', the implementation is aligned with the binding
> and this property can be dropped - and the associated DeviceTree
> validation warning resolved.
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: Drop undocumented "svid" property
      commit: e0f250c8fd012b010cdae0535903402765f7ffe5

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-07-10  5:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-31  2:49 [PATCH] arm64: dts: qcom: Drop undocumented "svid" property Bjorn Andersson
2023-05-31  9:24 ` Neil Armstrong
2023-07-10  5:07 ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).