Re: [PATCH 0/2] Baisc devicetree support for Amlogic T7

Conor Dooley
2023-06-27T07:26:30Z

[-- Attachment #1: Type: text/plain, Size: 1315 bytes --]

On Tue, Jun 27, 2023 at 02:13:34PM +0800, Xianwei Zhao wrote:
> Hi Conor,
> Thanks for you reply.
> On 2023/6/26 18:02, Conor Dooley wrote:
>
>
> > [ EXTERNAL EMAIL ]
> >
> > Hey,
> >
> > On Mon, Jun 26, 2023 at 05:52:21PM +0800, Xianwei Zhao wrote:
> >> T7 is an advanced application processor designed for smart display.
> >>
> >> Add the new T7 SoC/board device tree bindings.
> >>
> >> Add basic support for the T7 based Amlogic AN400 board, which describes
> >> the following components: CPU, GIC, IRQ, Timer, UART. It's capable of
> >> booting up into the serial console.
> >
> > Lucas has already sent patches for the T7 SoC & is at v5:
> > https://lore.kernel.org/linux-devicetree/20230623081242.109131-1-tanure@linux.com/
> >
> > There's been a bit of discussion there, and there serial stuff in
> > particular is different in his series (it doesn't use always-on for
> > examples).
> > Could you please go and take a look at his series?
> >
> > Cheers,
> > Conor.
> >
> AN400 is the reference board designed by Amlogic, which is different from
> Khadas VIM4.

Yet you share the same dtsi, which he has got through several iterations
of before you arrived.

> And T7 serial is the same as S4, so I follow S4 serial.

Yeah, no. SoC specific compatible please.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]