public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: nick.hawkins@hpe.com
Cc: verdun@hpe.com, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/5] dt-bindings: net: Add HPE GXP UMAC
Date: Sat, 22 Jul 2023 00:01:36 +0200	[thread overview]
Message-ID: <57d882ed-82e5-4584-8126-ca2007064126@lunn.ch> (raw)
In-Reply-To: <20230721212044.59666-4-nick.hawkins@hpe.com>

> +examples:
> +  - |
> +    ethernet@4000 {
> +      compatible = "hpe,gxp-umac";
> +      reg = <0x4000 0x80>;
> +      interrupts = <22>;
> +      mac-address = [00 00 00 00 00 00]; /* Filled in by U-Boot */

Do both ports get the sane MAC address? 

> +      ethernet-ports {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        port@0 {
> +          reg = <0>;
> +          phy-handle = <&eth_phy0>;
> +        };
> +
> +        port@1 {
> +          reg = <1>;
> +          phy-handle = <&eth_phy1>;
> +        };
> +      };
> +
> +      mdio {

This seems to be wrong. You have a standalone MDIO bus driver, not
part of the MAC address space?

	Andrew

  reply	other threads:[~2023-07-21 22:01 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-21 21:20 [PATCH v1 0/5] ARM: Add GXP UMAC Support nick.hawkins
2023-07-21 21:20 ` [PATCH v1 1/5] dt-bindings: net: Add HPE GXP UMAC MDIO nick.hawkins
2023-07-24 17:33   ` Conor Dooley
2023-07-21 21:20 ` [PATCH v1 2/5] net: hpe: Add " nick.hawkins
2023-07-21 21:39   ` Christophe JAILLET
2023-07-21 21:57   ` Andrew Lunn
2023-07-24 14:41   ` Simon Horman
2023-07-21 21:20 ` [PATCH v1 3/5] dt-bindings: net: Add HPE GXP UMAC nick.hawkins
2023-07-21 22:01   ` Andrew Lunn [this message]
2023-07-25 13:44     ` Hawkins, Nick
2023-07-25 17:51       ` Andrew Lunn
     [not found]         ` <DM4PR84MB19274F3AA411D4CAE7EE84D88803A@DM4PR84MB1927.NAMPRD84.PROD.OUTLOOK.COM>
2023-07-26 14:43           ` Hawkins, Nick
2023-07-26 15:56           ` Andrew Lunn
2023-07-24 16:20   ` Rob Herring
2023-07-21 21:20 ` [PATCH v1 4/5] net: hpe: Add GXP UMAC Driver nick.hawkins
2023-07-21 22:00   ` Christophe JAILLET
2023-07-21 22:29   ` Andrew Lunn
2023-07-24 15:01   ` Simon Horman
2023-07-21 21:20 ` [PATCH v1 5/5] MAINTAINERS: HPE: Add GXP UMAC Networking Files nick.hawkins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57d882ed-82e5-4584-8126-ca2007064126@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nick.hawkins@hpe.com \
    --cc=pabeni@redhat.com \
    --cc=robh+dt@kernel.org \
    --cc=verdun@hpe.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox