From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4362ACCA489 for ; Tue, 26 Jul 2022 10:27:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238682AbiGZK1V (ORCPT ); Tue, 26 Jul 2022 06:27:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238661AbiGZK1R (ORCPT ); Tue, 26 Jul 2022 06:27:17 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3151532054 for ; Tue, 26 Jul 2022 03:27:16 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id q23so8762557lfr.3 for ; Tue, 26 Jul 2022 03:27:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=TMi+bjKy7+WtWPXtstlGwzQClNVWhga6kNx+LvTNJdY=; b=cGoPyMRCRG1wVftIfDL0na3cR29l2mbznyINOy4G21vt7LkfhPNzCVn6pGP92k84OI B3r9JWWwZgF1DS4ZIMn3FDhOdugj7ni01vQWYboEGeYxzRzryZesnfwyOvY8p/pMz1HT ks4iYsZYSEOo+pUjiKWCGNcizbTnIgv4nmxUGCM7DKfpjutAecKTuRiur6oobhlZSRjh UDCx0GnkIvsg0RZ4BgdyCV5pjqFrvHEvqatCcqBFiBlZ+Z0HUzNEe+gSWzD+A4/FOdoS iiFiGL59QhmvJkx7/w1ZlV+2Fj0LPrBzQ+XLbeqBExysWr1e0n55QPV79+oHnPJXlH0L ZzZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=TMi+bjKy7+WtWPXtstlGwzQClNVWhga6kNx+LvTNJdY=; b=OZaMhLvnU1B/0u05qq9/6rphiV39MpSlUBYSq24dWlYbd3ji1NA73TDqGyAPRWwwxv eOjb/79Q/UBoHcHWLODdPuyPCEVV69SCnGoAKasZhjagyQM+jf5ob0YGC10mTgtN5fJT U86DCeh/isvxV0cNKW3PJiHaGjSRZbhxgRvzAKWhgpck0EpM5yGOVzjzi+qpulj2mmxo HYVIWEHT4fiZlu+E7nEK9Xwl/QdTHfJjYM0b0ZHM4BZga4FmyG5fleUIGruKFWIJ9Msw jAcu4m8ENbDnljafMHkxjTn0+GX+KpOpnLH/W3PMNltMuqWFOXvQEFpFVLmD0UJA5Cuv YMjg== X-Gm-Message-State: AJIora8OenjCNqd/o1Cq0sRaw8eyQRNkrM7QFooy+TYDybuUjUOqHas0 jt79fIhdJTJKZbZTKK24KOncG5+VAg1R/CXo X-Google-Smtp-Source: AGRyM1uo4j3H6oHQ9Qu/k+9ltEMAux8NWWJeXFv14NJa5aTEhvH9PCsvcwnh/gZG5kUyOKOSY2asMQ== X-Received: by 2002:a05:6512:3503:b0:481:4470:4134 with SMTP id h3-20020a056512350300b0048144704134mr6017873lfs.42.1658831234451; Tue, 26 Jul 2022 03:27:14 -0700 (PDT) Received: from [192.168.3.197] (78-26-46-173.network.trollfjord.no. [78.26.46.173]) by smtp.gmail.com with ESMTPSA id b15-20020a056512070f00b0048a7901903esm2357778lfs.144.2022.07.26.03.27.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Jul 2022 03:27:14 -0700 (PDT) Message-ID: <57f8d9c4-6f49-ad3d-fc82-7a0f66d1775a@linaro.org> Date: Tue, 26 Jul 2022 12:27:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v4 2/2] power: reset: qcom-pon: add support for qcom,pmk8350-pon compatible string Content-Language: en-US To: Anjelique Melendez , corbet@lwn.net, sre@kernel.org, robh+dt@kernel.org, agross@kernel.org, bjorn.andersson@linaro.org Cc: krzysztof.kozlowski+dt@linaro.org, vkoul@kernel.org, linux-doc@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220725191314.19456-1-quic_amelende@quicinc.com> <20220725191314.19456-3-quic_amelende@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <20220725191314.19456-3-quic_amelende@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 25/07/2022 21:13, Anjelique Melendez wrote: > Add support for the new "qcom,pmk8350-pon" comptaible string. > > Signed-off-by: Anjelique Melendez > --- > drivers/power/reset/qcom-pon.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/power/reset/qcom-pon.c b/drivers/power/reset/qcom-pon.c > index 4a688741a88a..16bc01738be9 100644 > --- a/drivers/power/reset/qcom-pon.c > +++ b/drivers/power/reset/qcom-pon.c > @@ -82,6 +82,7 @@ static const struct of_device_id pm8916_pon_id_table[] = { > { .compatible = "qcom,pm8916-pon", .data = (void *)GEN1_REASON_SHIFT }, > { .compatible = "qcom,pms405-pon", .data = (void *)GEN1_REASON_SHIFT }, > { .compatible = "qcom,pm8998-pon", .data = (void *)GEN2_REASON_SHIFT }, > + { .compatible = "qcom,pmk8350-pon", .data = (void *)GEN2_REASON_SHIFT }, > { } > }; > MODULE_DEVICE_TABLE(of, pm8916_pon_id_table); This is now confusing. The new device has entirely different first and second IO address spaces, but you do not code here any differences. Best regards, Krzysztof