From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nayna Subject: Re: [PATCH v2 2/2] Documentation: tpm: add the Physical TPM device tree binding documentation Date: Mon, 17 Oct 2016 07:44:31 +0530 Message-ID: <58043407.9070601@linux.vnet.ibm.com> References: <1475051441-23008-1-git-send-email-nayna@linux.vnet.ibm.com> <1475051441-23008-2-git-send-email-nayna@linux.vnet.ibm.com> <20161008210522.GB22112@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20161008210522.GB22112@rob-hp-laptop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Rob Herring Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org, honclo-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, cclaudio-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org List-Id: devicetree@vger.kernel.org On 10/09/2016 02:35 AM, Rob Herring wrote: > On Wed, Sep 28, 2016 at 04:30:41AM -0400, Nayna Jain wrote: >> Newly added support of TPM 2.0 eventlog securityfs pseudo files in tpm >> device driver consumes device tree bindings representing I2C based >> Physical TPM. This patch adds the documentation for corresponding device >> tree bindings of I2C based Physical TPM. These bindings are similar to >> vtpm device tree bindings being used on IBM Power7+ and Power8 Systems >> running PowerVM. >> >> Suggested-by: Jason Gunthorpe >> Signed-off-by: Nayna Jain >> --- >> Changelog v2: >> >> - Include review feedbacks. >> - Move the doc within bindings/security/tpm. >> - Add example for compatible property in description. >> - Delete implicit properties like status, label from description. >> - Redefine linux,sml-base description. >> >> .../devicetree/bindings/security/tpm/tpm-i2c.txt | 20 ++++++++++++++++++++ >> 1 file changed, 20 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/security/tpm/tpm-i2c.txt >> >> diff --git a/Documentation/devicetree/bindings/security/tpm/tpm-i2c.txt b/Documentation/devicetree/bindings/security/tpm/tpm-i2c.txt >> new file mode 100644 >> index 0000000..16df8bb >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/security/tpm/tpm-i2c.txt >> @@ -0,0 +1,20 @@ >> +* Device Tree Bindings for I2C based Trusted Platform Module(TPM) >> + >> +Required properties: >> + >> +- compatible : 'manufacturer,model', eg. nuvoton,npct650 >> +- linux,sml-base : 64-bit base address of the reserved memory allocated for >> + the firmware event log >> +- linux,sml-size : size of the memory allocated for the firmware event log >> + >> +Example (for OpenPower Systems with Nuvoton TPM 2.0 on I2C) >> +---------------------------------------------------------- >> + >> +tpm@57 { >> + reg = <0x57>; >> + label = "tpm"; > > Not documented, but why? label is really only useful when you have > multiple items that humans need to identify like ports on ethernet > switch or LEDs. Sorry, I think I misinterpreted one of the earliar feedback. I will document it again. Thanks & Regards, - Nayna > >> + compatible = "nuvoton,npct650", "nuvoton,npct601"; >> + linux,sml-base = <0x7f 0xfd450000>; >> + linux,sml-size = <0x10000>; >> + status = "okay"; >> +}; >> -- >> 2.5.0 >> > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot