* [PATCH] arm64: dts: qcom: msm8916: Fix iommu local address range
@ 2023-09-15 5:06 Gaurav Kohli
2023-09-15 5:13 ` Pavan Kondeti
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Gaurav Kohli @ 2023-09-15 5:06 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, krzysztof.kozlowski+dt
Cc: linux-arm-msm, kernel, devicetree, Gaurav Kohli
Fix the apps iommu local address space range as per data sheet.
Fixes: 327c0f5f2510 ("arm64: dts: qcom: msm8916: Sort nodes")
Signed-off-by: Gaurav Kohli <quic_gkohli@quicinc.com>
diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
index 33fb65d73104..3c934363368c 100644
--- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
@@ -1813,7 +1813,7 @@
#size-cells = <1>;
#iommu-cells = <1>;
compatible = "qcom,msm8916-iommu", "qcom,msm-iommu-v1";
- ranges = <0 0x01e20000 0x40000>;
+ ranges = <0 0x01e20000 0x20000>;
reg = <0x01ef0000 0x3000>;
clocks = <&gcc GCC_SMMU_CFG_CLK>,
<&gcc GCC_APSS_TCU_CLK>;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: qcom: msm8916: Fix iommu local address range
2023-09-15 5:06 [PATCH] arm64: dts: qcom: msm8916: Fix iommu local address range Gaurav Kohli
@ 2023-09-15 5:13 ` Pavan Kondeti
2023-09-15 14:06 ` Bryan O'Donoghue
2023-09-15 14:06 ` Bryan O'Donoghue
2 siblings, 0 replies; 4+ messages in thread
From: Pavan Kondeti @ 2023-09-15 5:13 UTC (permalink / raw)
To: Gaurav Kohli
Cc: agross, andersson, konrad.dybcio, krzysztof.kozlowski+dt,
linux-arm-msm, kernel, devicetree
On Fri, Sep 15, 2023 at 10:36:11AM +0530, Gaurav Kohli wrote:
> Fix the apps iommu local address space range as per data sheet.
>
> Fixes: 327c0f5f2510 ("arm64: dts: qcom: msm8916: Sort nodes")
> Signed-off-by: Gaurav Kohli <quic_gkohli@quicinc.com>
>
The above quoted commit it Fixes tag did not introduce the problem. This
is introduced in
6a6729f38436("arm64: dts: qcom: msm8916: Add IOMMU support")
with that fixed, the change looks good to me.
> diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> index 33fb65d73104..3c934363368c 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> @@ -1813,7 +1813,7 @@
> #size-cells = <1>;
> #iommu-cells = <1>;
> compatible = "qcom,msm8916-iommu", "qcom,msm-iommu-v1";
> - ranges = <0 0x01e20000 0x40000>;
> + ranges = <0 0x01e20000 0x20000>;
> reg = <0x01ef0000 0x3000>;
> clocks = <&gcc GCC_SMMU_CFG_CLK>,
> <&gcc GCC_APSS_TCU_CLK>;
Thanks,
Pavan
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: qcom: msm8916: Fix iommu local address range
2023-09-15 5:06 [PATCH] arm64: dts: qcom: msm8916: Fix iommu local address range Gaurav Kohli
2023-09-15 5:13 ` Pavan Kondeti
@ 2023-09-15 14:06 ` Bryan O'Donoghue
2023-09-15 14:06 ` Bryan O'Donoghue
2 siblings, 0 replies; 4+ messages in thread
From: Bryan O'Donoghue @ 2023-09-15 14:06 UTC (permalink / raw)
To: Gaurav Kohli, agross, andersson, konrad.dybcio,
krzysztof.kozlowski+dt
Cc: linux-arm-msm, kernel, devicetree
On 15/09/2023 06:06, Gaurav Kohli wrote:
> Fix the apps iommu local address space range as per data sheet.
>
> Fixes: 327c0f5f2510 ("arm64: dts: qcom: msm8916: Sort nodes")
> Signed-off-by: Gaurav Kohli <quic_gkohli@quicinc.com>
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> index 33fb65d73104..3c934363368c 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> @@ -1813,7 +1813,7 @@
> #size-cells = <1>;
> #iommu-cells = <1>;
> compatible = "qcom,msm8916-iommu", "qcom,msm-iommu-v1";
> - ranges = <0 0x01e20000 0x40000>;
> + ranges = <0 0x01e20000 0x20000>;
> reg = <0x01ef0000 0x3000>;
> clocks = <&gcc GCC_SMMU_CFG_CLK>,
> <&gcc GCC_APSS_TCU_CLK>;
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Tested-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: qcom: msm8916: Fix iommu local address range
2023-09-15 5:06 [PATCH] arm64: dts: qcom: msm8916: Fix iommu local address range Gaurav Kohli
2023-09-15 5:13 ` Pavan Kondeti
2023-09-15 14:06 ` Bryan O'Donoghue
@ 2023-09-15 14:06 ` Bryan O'Donoghue
2 siblings, 0 replies; 4+ messages in thread
From: Bryan O'Donoghue @ 2023-09-15 14:06 UTC (permalink / raw)
To: Gaurav Kohli, agross, andersson, konrad.dybcio,
krzysztof.kozlowski+dt
Cc: linux-arm-msm, kernel, devicetree
On 15/09/2023 06:06, Gaurav Kohli wrote:
> Fix the apps iommu local address space range as per data sheet.
>
> Fixes: 327c0f5f2510 ("arm64: dts: qcom: msm8916: Sort nodes")
> Signed-off-by: Gaurav Kohli <quic_gkohli@quicinc.com>
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> index 33fb65d73104..3c934363368c 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> @@ -1813,7 +1813,7 @@
> #size-cells = <1>;
> #iommu-cells = <1>;
> compatible = "qcom,msm8916-iommu", "qcom,msm-iommu-v1";
> - ranges = <0 0x01e20000 0x40000>;
> + ranges = <0 0x01e20000 0x20000>;
> reg = <0x01ef0000 0x3000>;
> clocks = <&gcc GCC_SMMU_CFG_CLK>,
> <&gcc GCC_APSS_TCU_CLK>;
from the @linaro.org address
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Tested-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-09-15 14:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-15 5:06 [PATCH] arm64: dts: qcom: msm8916: Fix iommu local address range Gaurav Kohli
2023-09-15 5:13 ` Pavan Kondeti
2023-09-15 14:06 ` Bryan O'Donoghue
2023-09-15 14:06 ` Bryan O'Donoghue
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).