From: Helge Deller <deller@gmx.de>
To: Jakub Turek <jakub.turek@elsta.tech>,
Javier Martinez Canillas <javierm@redhat.com>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] fbdev: ssd1307fb: add support for Sino Wealth SH1107 controller
Date: Fri, 31 Jul 2026 14:43:19 +0200 [thread overview]
Message-ID: <580fd486-ec67-4db3-8235-e835f0c40eab@gmx.de> (raw)
In-Reply-To: <20260731-feat-sh1107-v1-1-e10977f76e6b@elsta.tech>
On 7/31/26 12:46, Jakub Turek wrote:
> The SH1107 display controller is very similar to SSD1307 but the main
> difference is that SH1107 has different memory layout and uses page mode
> adressation only.
>
> The SH1107 relies primarily on vertical page addressing mode where the
> internal 128x128 GDDRAM is split into 16 vertical pages, rather than
> the horizontal/tile addressing modes natively utilized by the
> SSD1306/SSD1307.
>
> Signed-off-by: Jakub Turek <jakub.turek@elsta.tech>
> ---
> drivers/video/fbdev/ssd1307fb.c | 234 ++++++++++++++++++++++++++--------------
> 1 file changed, 155 insertions(+), 79 deletions(-)
This patch has many unnecessary white space cleanups.
Please split it up in at least two patches: One with real code additions and fixes,
the other (if you like) a patch to clean up indenting and such.
Helge
next prev parent reply other threads:[~2026-07-31 12:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 10:46 [PATCH 0/2] fbdev: ssd1307fb: add SH1107 support Jakub Turek
2026-07-31 10:46 ` [PATCH 1/2] fbdev: ssd1307fb: add support for Sino Wealth SH1107 controller Jakub Turek
2026-07-31 11:09 ` sashiko-bot
2026-07-31 12:43 ` Helge Deller [this message]
2026-07-31 13:02 ` Javier Martinez Canillas
2026-07-31 10:46 ` [PATCH 2/2] dt-bindings: display: solomon,ssd1307fb: add SH1107 compatible Jakub Turek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=580fd486-ec67-4db3-8235-e835f0c40eab@gmx.de \
--to=deller@gmx.de \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jakub.turek@elsta.tech \
--cc=javierm@redhat.com \
--cc=krzk+dt@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox