From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-op-o12.zoho.com (sender4-op-o12.zoho.com [136.143.188.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75F9A1531DA; Wed, 21 Aug 2024 20:38:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.12 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724272740; cv=pass; b=Oe18eiwOuu/RZC3vc5+gVua+7yjgvd5DvAyDWsNH9RmxPxh60dVZlnQ2RkF0ojTzSTL6oyIazVCDK+pUV+S7dE15o5dhFQp5zMoR5Ud9JHWshI2wp6NVcB+CNFPZ25Kt2a7EhVOgtYa4IbEBr4I5sHYi9A4VES9CQ3mUB8LGcow= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724272740; c=relaxed/simple; bh=JtWwYyUYRpuWyz3CWJqn7O4nLn6nocm7LJDRY370nMc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=G+ceASOBMDC2g8xkVsZSqq4h5DkiN9Exkl6awZj8HzGVxwKHUHs5QpiYkN1to4v3KIU9VrBlPjDPyKu7pL6fLcLWQU90/U/znwHbfqrzO5x60A1W0z7/4HeFeG4gLqvYLUX41htR/F+mXp5BhCRYLbbogDvuUi1ZuIARrc4PRQk= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=cristian.ciocaltea@collabora.com header.b=G2Qgbf+f; arc=pass smtp.client-ip=136.143.188.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=cristian.ciocaltea@collabora.com header.b="G2Qgbf+f" ARC-Seal: i=1; a=rsa-sha256; t=1724272691; cv=none; d=zohomail.com; s=zohoarc; b=gkPi36rxlLW4SXhcJ7TsEx9UFal77hztufoJNuKbW34wX4mFQkp1p4dH6/D9xqu+7Qw/ZdwuEmtDlHzaFcNgvic8rEXY2vmMH1T/OwiqCGo6kUSyUPPuTNU9z1L5lwKl4jvUNuHs6wbMV2n9RQoiYpF+HVNHLeqUw+mqDBdYwLI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1724272691; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=rn/jPcfndwOGlmUfjvgjuRv6xjB54zy9vNZlgxr2C8A=; b=JO26rMR7n8PfcasVMvM8FQ053kPSaxiuJY/mQkLDo6d1S6USefUkix1DBoCJ1pw7+6otUHRPKzG6JuHpyWDAKtN7YO1iEvcCrClS/I8lT3CCMB6lpzuGcl40gefkhEhBvqIESdkq/iraQQtksHDEIZb4OCO8OlUJTfXkdSNdbZ4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=cristian.ciocaltea@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1724272691; s=zohomail; d=collabora.com; i=cristian.ciocaltea@collabora.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=rn/jPcfndwOGlmUfjvgjuRv6xjB54zy9vNZlgxr2C8A=; b=G2Qgbf+fYDaUCrzI4JUaB+8dp0zKq0j1FNWUxOb97NABn7Dfz+TuVicqioEEn53s pUGRjYHNRirFC2ehQArQUMdPNlRXgwn1z98fsdkB0lcfGVkpCg93eZCuiGA533w8pG3 CWyVVIM7VJ0v2eAFLC+jTO6kioCqH5x7E3wP3A3Q= Received: by mx.zohomail.com with SMTPS id 1724272689131684.716009062432; Wed, 21 Aug 2024 13:38:09 -0700 (PDT) Message-ID: <5813cea2-4890-4fa9-8826-19be5bf3e161@collabora.com> Date: Wed, 21 Aug 2024 23:38:01 +0300 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/4] dt-bindings: display: rockchip: Add schema for RK3588 HDMI TX Controller To: Conor Dooley Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Andy Yan , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mark Yao , Sascha Hauer , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@collabora.com, Alexandre ARNOUD , Luis de Arquer References: <20240819-b4-rk3588-bridge-upstream-v4-0-6417c72a2749@collabora.com> <20240819-b4-rk3588-bridge-upstream-v4-3-6417c72a2749@collabora.com> <20240819-bobbing-purplish-99e48baa2304@spud> <20240820-tropics-hunchback-6fdcd0b37f91@spud> <038073d0-d4b9-4938-9a51-ea2aeb4530f6@collabora.com> <20240821-evoke-mop-fb09ceef3597@spud> Content-Language: en-US From: Cristian Ciocaltea In-Reply-To: <20240821-evoke-mop-fb09ceef3597@spud> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 8/21/24 6:07 PM, Conor Dooley wrote: > On Tue, Aug 20, 2024 at 11:12:45PM +0300, Cristian Ciocaltea wrote: >> On 8/20/24 7:14 PM, Conor Dooley wrote: >>> On Tue, Aug 20, 2024 at 03:37:44PM +0300, Cristian Ciocaltea wrote: >>>> On 8/19/24 7:53 PM, Conor Dooley wrote: >>>>> On Mon, Aug 19, 2024 at 01:29:30AM +0300, Cristian Ciocaltea wrote: >>>>>> + rockchip,grf: >>>>>> + $ref: /schemas/types.yaml#/definitions/phandle >>>>>> + description: >>>>>> + Most HDMI QP related data is accessed through SYS GRF regs. >>>>>> + >>>>>> + rockchip,vo1-grf: >>>>>> + $ref: /schemas/types.yaml#/definitions/phandle >>>>>> + description: >>>>>> + Additional HDMI QP related data is accessed through VO1 GRF regs. >>>>> >>>>> Why are these required? What prevents you looking up the syscons by >>>>> compatible? >>>> >>>> That is for getting the proper instance: >>> >>> Ah, that makes sense. I am, however, curious why these have the same >>> compatible when they have different sized regions allocated to them. >> >> Good question, didn't notice. I've just checked the TRM and, in both >> cases, the maximum register offset is within the 0x100 range. Presumably >> this is nothing but an inconsistency, as the syscons have been added in >> separate commits. > > Is that TRM publicly available? I do find it curious that devices sound > like they have different contents have the same compatible. In my view, > that is incorrect and they should have unique compatibles if the > contents (and therefore the programming model) differs. Don't know if there's an official location to get it from, but a quick search on internet shows a few repos providing them, e.g. [1]. Comparing "6.14 VO0_GRF Register Description" at pg. 777 with "6.15 VO1_GRF Register Description" at pg. 786 (from Part1) reveals the layout is mostly similar, with a few variations though. [1] https://github.com/FanX-Tek/rk3588-TRM-and-Datasheet >> >>>> vo0_grf: syscon@fd5a6000 { >>>> compatible = "rockchip,rk3588-vo-grf", "syscon"; >>>> reg = <0x0 0xfd5a6000 0x0 0x2000>; >>>> clocks = <&cru PCLK_VO0GRF>; >>>> }; >>>> >>>> vo1_grf: syscon@fd5a8000 { >>>> compatible = "rockchip,rk3588-vo-grf", "syscon"; >>>> reg = <0x0 0xfd5a8000 0x0 0x100>; >>>> clocks = <&cru PCLK_VO1GRF>; >>>> }; >