* [PATCH v10 0/2] Add tps53685 support @ 2025-06-19 6:42 Chiang Brian 2025-06-19 6:42 ` [PATCH v10 1/2] dt-bindings: trivial: " Chiang Brian 2025-06-19 6:42 ` [PATCH v10 2/2] hwmon: (pmbus/tps53679) Add support for TPS53685 Chiang Brian 0 siblings, 2 replies; 5+ messages in thread From: Chiang Brian @ 2025-06-19 6:42 UTC (permalink / raw) To: jdelvare, linux, robh, krzk+dt, conor+dt Cc: linux-hwmon, devicetree, linux-kernel, Chiang Brian The TPS53685 is a fully AMD SVI3 compliant step down controller with trans-inductor voltage regulator(TLVR) topology support, dual channels, built-in non-volatile memory (NVM), PMBus interface, and full compatible with TI NexFET smart power stages. Add support for TPS53685 device to dt-bindings and pmbus driver. --- v9 -> v10: - Fix the inconsistent indenting in switch case with tab instead of space - Run the smatch kchecker to confirm - Link to v9: https://lore.kernel.org/all/20250610102556.236300-1-chiang.brian@inventec.com/ v8 -> v9: - dt-bindings: Correct the order of Acked-by tag - hwmon: Fix the alignment to match open parenthesis - Wrap commit message body at 75 columns - Link to v8: https://lore.kernel.org/all/20250602042454.184643-2-chiang.brian@inventec.com/ v7 -> v8: - dt-bindings: Include missing Acked-by tag - dt-bindings: Patch kept in sync with series version - hwmon: Fixed device_id parameter type and test make.cross of i386 - Link to dt-bindings v3: https://lore.kernel.org/all/20250515081449.1433772-2-chiang.brian@inventec.com/ - Link to hwmon v7: https://lore.kernel.org/all/20250515081449.1433772-3-chiang.brian@inventec.com/ v6 -> v7: - dt-bindings: Fix the order of patches - hwmon: Modify the type of device_id from u16 to char * - Run make.cross with ARCH nios2, powerpc, and riscv - Link to dt-bindings v2: https://lore.kernel.org/all/20250424132538.2004510-3-chiang.brian@inventec.corp-partner.google.com/ - Link to hwmon v6: https://lore.kernel.org/all/20250424132538.2004510-2-chiang.brian@inventec.corp-partner.google.com/ v5 -> v6: - dt-bindings: Correct the subject and commit message - hwmon: information about tps53685 into tps53679.rst - hwmon: Add additional flags when identifing the chip as tps53685 - hwmon: Adjust length once returned device id is terminated by null character - Link to dt-bindings v1: https://lore.kernel.org/all/20250314032802.3187097-1-chiang.brian@inventec.com/ - Link to hwmon v5: https://lore.kernel.org/all/20250314033040.3190642-1-chiang.brian@inventec.com/ v4 -> v5: - add support for tps53685 in dt-bindings - add the buffer length as argument for %*ph - Add Changelog - Link to v4: https://lore.kernel.org/all/CAJCfHmW61d2jd_tYpNEqBG_Z58bEnVKAmsvhrEP1zXQoXqrUVw@mail.gmail.com/ v3 -> v4: - Add length comparison into the comparison of "id",or it may be true when the substring of "id" matches device id. - Restore `return 0;` in `tps53679_identify_chip()` - Link to v3: https://lore.kernel.org/all/CAJCfHmVyaDPh0_ThPjhBP0zMO1oE1AR=4=Zsa0cMPXU3J4v6dw@mail.gmail.com/ v2 -> v3: - Remove the length comparsion in the comparison of "id". - Link to v2: https://lore.kernel.org/all/CAJCfHmUteFM+nUZWBWvmwFjALg1QUL5r+=syU1HmYTL1ewQWqA@mail.gmail.com/ v1 -> v2: - Modify subject and description to meet requirements - Add "tps53685" into enum chips with numeric order - Modify the content of marco "TPS53681_DEVICE_ID" from 0x81 to "\x81" - Add marco "TPS53685_DEVICE_ID" with content "TIShP" - Modify the type of "id" from u16 to char* in `tps53679_identify_chip()` - Modify the comparison of "id". It will be true if the string "id" matches device ID and compare with type char* - Add the length comparsion into the comparison of "id". - Modify "len" as return code in `tps53679_identify_chip()` - Output device error log with %*ph, instead of 0x%x\n" - Use existing tps53679_identify_multiphase() with argument "TPS53685_DEVICE_ID" in tps53685_identify() rather than creating one tps53685_identify_multiphase() - Link to v1: https://lore.kernel.org/all/CAJCfHmVy3O4-nz2_PKF7TcXYr+HqTte1-bdUWLBmV7JOS7He1g@mail.gmail.com/ Chiang Brian (2): dt-bindings: trivial: Add tps53685 support hwmon: (pmbus/tps53679) Add support for TPS53685 .../devicetree/bindings/trivial-devices.yaml | 2 + Documentation/hwmon/tps53679.rst | 8 ++++ drivers/hwmon/pmbus/tps53679.c | 37 ++++++++++++++++--- 3 files changed, 41 insertions(+), 6 deletions(-) -- 2.43.0 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v10 1/2] dt-bindings: trivial: Add tps53685 support 2025-06-19 6:42 [PATCH v10 0/2] Add tps53685 support Chiang Brian @ 2025-06-19 6:42 ` Chiang Brian 2025-07-16 20:09 ` Guenter Roeck 2025-06-19 6:42 ` [PATCH v10 2/2] hwmon: (pmbus/tps53679) Add support for TPS53685 Chiang Brian 1 sibling, 1 reply; 5+ messages in thread From: Chiang Brian @ 2025-06-19 6:42 UTC (permalink / raw) To: jdelvare, linux, robh, krzk+dt, conor+dt Cc: linux-hwmon, devicetree, linux-kernel, Chiang Brian Add device type support for tps53685 Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Signed-off-by: Chiang Brian <chiang.brian@inventec.com> --- v9 -> v10: - No code changed - Link to v9: https://lore.kernel.org/all/20250610102556.236300-2-chiang.brian@inventec.com/ v8 -> v9: - No code changed, correct the order of Acked-by tag - Link to v8: https://lore.kernel.org/all/20250602042454.184643-2-chiang.brian@inventec.com/ v3 -> v8: - No code changed, included Acked-by tag from v2 review - Patch kept in sync with series version - Link to v3: https://lore.kernel.org/all/20250515081449.1433772-2-chiang.brian@inventec.com/ v2 -> v3: - Fix the order of patches - Link to v2: https://lore.kernel.org/all/20250424132538.2004510-3-chiang.brian@inventec.corp-partner.google.com/ v1 -> v2: - Correct the subject and commit message - Link to v1: https://lore.kernel.org/all/20250314032802.3187097-1-chiang.brian@inventec.com/ Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml index 27930708ccd5..a613b9c3f6ea 100644 --- a/Documentation/devicetree/bindings/trivial-devices.yaml +++ b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -396,6 +396,8 @@ properties: - ti,tps53679 # TI Dual channel DCAP+ multiphase controller TPS53681 - ti,tps53681 + # TI Dual channel DCAP+ multiphase controller TPS53685 with AMD-SVI3 + - ti,tps53685 # TI Dual channel DCAP+ multiphase controller TPS53688 - ti,tps53688 # TI DC-DC converters on PMBus -- 2.43.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v10 1/2] dt-bindings: trivial: Add tps53685 support 2025-06-19 6:42 ` [PATCH v10 1/2] dt-bindings: trivial: " Chiang Brian @ 2025-07-16 20:09 ` Guenter Roeck 0 siblings, 0 replies; 5+ messages in thread From: Guenter Roeck @ 2025-07-16 20:09 UTC (permalink / raw) To: Chiang Brian Cc: jdelvare, robh, krzk+dt, conor+dt, linux-hwmon, devicetree, linux-kernel On Thu, Jun 19, 2025 at 02:42:22PM +0800, Chiang Brian wrote: > Add device type support for tps53685 > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Chiang Brian <chiang.brian@inventec.com> Applied. Thanks, Guenter ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v10 2/2] hwmon: (pmbus/tps53679) Add support for TPS53685 2025-06-19 6:42 [PATCH v10 0/2] Add tps53685 support Chiang Brian 2025-06-19 6:42 ` [PATCH v10 1/2] dt-bindings: trivial: " Chiang Brian @ 2025-06-19 6:42 ` Chiang Brian 2025-07-16 20:09 ` Guenter Roeck 1 sibling, 1 reply; 5+ messages in thread From: Chiang Brian @ 2025-06-19 6:42 UTC (permalink / raw) To: jdelvare, linux, robh, krzk+dt, conor+dt Cc: linux-hwmon, devicetree, linux-kernel, Chiang Brian The TPS53685 is a fully AMD SVI3 compliant step down controller with trans-inductor voltage regulator(TLVR) topology support, dual channels, built-in non-volatile memory (NVM), PMBus interface, and full compatible with TI NexFET smart power stages. Add support for it to the tps53679 driver. Signed-off-by: Chiang Brian <chiang.brian@inventec.com> --- v9 -> v10: - Fix the inconsistent indenting in switch case with tab instead of space - Run the smatch kchecker to confirm - Link to v9: https://lore.kernel.org/all/20250610102556.236300-3-chiang.brian@inventec.com/ v8 -> v9: - Wrap commit message body at 75 columns - Fix the alignment to match open parenthesis - Link to v8: https://lore.kernel.org/all/20250602042454.184643-3-chiang.brian@inventec.com/ v7 -> v8: - Convert the type of device_id in tps53679_identify_multiphase() from int to char * - Run make.cross with ARCH i386 - Link to v7: https://lore.kernel.org/all/20250515081449.1433772-3-chiang.brian@inventec.com/ v6 -> v7: - Modify the type of device_id from u16 to char * - Run make.cross with ARCH nios2, powerpc, and riscv - Link to v6: https://lore.kernel.org/all/20250424132538.2004510-2-chiang.brian@inventec.corp-partner.google.com/ v5 -> v6: - Add information about tps53685 into tps53679.rst - Add additional flags when identifing the chip as tps53685 - Adjust length once returned device id is terminated by null character - Link to v5: https://lore.kernel.org/all/20250314033040.3190642-1-chiang.brian@inventec.com/ v4 -> v5: - document the compatible of tps53685 into dt-bindings - add the buffer length as argument for %*ph - Add Changelog - Link to v4: https://lore.kernel.org/all/CAJCfHmW61d2jd_tYpNEqBG_Z58bEnVKAmsvhrEP1zXQoXqrUVw@mail.gmail.com/ v3 -> v4: - Add length comparison into the comparison of "id",or it may be true when the substring of "id" matches device id. - Restore `return 0;` in `tps53679_identify_chip()` - Link to v3: https://lore.kernel.org/all/CAJCfHmVyaDPh0_ThPjhBP0zMO1oE1AR=4=Zsa0cMPXU3J4v6dw@mail.gmail.com/ v2 -> v3: - Remove the length comparsion in the comparison of "id". - Link to v2: https://lore.kernel.org/all/CAJCfHmUteFM+nUZWBWvmwFjALg1QUL5r+=syU1HmYTL1ewQWqA@mail.gmail.com/ v1 -> v2: - Modify subject and description to meet requirements - Add "tps53685" into enum chips with numeric order - Modify the content of marco "TPS53681_DEVICE_ID" from 0x81 to "\x81" - Add marco "TPS53685_DEVICE_ID" with content "TIShP" - Modify the type of "id" from u16 to char* in `tps53679_identify_chip()` - Modify the comparison of "id". It will be true if the string "id" matches device ID and compare with type char*, - Add the length comparsion into the comparison of "id". - Modify "len" as return code in `tps53679_identify_chip()` - Output device error log with %*ph, instead of 0x%x\n" - Use existing tps53679_identify_multiphase() with argument "TPS53685_DEVICE_ID" in tps53685_identify() rather than creating one tps53685_identify_multiphase() - Link to v1: https://lore.kernel.org/all/CAJCfHmVy3O4-nz2_PKF7TcXYr+HqTte1-bdUWLBmV7JOS7He1g@mail.gmail.com/ Documentation/hwmon/tps53679.rst | 8 +++++++ drivers/hwmon/pmbus/tps53679.c | 37 ++++++++++++++++++++++++++------ 2 files changed, 39 insertions(+), 6 deletions(-) diff --git a/Documentation/hwmon/tps53679.rst b/Documentation/hwmon/tps53679.rst index 3b9561648c24..dd5e4a37375d 100644 --- a/Documentation/hwmon/tps53679.rst +++ b/Documentation/hwmon/tps53679.rst @@ -43,6 +43,14 @@ Supported chips: Datasheet: https://www.ti.com/lit/gpn/TPS53681 + * Texas Instruments TPS53685 + + Prefix: 'tps53685' + + Addresses scanned: - + + Datasheet: https://www.ti.com/lit/gpn/TPS53685 + * Texas Instruments TPS53688 Prefix: 'tps53688' diff --git a/drivers/hwmon/pmbus/tps53679.c b/drivers/hwmon/pmbus/tps53679.c index 63524dff5e75..ca2bfa25eb04 100644 --- a/drivers/hwmon/pmbus/tps53679.c +++ b/drivers/hwmon/pmbus/tps53679.c @@ -16,7 +16,7 @@ #include "pmbus.h" enum chips { - tps53647, tps53667, tps53676, tps53679, tps53681, tps53688 + tps53647, tps53667, tps53676, tps53679, tps53681, tps53685, tps53688 }; #define TPS53647_PAGE_NUM 1 @@ -31,7 +31,8 @@ enum chips { #define TPS53679_PROT_VR13_5MV 0x07 /* VR13.0 mode, 5-mV DAC */ #define TPS53679_PAGE_NUM 2 -#define TPS53681_DEVICE_ID 0x81 +#define TPS53681_DEVICE_ID "\x81" +#define TPS53685_DEVICE_ID "TIShP" #define TPS53681_PMBUS_REVISION 0x33 @@ -86,10 +87,12 @@ static int tps53679_identify_phases(struct i2c_client *client, } static int tps53679_identify_chip(struct i2c_client *client, - u8 revision, u16 id) + u8 revision, char *id) { u8 buf[I2C_SMBUS_BLOCK_MAX]; int ret; + int buf_len; + int id_len; ret = pmbus_read_byte_data(client, 0, PMBUS_REVISION); if (ret < 0) @@ -102,8 +105,14 @@ static int tps53679_identify_chip(struct i2c_client *client, ret = i2c_smbus_read_block_data(client, PMBUS_IC_DEVICE_ID, buf); if (ret < 0) return ret; - if (ret != 1 || buf[0] != id) { - dev_err(&client->dev, "Unexpected device ID 0x%x\n", buf[0]); + + /* Adjust length if null terminator if present */ + buf_len = (buf[ret - 1] != '\x00' ? ret : ret - 1); + + id_len = strlen(id); + + if (buf_len != id_len || strncmp(id, buf, id_len)) { + dev_err(&client->dev, "Unexpected device ID: %*ph\n", ret, buf); return -ENODEV; } return 0; @@ -117,7 +126,7 @@ static int tps53679_identify_chip(struct i2c_client *client, */ static int tps53679_identify_multiphase(struct i2c_client *client, struct pmbus_driver_info *info, - int pmbus_rev, int device_id) + int pmbus_rev, char *device_id) { int ret; @@ -138,6 +147,16 @@ static int tps53679_identify(struct i2c_client *client, return tps53679_identify_mode(client, info); } +static int tps53685_identify(struct i2c_client *client, + struct pmbus_driver_info *info) +{ + info->func[1] |= PMBUS_HAVE_VIN | PMBUS_HAVE_IIN | PMBUS_HAVE_PIN | + PMBUS_HAVE_STATUS_INPUT; + info->format[PSC_VOLTAGE_OUT] = linear; + return tps53679_identify_chip(client, TPS53681_PMBUS_REVISION, + TPS53685_DEVICE_ID); +} + static int tps53681_identify(struct i2c_client *client, struct pmbus_driver_info *info) { @@ -263,6 +282,10 @@ static int tps53679_probe(struct i2c_client *client) info->identify = tps53681_identify; info->read_word_data = tps53681_read_word_data; break; + case tps53685: + info->pages = TPS53679_PAGE_NUM; + info->identify = tps53685_identify; + break; default: return -ENODEV; } @@ -277,6 +300,7 @@ static const struct i2c_device_id tps53679_id[] = { {"tps53676", tps53676}, {"tps53679", tps53679}, {"tps53681", tps53681}, + {"tps53685", tps53685}, {"tps53688", tps53688}, {} }; @@ -289,6 +313,7 @@ static const struct of_device_id __maybe_unused tps53679_of_match[] = { {.compatible = "ti,tps53676", .data = (void *)tps53676}, {.compatible = "ti,tps53679", .data = (void *)tps53679}, {.compatible = "ti,tps53681", .data = (void *)tps53681}, + {.compatible = "ti,tps53685", .data = (void *)tps53685}, {.compatible = "ti,tps53688", .data = (void *)tps53688}, {} }; -- 2.43.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v10 2/2] hwmon: (pmbus/tps53679) Add support for TPS53685 2025-06-19 6:42 ` [PATCH v10 2/2] hwmon: (pmbus/tps53679) Add support for TPS53685 Chiang Brian @ 2025-07-16 20:09 ` Guenter Roeck 0 siblings, 0 replies; 5+ messages in thread From: Guenter Roeck @ 2025-07-16 20:09 UTC (permalink / raw) To: Chiang Brian Cc: jdelvare, robh, krzk+dt, conor+dt, linux-hwmon, devicetree, linux-kernel On Thu, Jun 19, 2025 at 02:42:23PM +0800, Chiang Brian wrote: > The TPS53685 is a fully AMD SVI3 compliant step down controller with > trans-inductor voltage regulator(TLVR) topology support, dual channels, > built-in non-volatile memory (NVM), PMBus interface, and full compatible > with TI NexFET smart power stages. > > Add support for it to the tps53679 driver. > > Signed-off-by: Chiang Brian <chiang.brian@inventec.com> Applied. Thanks, Guenter > --- > v9 -> v10: > - Fix the inconsistent indenting in switch case with tab instead of space > - Run the smatch kchecker to confirm > - Link to v9: https://lore.kernel.org/all/20250610102556.236300-3-chiang.brian@inventec.com/ > > v8 -> v9: > - Wrap commit message body at 75 columns > - Fix the alignment to match open parenthesis > - Link to v8: https://lore.kernel.org/all/20250602042454.184643-3-chiang.brian@inventec.com/ > > v7 -> v8: > - Convert the type of device_id in tps53679_identify_multiphase() from int to char * > - Run make.cross with ARCH i386 > - Link to v7: https://lore.kernel.org/all/20250515081449.1433772-3-chiang.brian@inventec.com/ > > v6 -> v7: > - Modify the type of device_id from u16 to char * > - Run make.cross with ARCH nios2, powerpc, and riscv > - Link to v6: https://lore.kernel.org/all/20250424132538.2004510-2-chiang.brian@inventec.corp-partner.google.com/ > > v5 -> v6: > - Add information about tps53685 into tps53679.rst > - Add additional flags when identifing the chip as tps53685 > - Adjust length once returned device id is terminated by null character > - Link to v5: https://lore.kernel.org/all/20250314033040.3190642-1-chiang.brian@inventec.com/ > > v4 -> v5: > - document the compatible of tps53685 into dt-bindings > - add the buffer length as argument for %*ph > - Add Changelog > - Link to v4: https://lore.kernel.org/all/CAJCfHmW61d2jd_tYpNEqBG_Z58bEnVKAmsvhrEP1zXQoXqrUVw@mail.gmail.com/ > > v3 -> v4: > - Add length comparison into the comparison of "id",or it may be true when the substring of "id" matches device id. > - Restore `return 0;` in `tps53679_identify_chip()` > - Link to v3: https://lore.kernel.org/all/CAJCfHmVyaDPh0_ThPjhBP0zMO1oE1AR=4=Zsa0cMPXU3J4v6dw@mail.gmail.com/ > > v2 -> v3: > - Remove the length comparsion in the comparison of "id". > - Link to v2: https://lore.kernel.org/all/CAJCfHmUteFM+nUZWBWvmwFjALg1QUL5r+=syU1HmYTL1ewQWqA@mail.gmail.com/ > > v1 -> v2: > - Modify subject and description to meet requirements > - Add "tps53685" into enum chips with numeric order > - Modify the content of marco "TPS53681_DEVICE_ID" from 0x81 to "\x81" > - Add marco "TPS53685_DEVICE_ID" with content "TIShP" > - Modify the type of "id" from u16 to char* in `tps53679_identify_chip()` > - Modify the comparison of "id". It will be true if the string "id" matches device ID and compare with type char*, > - Add the length comparsion into the comparison of "id". > - Modify "len" as return code in `tps53679_identify_chip()` > - Output device error log with %*ph, instead of 0x%x\n" > - Use existing tps53679_identify_multiphase() with argument "TPS53685_DEVICE_ID" in tps53685_identify() rather than creating one tps53685_identify_multiphase() > - Link to v1: https://lore.kernel.org/all/CAJCfHmVy3O4-nz2_PKF7TcXYr+HqTte1-bdUWLBmV7JOS7He1g@mail.gmail.com/ > > Documentation/hwmon/tps53679.rst | 8 +++++++ > drivers/hwmon/pmbus/tps53679.c | 37 ++++++++++++++++++++++++++------ > 2 files changed, 39 insertions(+), 6 deletions(-) > > diff --git a/Documentation/hwmon/tps53679.rst b/Documentation/hwmon/tps53679.rst > index 3b9561648c24..dd5e4a37375d 100644 > --- a/Documentation/hwmon/tps53679.rst > +++ b/Documentation/hwmon/tps53679.rst > @@ -43,6 +43,14 @@ Supported chips: > > Datasheet: https://www.ti.com/lit/gpn/TPS53681 > > + * Texas Instruments TPS53685 > + > + Prefix: 'tps53685' > + > + Addresses scanned: - > + > + Datasheet: https://www.ti.com/lit/gpn/TPS53685 > + > * Texas Instruments TPS53688 > > Prefix: 'tps53688' > diff --git a/drivers/hwmon/pmbus/tps53679.c b/drivers/hwmon/pmbus/tps53679.c > index 63524dff5e75..ca2bfa25eb04 100644 > --- a/drivers/hwmon/pmbus/tps53679.c > +++ b/drivers/hwmon/pmbus/tps53679.c > @@ -16,7 +16,7 @@ > #include "pmbus.h" > > enum chips { > - tps53647, tps53667, tps53676, tps53679, tps53681, tps53688 > + tps53647, tps53667, tps53676, tps53679, tps53681, tps53685, tps53688 > }; > > #define TPS53647_PAGE_NUM 1 > @@ -31,7 +31,8 @@ enum chips { > #define TPS53679_PROT_VR13_5MV 0x07 /* VR13.0 mode, 5-mV DAC */ > #define TPS53679_PAGE_NUM 2 > > -#define TPS53681_DEVICE_ID 0x81 > +#define TPS53681_DEVICE_ID "\x81" > +#define TPS53685_DEVICE_ID "TIShP" > > #define TPS53681_PMBUS_REVISION 0x33 > > @@ -86,10 +87,12 @@ static int tps53679_identify_phases(struct i2c_client *client, > } > > static int tps53679_identify_chip(struct i2c_client *client, > - u8 revision, u16 id) > + u8 revision, char *id) > { > u8 buf[I2C_SMBUS_BLOCK_MAX]; > int ret; > + int buf_len; > + int id_len; > > ret = pmbus_read_byte_data(client, 0, PMBUS_REVISION); > if (ret < 0) > @@ -102,8 +105,14 @@ static int tps53679_identify_chip(struct i2c_client *client, > ret = i2c_smbus_read_block_data(client, PMBUS_IC_DEVICE_ID, buf); > if (ret < 0) > return ret; > - if (ret != 1 || buf[0] != id) { > - dev_err(&client->dev, "Unexpected device ID 0x%x\n", buf[0]); > + > + /* Adjust length if null terminator if present */ > + buf_len = (buf[ret - 1] != '\x00' ? ret : ret - 1); > + > + id_len = strlen(id); > + > + if (buf_len != id_len || strncmp(id, buf, id_len)) { > + dev_err(&client->dev, "Unexpected device ID: %*ph\n", ret, buf); > return -ENODEV; > } > return 0; > @@ -117,7 +126,7 @@ static int tps53679_identify_chip(struct i2c_client *client, > */ > static int tps53679_identify_multiphase(struct i2c_client *client, > struct pmbus_driver_info *info, > - int pmbus_rev, int device_id) > + int pmbus_rev, char *device_id) > { > int ret; > > @@ -138,6 +147,16 @@ static int tps53679_identify(struct i2c_client *client, > return tps53679_identify_mode(client, info); > } > > +static int tps53685_identify(struct i2c_client *client, > + struct pmbus_driver_info *info) > +{ > + info->func[1] |= PMBUS_HAVE_VIN | PMBUS_HAVE_IIN | PMBUS_HAVE_PIN | > + PMBUS_HAVE_STATUS_INPUT; > + info->format[PSC_VOLTAGE_OUT] = linear; > + return tps53679_identify_chip(client, TPS53681_PMBUS_REVISION, > + TPS53685_DEVICE_ID); > +} > + > static int tps53681_identify(struct i2c_client *client, > struct pmbus_driver_info *info) > { > @@ -263,6 +282,10 @@ static int tps53679_probe(struct i2c_client *client) > info->identify = tps53681_identify; > info->read_word_data = tps53681_read_word_data; > break; > + case tps53685: > + info->pages = TPS53679_PAGE_NUM; > + info->identify = tps53685_identify; > + break; > default: > return -ENODEV; > } > @@ -277,6 +300,7 @@ static const struct i2c_device_id tps53679_id[] = { > {"tps53676", tps53676}, > {"tps53679", tps53679}, > {"tps53681", tps53681}, > + {"tps53685", tps53685}, > {"tps53688", tps53688}, > {} > }; > @@ -289,6 +313,7 @@ static const struct of_device_id __maybe_unused tps53679_of_match[] = { > {.compatible = "ti,tps53676", .data = (void *)tps53676}, > {.compatible = "ti,tps53679", .data = (void *)tps53679}, > {.compatible = "ti,tps53681", .data = (void *)tps53681}, > + {.compatible = "ti,tps53685", .data = (void *)tps53685}, > {.compatible = "ti,tps53688", .data = (void *)tps53688}, > {} > }; ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-07-16 20:10 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-06-19 6:42 [PATCH v10 0/2] Add tps53685 support Chiang Brian 2025-06-19 6:42 ` [PATCH v10 1/2] dt-bindings: trivial: " Chiang Brian 2025-07-16 20:09 ` Guenter Roeck 2025-06-19 6:42 ` [PATCH v10 2/2] hwmon: (pmbus/tps53679) Add support for TPS53685 Chiang Brian 2025-07-16 20:09 ` Guenter Roeck
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).