From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64CC048123D for ; Tue, 14 Jul 2026 15:47:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784044071; cv=none; b=L+ORrGbCS3JemKH4UmWY9MFx7OXcrsciSw1N9khsJqCcuPL9ZQGuy4/RZhEmsQ3xbprtHUcnZmMtI6S7TRFxu6sjXuaq1ZAfQBwBUz5EXoWumLg7XuGsbe7fLGu4XRUSGUJZjzfKuoLt/iEXK+Aeq4iHPiTt95Oew+n/MAEN7L8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784044071; c=relaxed/simple; bh=UI8L3jXrZB+lzWZFyrflCCgxBDCTbAE23u842wAsS+U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=C25m0XQ724qDfC3Pz03AAbT8xizWlpXC4cK44aouNpLf9ElvO6H0rUUfCHgUBEYurKUZaNgJSih1UrMt9Ma9NsWUURJPhnPpNDw6nLLpaSTbJfsdiCP1YDLskHZIKy3TG+pLFMwBeOgeo7QnVgH+E2+8WrIGgnZ1JvI/vxkbam8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SpmBG1uL; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AG1IrD6c; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SpmBG1uL"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AG1IrD6c" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66EEcUDq893522 for ; Tue, 14 Jul 2026 15:47:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= UI8L3jXrZB+lzWZFyrflCCgxBDCTbAE23u842wAsS+U=; b=SpmBG1uLM3jPrS2Y rF5VeXmIvrCcz1zJhsUKFYaokICHjyy2q5iiKCWnhuOLGQkuwSgPJa7UE+q1c9pL 6eO1+PgmNTsttc8O6RW14lOueTnB1cgSN5HpLSODq9uj6WtE5HD14/he3j7ZJ0AU UdbuJzN2nj804VCS3JaFucnmYtaSMLB/rcBTemL1NTNLSg3B/2pncNmMCZJHrOeN U56pnf4nOnBkWmwnyhxNQmjgNtZnt2wq36oH+JvJH/5Tgs2Lo+yPuKJV6Ng/HpG9 011nJBUpTyMMoIdgtfA82ZiT/bQ82kW85F8+0YG1GM39YAQ9CFvXv2dIY3Ynekii fWTKFQ== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fdnnqrqed-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 14 Jul 2026 15:47:46 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-3811279d51aso2190576a91.1 for ; Tue, 14 Jul 2026 08:47:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784044066; x=1784648866; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=UI8L3jXrZB+lzWZFyrflCCgxBDCTbAE23u842wAsS+U=; b=AG1IrD6cw4iZnarjVNKDpmq+cSgI9bK+EPITZPNzKX5ZvNKWwgF/PQyy9utoO4tSZq 6A4WSKLbkkDd5KM1MDSVmY6LBjWalkUjagvqjCMUov9pWmKwE1bAadavdEb/Aaz55MaR k5SKKb7wdy79Z780oT2HX62W0RG6BPMAVAFehQzKR5JS3EqfwST8nLkiYCOs0ZEyGV9E 3yR7kpLSaxChp3E208N/KjGO511bS4dXCxtlrG/ITmESF0sT3fl9aps/W5dWYmzs5OZf bwUE3HCLKs034ckMaY/O6tonyL4UUJXBa0GLA3NiZCFywwz7DDIzo0ezI6hiGBoTKX7W IKnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784044066; x=1784648866; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=UI8L3jXrZB+lzWZFyrflCCgxBDCTbAE23u842wAsS+U=; b=PHJ1w4aSWvjh9o5B+VcT+BmRiQXXanEbf9VLnPX4POtNiK8SS2dOoEz/BFX6Yq0Hqk Us2SobLw8swfPFiTZrBZe06h76o2eLtMeAfjjlOQ47MzwyWJ1e6vxtvXZpoOH7DPaxOb ALDz4ihHwpsqU+v5ZdJL6FlyWeGqQWdRMaghaHIfTMcsJHDOGAvF+df59WufpnJ/TRuk oSTczH2tjGqzEAUZGc/ckT4K6gbucgQvXbatravuDtyrUe7MBB41Zt3Lyc+tbHpboj+D w1stwL8tyBXjaTBQWF24re0JL4M8PdqXZe1hwAn1eakPc9i1tuafVbATWuj9i2dQEn/5 FYZg== X-Forwarded-Encrypted: i=1; AHgh+Rr5k80hMmhpxAtD/qGsNCiXrCwtX6bQVwwolA+wuds0J5GMtePwjWXgODAsWhRpNboNE7s2awO/8eHy@vger.kernel.org X-Gm-Message-State: AOJu0YyJbaMb3Mf5ftPk/NLXoW5t63yHA4sLIG3z9h020JA8eKfpG5b2 oFp85LAhx6fNshBdUS2Ri24FgVBH3JITiiOc+f5vDxeHcryOIR/ku42I7UgKuFHRs2SRAmhliyk FDyDI00vpAlfAJ8LcmhOAdgaFaoZ+hnV6AIOerO0nEv5RlcO1kLZHdzOpd0HmLxe1 X-Gm-Gg: AfdE7clya+/2qSVq7OOr/n0uYgB6OPDtL+0EBm3+OYnaKr5zrDbO6y8f+rz5I1yd63R K2STqQ0JSfVoH/YDuuMukbei2EfgOAA9rcurqkJiU0QCMg35sBmS65qadmzdu/XI99nrXIlmrp1 ZsaIeGDW9mbXmG2IRjN5uGYdRjtol7EdUP/GPF22LFjHkF3RWOaVpns81/HhCySXmyCWhni3gCe cbmCP132QWzQRo4lnc5Ed3eFFJ4U/zgVxpZzUOpECtWmTGXmzh4gebso8qBDY28IUUA/Jr/W2UK UYZjRQ3SH06AxitHIBfY+BzLRMMuIH1YMd9xFlwTCqovPTRn4qYscqN1m8HDjdQNYmvffbKCojS OPKAI4GTXCLpUk4WMh6cUJH0Gqy6EKpxE6jIx8TfiXVq88KU= X-Received: by 2002:a17:90b:38c8:b0:38d:dbc7:5178 with SMTP id 98e67ed59e1d1-38ddbc75254mr11115621a91.22.1784044065760; Tue, 14 Jul 2026 08:47:45 -0700 (PDT) X-Received: by 2002:a17:90b:38c8:b0:38d:dbc7:5178 with SMTP id 98e67ed59e1d1-38ddbc75254mr11115587a91.22.1784044065298; Tue, 14 Jul 2026 08:47:45 -0700 (PDT) Received: from [192.168.0.116] ([124.123.151.85]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31174accb0esm84444133eec.30.2026.07.14.08.47.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jul 2026 08:47:44 -0700 (PDT) Message-ID: <582d12f5-bb73-4702-9e10-234d46b3fc93@oss.qualcomm.com> Date: Tue, 14 Jul 2026 21:17:37 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] net: wwan: qcom_bam_dmux: Alloc RX buffers as a single coherent block To: Stephan Gerhold Cc: Stephan Gerhold , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Loic Poulain , Sergey Ryazanov , Johannes Berg , linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, chris.lew@oss.qualcomm.com, Deepak Kumar Singh References: <20260714-qcom-bam-dmux-vmid-ext-v1-0-3f29da7cca76@oss.qualcomm.com> <20260714-qcom-bam-dmux-vmid-ext-v1-2-3f29da7cca76@oss.qualcomm.com> Content-Language: en-US From: Vishnu Santhosh In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE0MDE2MyBTYWx0ZWRfX19/SZrfzdZmU W+CfstxgaHJQ4aZ8TreI+OIRkR2u+K45FKsgX+2JM0uLjoDFYwg58tV6SXj7Em5EabOKEqvrP15 FYPJzJq2OQOa9n8oSNvkamf4iBCm8c7xJNmu8C9HBq2/fPZCN4/uhZUDixTO2SD5pBVW1RfyqLK O+cTf39po34aBezYYeE4l8I9AbnYd/DtwVACpSdHj98cWdzbPSnVAmBS4T6NJ/nY34BYfeZax45 vQ9Iow3nOy+UR7fzCR8QUk0N74pjVae2pEJTGzHDytEZgQcr0ijuTT5z36E98isoPr2L3v8wDZt +8edbxmYVO0DB5SjaYEtL6bSeNRao5Xm9hUSEkE/8tkTSqBkajFLhGL1GraWdNWeVOG75V/q6TC 5TZuN0guITj5my6AJXEPfLW16wLjxUZmDvoL3Xho4cRR1Oh9jGGeQDm4eriz3Xw69ExMvr/f1hJ sQb0ST+2nztVrhSWj8A== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE0MDE2MyBTYWx0ZWRfX+YDfPFWWVo11 e6XvpRrI7Lg7FAG2PdDuz1dw5L1Y3YgcZqDHIqIYHa4LiOdugV+jQTeY/uI6/czYAiBdUZjSiBT xww42nBYau7+SPe8CDDvF8tD7WMu6E4= X-Authority-Analysis: v=2.4 cv=U+Oiy+ru c=1 sm=1 tr=0 ts=6a565a22 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=ziBI+Y3eO/H+UwYWWny9Hg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=2eDN7aXksB4whfXZn5AA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-GUID: 3ARp0RX269egq6qE8l5knM-vzHGK0w2q X-Proofpoint-ORIG-GUID: 3ARp0RX269egq6qE8l5knM-vzHGK0w2q X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-14_03,2026-07-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607140163 On 14-07-2026 01:05 pm, Stephan Gerhold wrote: > On Tue, Jul 14, 2026 at 11:02:32AM +0530, Vishnu Santhosh wrote: >> On Qualcomm SoCs where the modem (e.g. the mDSP on Shikra, VMID 43 / >> NAV) is the AXI master for BAM-DMUX RX transfers and the XPU enforces >> per-region access control, each individually DMA-mapped RX buffer >> requires its own XPU resource group (RG). With ~16 RGs available, the >> 32 per-buffer dma_map_single() calls exhaust the table and the first >> inbound transfer faults with an XPU violation. >> >> BAM-DMUX is a singleton (exactly one instance per SoC), so the >> destination VMID does not need to be a DT property; it is looked up >> from the compatible string's match data instead. Add struct >> bam_dmux_data with a single vmid field, and a shikra_data instance >> hardcoding QCOM_SCM_VMID_NAV for qcom,shikra-bam-dmux. >> >> When match data is present, allocate all BAM_DMUX_NUM_SKB RX buffers as >> a single contiguous dma_alloc_coherent() block and SCM-assign that >> block to HLOS plus the VMID once at probe. This reduces RG consumption >> from 32 to 1. The block is never reclaimed across a modem power cycle >> (bam_dmux_power_off() does not touch it), so the probe-time assignment >> covers every subsequent restart without re-assigning or reclaiming. It >> is reclaimed to HLOS only once, at remove or on a probe error, and if >> that reclaim fails it is leaked rather than returned to the page >> allocator. >> >> Each rx_skbs[] slot is pre-assigned its virtual and DMA address from >> the block, so no per-buffer mapping is needed at power-on. Because the >> coherent block is not page-backed, received payload is copied into a >> regular netdev skb before handoff to the network stack; this is an >> unavoidable extra copy on the XPU-enforced RX path. >> >> Platforms without match data are unaffected: rx_virt stays NULL, no >> coherent memory is allocated, and the per-buffer dma_map_single() path >> is unchanged. >> >> Co-developed-by: Deepak Kumar Singh >> Signed-off-by: Deepak Kumar Singh >> Signed-off-by: Vishnu Santhosh > So how do you handle TX buffers? Right now, they are just passed on from > the net subsystem. There can be up to 32 TX buffers in progress as well. > > Overall, I have mixed feelings about this patch. It looks reasonably > simple, but fundamentally I don't understand why we need to go back to > the old days of implementing protection using a highly limited MPU (in > your case: the xPU). > > Why does the setup of BAM-DMUX differ e.g. from the setup for the crypto > engine? Crypto is also using bam-dma, but it avoids this inflexibility > by making use of the &apps_smmu. Is BAM-DMUX not covered by the SMMU? Or > did you just decide to bypass the SMMU in this case? (If so: Why?) > > If you had BAM-DMUX mapped using the SMMU you would get all of this for > free. No changes would be needed in the BAM-DMUX driver ... > > Thanks, > Stephan Thanks for pointing out. We were seeing XPU violations on descriptor FIFO accesses in the RX path. This series resolves the RX-side faults, which is why we posted it. It appears that the TX path requires equivalent handling, and we'll include the necessary TX changes in v2 of this series. Currently, the SMMU does not cover this A2 BAM instance on Shikra, which is why we opted for the SCM-assign approach. I'll check with the hardware team to better understand why BAM-DMUX is not behind the SMMU, gather the relevant details, and get back. Thanks, Vishnu