From: Robin Murphy <robin.murphy@arm.com>
To: Marc Zyngier <maz@kernel.org>
Cc: Matt Ranostay <mranostay@ti.com>, Nishanth Menon <nm@ti.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: ti: k3-j721s2: fix overlapping GICD memory region
Date: Thu, 16 Jun 2022 13:19:08 +0100 [thread overview]
Message-ID: <582e4c0b-5cd3-7fac-cba7-7250a458a60d@arm.com> (raw)
In-Reply-To: <87y1xw3iy9.wl-maz@kernel.org>
On 2022-06-16 13:13, Marc Zyngier wrote:
> On Thu, 16 Jun 2022 13:07:23 +0100,
> Robin Murphy <robin.murphy@arm.com> wrote:
>>
>> On 2022-06-16 11:51, Matt Ranostay wrote:
>>> GICD region was overlapping with GICR causing the latter to not map
>>> successfully, and in turn the gic-v3 driver would fail to initialize.
>>>
>>> This issue was hidden till commit 2b2cd74a06c3 ("irqchip/gic-v3: Claim iomem resources")
>>> replaced of_iomap() calls with of_io_request_and_map() that internally
>>> called request_mem_region().
>>>
>>> Respective console output before this patchset:
>>>
>>> [ 0.000000] GICv3: /bus@100000/interrupt-controller@1800000: couldn't map region 0
>>
>> Oh, it's nice that this finds bugs, but it seems I hadn't fully
>> considered that making the simple easy change in the DT paths results
>> in different behaviour from ACPI.
>>
>> Marc, would you like a fix for this to remain non-fatal even in the
>> face of a dodgy DT, or are you happy with being a bit stricter now?
>
> I'd rather we work around it. I shout at people for breaking existing
> DTs, so this should apply to the GIC as well. A nice WARN_ON_ONCE()
> should do, if you don't mind writing the patch.
Indeed, I think that would be my default preference as well - apologies
for the oversight! I'll spin the patch shortly (and make the warning
consistent for the ACPI side too).
Cheers,
Robin.
next prev parent reply other threads:[~2022-06-16 12:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 10:51 [PATCH] arm64: dts: ti: k3-j721s2: fix overlapping GICD memory region Matt Ranostay
2022-06-16 12:07 ` Robin Murphy
2022-06-16 12:13 ` Marc Zyngier
2022-06-16 12:19 ` Robin Murphy [this message]
2022-06-17 13:05 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=582e4c0b-5cd3-7fac-cba7-7250a458a60d@arm.com \
--to=robin.murphy@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=mranostay@ti.com \
--cc=nm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox