From: Markus Elfring <Markus.Elfring@web.de>
To: Yuji Ishikawa <yuji2.ishikawa@toshiba.co.jp>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Conor Dooley <conor+dt@kernel.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mark Brown <broonie@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
Rob Herring <robh@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v11 3/6] media: platform: visconti: Add Toshiba Visconti Video Input Interface driver
Date: Tue, 9 Jul 2024 09:47:31 +0200 [thread overview]
Message-ID: <582f0e6e-7f8b-41db-b08e-5783943dddde@web.de> (raw)
In-Reply-To: <20240709000848.1108788-4-yuji2.ishikawa@toshiba.co.jp>
…
> +++ b/drivers/media/platform/toshiba/visconti/viif_capture.c
> @@ -0,0 +1,1431 @@
…
> +static int viif_set_img(struct cap_dev *cap_dev, struct vb2_buffer *vb)
> +{
…
> + if (cap_dev->pathid == CAPTURE_PATH_MAIN_POST0) {
> + spin_lock(&viif_dev->regbuf_lock);
> + hwd_viif_isp_guard_start(viif_dev);
…
> + hwd_viif_isp_guard_end(viif_dev);
> + spin_unlock(&viif_dev->regbuf_lock);
…
Under which circumstances would you become interested to apply a statement
like “guard(spinlock)(&viif_dev->regbuf_lock);”?
https://elixir.bootlin.com/linux/v6.10-rc7/source/include/linux/spinlock.h#L561
Regards,
Markus
next prev parent reply other threads:[~2024-07-09 7:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-09 0:08 [PATCH v11 0/6] Add Toshiba Visconti Video Input Interface driver Yuji Ishikawa
2024-07-09 0:08 ` [PATCH v11 1/6] dt-bindings: media: platform: visconti: Add Toshiba Visconti Video Input Interface Yuji Ishikawa
2024-07-22 15:21 ` Laurent Pinchart
2024-08-01 9:21 ` yuji2.ishikawa
2024-07-09 0:08 ` [PATCH v11 2/6] media: videodev2.h: add visconti viif meta buffer format Yuji Ishikawa
2024-07-22 15:10 ` Laurent Pinchart
2024-07-22 15:12 ` Laurent Pinchart
2024-08-01 9:20 ` yuji2.ishikawa
2024-07-09 0:08 ` [PATCH v11 3/6] media: platform: visconti: Add Toshiba Visconti Video Input Interface driver Yuji Ishikawa
2024-07-09 7:47 ` Markus Elfring [this message]
2024-07-18 23:46 ` yuji2.ishikawa
2024-07-22 22:08 ` Laurent Pinchart
2024-08-01 9:27 ` yuji2.ishikawa
2024-08-01 17:28 ` Laurent Pinchart
2024-08-08 0:48 ` yuji2.ishikawa
2024-07-09 0:08 ` [PATCH v11 4/6] media: platform: visconti: add streaming interface for ISP parameters and status Yuji Ishikawa
2024-07-09 0:08 ` [PATCH v11 5/6] documentation: media: add documentation for Toshiba Visconti Video Input Interface driver Yuji Ishikawa
2024-07-22 18:02 ` Laurent Pinchart
2024-08-01 9:23 ` yuji2.ishikawa
2024-08-01 16:06 ` Laurent Pinchart
2024-08-08 0:42 ` yuji2.ishikawa
2024-07-09 0:08 ` [PATCH v11 6/6] MAINTAINERS: Add entries for Toshiba Visconti Video Input Interface Yuji Ishikawa
2024-07-22 15:17 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=582f0e6e-7f8b-41db-b08e-5783943dddde@web.de \
--to=markus.elfring@web.de \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=yuji2.ishikawa@toshiba.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).