From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CA61C7EE2C for ; Fri, 26 May 2023 15:57:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243668AbjEZP5u (ORCPT ); Fri, 26 May 2023 11:57:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243941AbjEZP5i (ORCPT ); Fri, 26 May 2023 11:57:38 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 271F413D for ; Fri, 26 May 2023 08:57:37 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-3093d10442aso562671f8f.1 for ; Fri, 26 May 2023 08:57:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685116655; x=1687708655; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IOSdHbR4Wu88gf7m1ZCJ5+Wng1YTJWHsPTDZi1tytEc=; b=iZkGp3rzWyMeUUblP834O+UQ2YuoWf08u41UqDcS4Npz1dqcp1O/ImUgSLOxQcl/fc UIWUsLhdRfav36oQ5CxIjNlaxUG2bCO0GxRPFWB4RGK+Qx/EVgMywpN7GBsa5ip2Kpx/ tGwc5QvVcRx5poX6nrgiiZ9HdKVC5vABK0y+ZKMbJgxce+ulQQZW58SbR+UIZrHuyXNc hDHZxw4ICeSseGYaKBzAW3fduWCqZv2H7GwlT5YoF56Jwo3BT5f8ollDNt8pWGMQqMpy pj/z1mgCX5HF4HwpNr48W8SGHlSoqgWEdNEulXC+JjA3mDB4Q68SbVIYsCT1ujWI7wSE aDkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685116655; x=1687708655; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IOSdHbR4Wu88gf7m1ZCJ5+Wng1YTJWHsPTDZi1tytEc=; b=XQd/nC8KabD3AHQf0msh296D5Ucm/2GlXv9cDvv1cnDodMmSA0qIRnA+MHa0EBI6wG 5DaZW4pYH9nsnqAWb12MwIMn5fkOhQLrhm6Q2vm+eBf6saAkjyt7Unn8IxULUZRNqEFU f272BNL/6bx2pYC3SKdV/jWv+vv02CxiHE1mgWJwGGmI2zvKFE/saETPLzWP9r7E0UAx nz+ID4F4XyYq5K1brEiaBxqW33k0R66tWNVCmzP3+Wvzz5B3zgWiHFMnLqsYaloS0MM6 ipLRS7aAXIkz6b+mhSvngJk15k5jT3DFdjvaQjWXmCsbo2yt4KH+57tWmcDwERoNbeCx KtZw== X-Gm-Message-State: AC+VfDzqj96GG2x1cNyofetbdo69rNRocv+r60XyEMv7ZkRG6zUO5is4 n5KdZ9cYuLeeRep7y5J/Tdle/w== X-Google-Smtp-Source: ACHHUZ4clmY49xiyKRDx/JFGL5Nn1+FPQLmtPlJxv0UmteciiyDR3G7oPw+szDGZaNj9kvtAynEOUw== X-Received: by 2002:a05:6000:1950:b0:2d1:3eb9:c3c2 with SMTP id e16-20020a056000195000b002d13eb9c3c2mr1872627wry.54.1685116655645; Fri, 26 May 2023 08:57:35 -0700 (PDT) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id y15-20020a5d4acf000000b002cea9d931e6sm5465424wrs.78.2023.05.26.08.57.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 May 2023 08:57:35 -0700 (PDT) Message-ID: <58310306-2d70-eab4-4564-e77e1fb638a1@linaro.org> Date: Fri, 26 May 2023 16:57:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH V2 3/6] clk: qcom: clk-alpha-pll: Remove explicit CAL_L configuration for EVO PLL Content-Language: en-US From: Bryan O'Donoghue To: Jagadeesh Kona , Andy Gross , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Bjorn Andersson , Konrad Dybcio , Vladimir Zapolskiy , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Taniya Das , Satya Priya Kakitapalli , Imran Shaik , Ajit Pandey References: <20230525172142.9039-1-quic_jkona@quicinc.com> <20230525172142.9039-4-quic_jkona@quicinc.com> <240fa683-afb1-eb60-c24f-2b3f1d7f1339@linaro.org> In-Reply-To: <240fa683-afb1-eb60-c24f-2b3f1d7f1339@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 26/05/2023 16:54, Bryan O'Donoghue wrote: > On 25/05/2023 18:21, Jagadeesh Kona wrote: >> Fixes: 260e36606a03 ("clk: qcom: clk-alpha-pll: add Lucid EVO PLL >> configuration interfaces") > > Is this a "Fixes" without the previous patch to stuff the CAL_L_VAL and > VAL_L fields ? > > [PATCH V2 3/6] clk: qcom: clk-alpha-pll: Remove explicit CAL_L > configuration for EVO PLL > > Surely you need _both_ with this patch depending on the previous, per > your comment ? > > -    .l = 0x3e, > +    /* .l includes CAL_L_VAL, L_VAL fields */ > +    .l = 0x0044003e, > > --- > bod i.e. if you pick up this patch on its own you won't populate CAL_L_VAL... right ? It would make more sense to squash the two patches. --- bod