From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frank Rowand Subject: Re: [PATCH v2 1/5] ARM: memory: da8xx-ddrctl: new driver Date: Wed, 23 Nov 2016 10:13:01 -0800 Message-ID: <5835DC2D.5080606@gmail.com> References: <1477925138-23457-1-git-send-email-bgolaszewski@baylibre.com> <1477925138-23457-2-git-send-email-bgolaszewski@baylibre.com> <5833A2DA.40701@gmail.com> <800171a8-2e2c-2afb-f96d-800a17eaa17a@ti.com> <58348CB8.7050304@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sekhar Nori , Bartosz Golaszewski , Kevin Hilman , Michael Turquette , Rob Herring , Mark Rutland , Peter Ujfalusi , Russell King Cc: LKML , arm-soc , linux-drm , linux-devicetree , Jyri Sarha , Tomi Valkeinen , David Airlie , Laurent Pinchart , Sudeep Holla List-Id: devicetree@vger.kernel.org On 11/22/16 21:55, Sekhar Nori wrote: > On Tuesday 22 November 2016 11:51 PM, Frank Rowand wrote: >> Please note that the compatible property might contain several strings, not just >> a single string. > > So I guess the best thing to do is to use > of_property_read_string_index() and print the sting at index 0. > > Thanks, > Sekhar If you want to print just one compatible value, you could use that method. To give all of the information needed to understand the problem, the error message would need to include all of the strings contained in the compatible property and all of the .board values in the da8xx_ddrctl_board_confs[] array (currently only one entry, but coded to allow additional entries in the future). It is hard to justify an error message that complex. I would just print an error that no match was found. -Frank -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html