From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49527C83F15 for ; Sat, 26 Aug 2023 14:30:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229926AbjHZO3l (ORCPT ); Sat, 26 Aug 2023 10:29:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229988AbjHZO3e (ORCPT ); Sat, 26 Aug 2023 10:29:34 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA2172114 for ; Sat, 26 Aug 2023 07:29:30 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-51e28cac164so5854972a12.1 for ; Sat, 26 Aug 2023 07:29:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693060169; x=1693664969; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UoHwOTKGuupL476rFcW8I642v+ujJo8hTqxA/kEoIVc=; b=yFKGic01iRVPyL4PsX55rDX8WIy7c6znpSM5R8aLe7RpP2VBqVwYhnRKZRjfQfvBkJ SVd9InmtFtKNB8srwsbuTS66sEYRqZ2KtjwaHberQH1SvHeqYDYW/Q6TGLRanL3NdEpb 7xgifl+p3XTssLpg9RiB7OKGDuueJ1Sj1F0p2ydK+ELRu1bDqxbShFXVYfLJj+lK8uQr AdST1hMObcMpVt4oXJ6oZORjh560bj9PyOEnYSVbVCYSgA5iaSoglN7uekh1N5PIAu+m oCytOa8GlenkygJhgMH7P2sh+oUCPIeqhEhi3wRFZVx4BcSvzFvBV7QF6VG3YR9sfT4F YesQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693060169; x=1693664969; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UoHwOTKGuupL476rFcW8I642v+ujJo8hTqxA/kEoIVc=; b=lNl7d7ulm6cbCJyME3YtxfuLBlEJTCIj+C9sqkpTtV9oFG7iCDqhqtT6IFw2mKA2zV E14C1OGIAGhoO2bKXkIG7vgrk+lUoYRliPI4L7Ngnq7fHNgBQ226XKfAVvqZOgKlFSnC cTc08RLnBB/3Faywlh1rrp1weDJlmbnIB5171W7WVN0JwfeF5sDYKOLrHFH0cJMys3vj zK/0nOqRrAN83HPVhkWht+S1vu1aKdcZrLrNI2XZ7Vp5eozoo6LrGRnx5GRYDC1PkK/x mdbSE25WUuylQ2Ri44ybMNQaLY+WsxtTpsqJxZOb0Y4tUAdD46i1NAHJzn8R0RORw5UY 1Drg== X-Gm-Message-State: AOJu0Yy/8FTBpnkXokPQcOsnYOyKAXdPNuTbsPXgazEiBsD176wAS5vS TuezL/T9bvknuQaeQNTMWepNjw== X-Google-Smtp-Source: AGHT+IFFtNX5/1x+vPBsm+ndbnTzoPdNJBmv/tkhp3W8Qop5+BkHCGF+0A7SABanuHFJLm3T355oQw== X-Received: by 2002:a17:907:7804:b0:9a1:914e:491a with SMTP id la4-20020a170907780400b009a1914e491amr19325263ejc.3.1693060169184; Sat, 26 Aug 2023 07:29:29 -0700 (PDT) Received: from [192.168.0.22] ([77.252.47.198]) by smtp.gmail.com with ESMTPSA id l8-20020a1709067d4800b009a1c4d04989sm2227595ejp.217.2023.08.26.07.29.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 26 Aug 2023 07:29:28 -0700 (PDT) Message-ID: <5847be93-68c3-95fb-1d3e-9678804b9a70@linaro.org> Date: Sat, 26 Aug 2023 16:29:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 3/3] clk: qcom: Add SM6115 LPASSCC Content-Language: en-US To: Dmitry Baryshkov Cc: Konrad Dybcio , Bjorn Andersson , Andy Gross , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Srinivas Kandagatla , Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230825-topic-6115_lpasscc-v1-0-d4857be298e3@linaro.org> <20230825-topic-6115_lpasscc-v1-3-d4857be298e3@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 26/08/2023 16:09, Dmitry Baryshkov wrote: >>> +MODULE_DEVICE_TABLE(of, lpasscc_sm6115_match_table); >> >> Everything here is almost the same as sc8280xp one, so this should be >> added to sc8280xp. You cut some boilerplate and additional driver. > > We have been there. It quickly becomes a nightmare to maintain. > Consider dispcc-sm8250.c Because too much was added. I do not propose to keep all resets here. > > But I agree with you, this code looks too similar. If we expect more > similar lpasscc drivers, which provide no clocks, just several resets, > maybe we can create a common generic wrapper and make resets lists > corresponding driver data? This would also work. Best regards, Krzysztof