Re: [PATCH v14 3/4] arm64: dts: Add DTS for Marvell PXA1908 and samsung,coreprimevelte

["Duje Mihanović" <duje.mihanovic@skole.hr>]

On Thursday 16 January 2025 09:00:40 Central European Standard Time Krzysztof 
Kozlowski wrote:
> On Wed, Jan 15, 2025 at 09:35:56PM +0100, Duje Mihanović wrote:
> > Add DTS for Marvell PXA1908 SoC and Samsung Galaxy Core Prime Value
> > Edition LTE, a smartphone based on said SoC.
> > 
> > Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr>
> > ---
> > 
> >  arch/arm64/boot/dts/marvell/Makefile               |   3 +
> >  .../dts/marvell/pxa1908-samsung-coreprimevelte.dts | 336
> >  +++++++++++++++++++++ arch/arm64/boot/dts/marvell/pxa1908.dtsi           
|
> >  300 ++++++++++++++++++ 3 files changed, 639 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/marvell/Makefile
> > b/arch/arm64/boot/dts/marvell/Makefile index
> > ce751b5028e2628834340b5c50f8992092226eba..
39c5749e631db33aa8fb0386a951c0a70
> > 215bc02 100644 --- a/arch/arm64/boot/dts/marvell/Makefile
> > +++ b/arch/arm64/boot/dts/marvell/Makefile
> > @@ -32,3 +32,6 @@ dtb-$(CONFIG_ARCH_MVEBU) += cn9130-cf-base.dtb
> > 
> >  dtb-$(CONFIG_ARCH_MVEBU) += cn9130-cf-pro.dtb
> >  dtb-$(CONFIG_ARCH_MVEBU) += cn9131-cf-solidwan.dtb
> >  dtb-$(CONFIG_ARCH_MVEBU) += cn9132-clearfog.dtb
> > 
> > +
> > +# MMP SoC Family
> > +dtb-$(CONFIG_ARCH_MMP) += pxa1908-samsung-coreprimevelte.dtb
> 
> Hm, why separate ARCH if this is part of Marvell Makefile? One ARCH per
> vendor, so if you think this is different than MVEBU, then should be in
> a separate subdirectory of marvell.

I see, for v15 I'll put these in a mmp/ subdir.

> > +
> > +		ramoops@8100000 {
> > +			compatible = "ramoops";
> > +			reg = <0 0x8100000 0 0x40000>;
> > +			record-size = <0x8000>;
> > +			console-size = <0x20000>;
> > +			max-reason = <5>;
> > +		};
> > +	};
> > +
> > +
> 
> If there is going to be resend/new version:
> Just one blank line.

Will fix.

Regards,
-- 
Duje