From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C51F233D93; Mon, 13 Jan 2025 08:57:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=93.104.207.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736758682; cv=none; b=HQgjg72zls896JKOKnbld9LUkEZ1i2cnEFQuUK0IBqf5OuWksBzPh5+mHflPvyWugzaqeK4cI+I7AGkXd21CCogc/YpNIZ79tMQcPS9nvY8ZEKeHm5i98UWo6AdmxnDQpsG9Mo8RS7X9AqIlwJ1CQyeHaEEc53XeK32bELIRa8s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736758682; c=relaxed/simple; bh=UiyOfZqJ61a0v0LL+GBK+ZV49nwfQkFLSWH2uWHwMyI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ozoXSv2WIhCTWWK/N/QiXjSvU61lCF394ONXCcCksBqvt7plCAgi9QNwH5zxDDKrcas2kiwoTk6dueWQKTYzgoVzP+eZns7K6n57AKxhWJwtrL5tI+++zf2PA3dAUWr/AitiGP+kGxM9iZpLBJquV3QGrjVSDzPg4lmA8XQq1+E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ew.tq-group.com; spf=pass smtp.mailfrom=ew.tq-group.com; dkim=pass (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.b=nU5hetHk; dkim=fail (0-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b=LZdr2CBl reason="key not found in DNS"; arc=none smtp.client-ip=93.104.207.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.b="nU5hetHk"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b="LZdr2CBl" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1736758679; x=1768294679; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Tbo5YrOw2H/3ruPHWEWAeiN8rdU9wVeQI9EvOOOmwNo=; b=nU5hetHkGqEi7YMtEtdJgDOSHGto3gT2gFSswIiI0yhzt936Oo7yHY+J 5rtqI9iXRdO2xiIXYvln3zsN+K9faoce9L+whJyZRWbswQ9jNGhpnQS/S UNRlLWwL/ZeOVp1OP5E1C/Yo+FamkIOGan+Gob2+KjwYqTTuULfYOPMBR 2MtkSBGzy0Y4h2ql3YluDzIFuN4RWwhxq2Ffr+OV4i8OzhtBKHd1sK458 uBid+V6kAkJaZMyORfXLFvup6MdL/jBbalFpYnXxnQnxbWpN95jNPwe4q j09uohdLOuzdTzc8iAYmYR+b+h4M2bERzQA/BkHgd5oCLtQSp3/YHB1BT A==; X-CSE-ConnectionGUID: r6C6qALjSYCdz8g3LMnIHg== X-CSE-MsgGUID: iTW4TdugQM6ZWsGwJfs2uA== X-IronPort-AV: E=Sophos;i="6.12,310,1728943200"; d="scan'208";a="41010458" Received: from vmailcow01.tq-net.de ([10.150.86.48]) by mx1.tq-group.com with ESMTP; 13 Jan 2025 09:57:50 +0100 X-CheckPoint: {6784D58E-24-3C670366-E45AD810} X-MAIL-CPID: 454A88758688CF77A57FFEA4212AB19F_4 X-Control-Analysis: str=0001.0A682F17.6784D58E.00AF,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id C44D416B92E; Mon, 13 Jan 2025 09:57:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ew.tq-group.com; s=dkim; t=1736758666; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tbo5YrOw2H/3ruPHWEWAeiN8rdU9wVeQI9EvOOOmwNo=; b=LZdr2CBlejpULzspz8QRDz4idx1VWuBMwPS8FhWiLZYZQeGear7/p4Mz4kf1ag+6tf/F97 hXfLVT+M7qMV5xVSOLgjqAJ3/bECAt3QA3hx9OKCVPJ3w2+6UNaowWQtelH5QWvNvILz7V DPvG1jh3YxmmH1ow2k606eX5Oc9uGocMu1b49jNzVNNOf4TYSMX6CO5xeDqXmK5TBcHoMp g0FPyBVAWTN8gv5PROTOeid4bIGxw3CoKlINPY7D77uIA/jpzQXomOgrwrUWnXQGZ+FBCo B7CNXGFHBQ0NWbbLwUhh1yykm7aaxUNuJK8p3ZWlx0/2PHEkw5yebRvfHAlm5w== From: Alexander Stein To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Guido =?ISO-8859-1?Q?G=FAnther?= , Robert Chiras , "open list:DRM DRIVERS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Cc: imx@lists.linux.dev, Frank Li Subject: Re: [PATCH v2 1/1] dt-bindings: display: nwl-dsi: Allow 'data-lanes' property for port@1 Date: Mon, 13 Jan 2025 09:57:43 +0100 Message-ID: <5856132.DvuYhMxLoT@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20250110161733.2515332-1-Frank.Li@nxp.com> References: <20250110161733.2515332-1-Frank.Li@nxp.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-Last-TLS-Session-Version: TLSv1.3 Hi Frank, Am Freitag, 10. Januar 2025, 17:17:32 CET schrieb Frank Li: > This controller support scalable data lanes from 1 to 4. Add the > 'data-lanes' property to configure the number of MIPI display panel lanes > selected for boards. >=20 > Change $ref of port@1 from 'port' to 'port-base' and add 'endpoint' > property referencing video-interfaces.yaml. Allow 'data-lanes' values > 1, 2, 3, and 4 for port@1. >=20 > Fix below CHECK_DTB warnings: > arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx-lvds-tm070jvhg33.dtb: > dsi@30a00000: ports:port@1:endpoint: Unevaluated properties are not allo= wed ('data-lanes' was unexpected) >=20 > Signed-off-by: Frank Li I've had a similar patch WIP. Looks good to me. For the record I based my local change according to commit 54df4868fb728 ("dt-bindings: samsung,mipi-dsim: Use port-base reference") Reviewed-by: Alexander Stein > --- > Change from v1 to v2 > - Add the reason why need 'data-lanes' property in commit message. > --- > .../bindings/display/bridge/nwl-dsi.yaml | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) >=20 > diff --git a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yam= l b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > index 350fb8f400f02..5952e6448ed47 100644 > --- a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > @@ -111,11 +111,27 @@ properties: > unevaluatedProperties: false > =20 > port@1: > - $ref: /schemas/graph.yaml#/properties/port > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > description: > DSI output port node to the panel or the next bridge > in the chain > =20 > + properties: > + endpoint: > + $ref: /schemas/media/video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + data-lanes: > + description: array of physical DSI data lane indexes. > + minItems: 1 > + items: > + - const: 1 > + - const: 2 > + - const: 3 > + - const: 4 > + > required: > - port@0 > - port@1 >=20 =2D-=20 TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/