From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B245EB64DD for ; Mon, 14 Aug 2023 10:29:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231730AbjHNK3K (ORCPT ); Mon, 14 Aug 2023 06:29:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233389AbjHNK2m (ORCPT ); Mon, 14 Aug 2023 06:28:42 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2EA5310F; Mon, 14 Aug 2023 03:28:41 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-99bcc0adab4so545664366b.2; Mon, 14 Aug 2023 03:28:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692008919; x=1692613719; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FD+dZC6ILC0zBFJ75+s8TCoV5USuF9fK+77Nw8Aje0w=; b=KWdqfZ62xxlrvlMKf2qpi7YAx2rbvFG/rCy6KhPTmVZphJsw4o2qpe1XzHr2ulW9ig dJocY4tSGDsDN8BwwO1YOQawk66HkEn80/HhW/9hlO6rOow7AfWW5ejsrLhaPH16P9kI wf7SMRXGkVgrdLwcNcHzBNB7TdGjz+ahTGskjF0PqMlDTx7kItkd0xOLzJyi1Kjn74TF IZ3bJUC1Dq/EpL3zzYFza3Qn5PV29G9w5keslAkAtcSJCAw/AkZGh8bevjk/lcV5+KDs IWxarqq5J8fQu8ZYSNrror9GhedNj152iiEaVa+GX1N6T82hz+c11S0hNGGo6iqScOVF mMNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692008919; x=1692613719; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FD+dZC6ILC0zBFJ75+s8TCoV5USuF9fK+77Nw8Aje0w=; b=b6Dd6eJE+kiIglqZ1FRAm8CJjQRA0DiUaFBuOiMKaZAAMusXsZ+7klBcJxEK1bRtjH +PEfGSpLLP2hlSV5IMgmQ3p/FQl+gfQr6chuhOhuBf7juqrsmEoY3sxCMtFRivaZohK6 CWxNDi6q0U0c9mJ/0+g65tBlhCbZkQzxUopOz6y3L4vB+34dlyRbuCqxW0R701xtM09h FEzmXWeOb68gBs4x4iIMxoWDdqnTez7POngN8sZtmcDh3aID9KxOhdDXRo8SjQCY8DVq VV0bvlAFGXtHJ7AvUoW68G9XUn7Nmxh1UZAm3JHiIvz1+K95zHEY33cWgPjOF2vgAv/K PVTw== X-Gm-Message-State: AOJu0Yyg2CH/rKvMY6b/Zl8N/Q4QumwTu+xqlBtQ+89mO4o6NU2Qegtn IxIk9z/9cCsToWAE5Kd7He2BPJmJgzOIng== X-Google-Smtp-Source: AGHT+IGLLfnjCAgn+nWhTlM7HypGsXCTlLNpZzQ1NwgZFCaXqFMayOU8fjnnL5sKdfMF6InnHfyjDw== X-Received: by 2002:a17:906:1da1:b0:99b:c2d4:ddd8 with SMTP id u1-20020a1709061da100b0099bc2d4ddd8mr6745353ejh.31.1692008919572; Mon, 14 Aug 2023 03:28:39 -0700 (PDT) Received: from jernej-laptop.localnet (89-212-118-115.static.t-2.net. [89.212.118.115]) by smtp.gmail.com with ESMTPSA id w14-20020a1709060a0e00b0099b5a71b0bfsm5490638ejf.94.2023.08.14.03.28.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Aug 2023 03:28:39 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Krzysztof Kozlowski , Martin Botka Cc: Srinivas Kandagatla , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Samuel Holland , Maxime Ripard , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Andre Przywara , Alan Ma , Marijn Suijten , AngeloGioacchino Del Regno , Konrad Dybcio Subject: Re: [PATCH v2 1/2] dt-bindings: nvmem: SID: Add binding for H616 SID controller Date: Mon, 14 Aug 2023 12:28:36 +0200 Message-ID: <5856748.MhkbZ0Pkbq@jernej-laptop> In-Reply-To: References: <20230814-sid-h616-v2-0-0267749b4471@somainline.org> <830e5e34-f6de-3233-4a12-06c8390169d1@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Dne ponedeljek, 14. avgust 2023 ob 10:21:49 CEST je Martin Botka napisal(a): > On Mon, Aug 14 2023 at 10:08:38 AM +02:00:00, Krzysztof Kozlowski > > wrote: > > On 14/08/2023 08:38, Martin Botka wrote: > >> Add binding for the SID controller found in H616 SoC > >> > >> Signed-off-by: Martin Botka > >> --- > >> > >> Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml > >> > >> | 1 + > >> | > >> 1 file changed, 1 insertion(+) > >> > >> diff --git > >> > >> a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml > >> b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml > >> > >> index 296001e7f498..2ec0a1b8f803 100644 > >> --- > >> > >> a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml > >> > >> +++ > >> > >> b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml > >> > >> @@ -27,6 +27,7 @@ properties: > >> - const: allwinner,sun50i-a64-sid > >> > >> - const: allwinner,sun50i-h5-sid > >> - const: allwinner,sun50i-h6-sid > >> > >> + - const: allwinner,sun50i-h616-sid > > > > It does not look like you tested the DTS against bindings. Please run > > `make dtbs_check` (see > > Documentation/devicetree/bindings/writing-schema.rst or > > https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sour > > ces-with-the-devicetree-schema/ for instructions). > > > > Best regards, > > Krzysztof > > Yea completely forgot. Sorry for that. > > Will send v3 tomorrow with proper binding patch using items with enums Don't. You have cca. 1 month time now, since you missed at least window for DT changes for 6.6. Best regards, Jernej