From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH v7 05/24] clocksource: Add a new timer-ingenic driver Date: Mon, 24 Sep 2018 07:35:05 +0200 Message-ID: <58645f14-aec2-4f66-3a39-34beeabdb035@linaro.org> References: <5ba8750a.1c69fb81.501e8.d0f0SMTPIN_ADDED_MISSING@mx.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <5ba8750a.1c69fb81.501e8.d0f0SMTPIN_ADDED_MISSING@mx.google.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Paul Cercueil Cc: Mathieu Malaterre , Thomas Gleixner , Rob Herring , linux-doc@vger.kernel.org, linux-watchdog@vger.kernel.org, Jonathan Corbet , od@zcrc.me, linux-mips@linux-mips.org, Paul Burton , Mark Rutland , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Ralf Baechle , Thierry Reding , linux-pwm@vger.kernel.org List-Id: devicetree@vger.kernel.org On 24/09/2018 07:24, Paul Cercueil wrote: > Hi Daniel, > > Le 24 sept. 2018 05:12, Daniel Lezcano a écrit : >> >> On 21/08/2018 19:16, Paul Cercueil wrote: >>> This driver handles the TCU (Timer Counter Unit) present on the Ingenic >>> JZ47xx SoCs, and provides the kernel with a system timer, and optionally >>> with a clocksource and a sched_clock. >>> >>> It also provides clocks and interrupt handling to client drivers. >> >> Can you provide a much more complete description of the timer in order >> to make my life easier for the review of this patch? > > See patch [03/24], it adds a doc file that describes the hardware. Thanks, I went through but it is incomplete to understand what the timer do. I will reverse-engineer the code but it would help if you can give the gross approach. Why multiple channels ? mutexes and completion ? -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog