From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0994C1C6FF0; Mon, 10 Feb 2025 10:05:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.193 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739181903; cv=none; b=G5ujmqKIbo0Mz5Ubz2Q5i03QppcSsNDURxRNp1N2BYAhRmdpY4f0Zr9qGHyFnkxbuiC1PAfTFuWtgWLjIxkZgfPax97ekV1D15UGmwbSLhjTnhdMqbqe0OtpRUIGJrbbjsI9n3WIrBQZ36Zg/POp18IHfrARQwsQCYqLqba+CJk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739181903; c=relaxed/simple; bh=MsStyGB/s8toCJdgsIBul5jFwlgpyY05XQEDDYZX7IU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=jbRSU3uUd1TfO3FM5EYwgsWvJhbrnmhnW14oc+Qr7EKwRq3kp0oY6ElH31gD7P2E/c86YkvXb7KN23BpWVuIfPYWgeSKLS6DpcfjUJW6QLziQXbkTpXuRPlNyIuG7h/QBxo0crLjhWMwGhZii/K46X/ouArM49EjfeQTxy+9WpA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=djT9CY5J; arc=none smtp.client-ip=217.70.183.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="djT9CY5J" Received: by mail.gandi.net (Postfix) with ESMTPSA id 81F17442A5; Mon, 10 Feb 2025 10:04:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1739181892; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AJb8bkauCDhTBOcu8X/HjYqi4iRH5JJNhU2FKZwS+C4=; b=djT9CY5JnUvFf4Rd2gWUzxSrpbB9MCYbNvoDPDv3FKOuTwvv6X4g3AhUpMHjJGjPo+jlpT AFI4rCoyH7VDsFmSSLDgWxOvgrTa2MXWWNcxzHtFjeExYlOp6L2k+rBjgelQmnk/g0zQtD y0ICAmmzdAoNV28D6kuxTkA25Xcy9ZH/UsaVbVUDFwQO9cIgrcxLYnogyAsCzKhoJEXSLU vQZB2QqhFD/u3H3VrVOvEFisMee4/6do/wEPOBW8Tgc1aWrDkzNSBMedbrFWSSSLvzM9Sc 5cKP5ReoDV39Zvz/uAhIBDkwUs8i3D7b9cslvpUazE6Cq1A+/fEweUAhsoDVJw== From: Romain Gantois To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen Wang , Inochi Amaoto , Maxime Coquelin , Alexandre Torgue , Richard Cochran , Paul Walmsley , Palmer Dabbelt , Albert Ou , Emil Renner Berthing , Jisheng Zhang , "Jan Petrous (OSS)" , =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= , Simon Horman , Furong Xu <0x1207@gmail.com>, Serge Semin , Lothar Rubusch , Suraj Jaiswal , Joe Hattori , Bartosz Golaszewski , Giuseppe Cavallaro , Jose Abreu , Inochi Amaoto Cc: Inochi Amaoto , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, Yixun Lan , Longbin Li Subject: Re: [PATCH net-next v4 2/3] net: stmmac: platform: Add snps,dwmac-5.30a IP compatible string Date: Mon, 10 Feb 2025 11:04:40 +0100 Message-ID: <5868742.DvuYhMxLoT@fw-rgant> In-Reply-To: <20250209013054.816580-3-inochiama@gmail.com> References: <20250209013054.816580-1-inochiama@gmail.com> <20250209013054.816580-3-inochiama@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart6136790.lOV4Wx5bFT"; micalg="pgp-sha256"; protocol="application/pgp-signature" X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdefjeejjecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvvefufffkjghfgggtsehgtderredttdejnecuhfhrohhmpeftohhmrghinhcuifgrnhhtohhishcuoehrohhmrghinhdrghgrnhhtohhishessghoohhtlhhinhdrtghomheqnecuggftrfgrthhtvghrnhepieekkeffvdeugfekjeegfefhvdetuefhtdelieduheeileduledvteelgefgffffnecukfhppeeltddrkeelrdduieefrdduvdejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledtrdekledrudeifedruddvjedphhgvlhhopehffidqrhhgrghnthdrlhhotggrlhhnvghtpdhmrghilhhfrhhomheprhhomhgrihhnrdhgrghnthhoihhssegsohhothhlihhnrdgtohhmpdhnsggprhgtphhtthhopeefkedprhgtphhtthhopegrnhgurhgvfidonhgvthguvghvsehluhhnnhdrtghhpdhrtghpthhtohepuggrvhgvmhesuggrvhgvmhhlohhfthdrnhgvthdprhgtphhtthhopegvughumhgriigvthesghhoohhglhgvrdgtohhmpdhrtghpthhtohepkhhusggrsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehprggsvghnihesrhgvughhrghtrdgtohhmpdhrtghpthhtoheprhhos ghhsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehkrhiikhdoughtsehkvghrnhgvlhdrohhrghdprhgtphhtthhopegtohhnohhrodgutheskhgvrhhnvghlrdhorhhg X-GND-Sasl: romain.gantois@bootlin.com --nextPart6136790.lOV4Wx5bFT Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8"; protected-headers="v1" From: Romain Gantois Date: Mon, 10 Feb 2025 11:04:40 +0100 Message-ID: <5868742.DvuYhMxLoT@fw-rgant> In-Reply-To: <20250209013054.816580-3-inochiama@gmail.com> MIME-Version: 1.0 On dimanche 9 f=C3=A9vrier 2025 02:30:51 heure normale d=E2=80=99Europe cen= trale Inochi=20 Amaoto wrote: > Add "snps,dwmac-5.30a" compatible string for 5.30a version that can avoid > to define some platform data in the glue layer. >=20 > Signed-off-by: Inochi Amaoto > --- > .../ethernet/stmicro/stmmac/stmmac_platform.c | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c index > d0e61aa1a495..8dc3bd6946c6 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > @@ -405,6 +405,17 @@ static int stmmac_of_get_mac_mode(struct device_node > *np) return -ENODEV; > } >=20 > +/* Compatible string array for all gmac4 devices */ > +static const char * const stmmac_gmac4_compats[] =3D { > + "snps,dwmac-4.00", > + "snps,dwmac-4.10a", > + "snps,dwmac-4.20a", > + "snps,dwmac-5.10a", > + "snps,dwmac-5.20", > + "snps,dwmac-5.30a", > + NULL > +}; > + > /** > * stmmac_probe_config_dt - parse device-tree driver parameters > * @pdev: platform_device structure > @@ -538,11 +549,7 @@ stmmac_probe_config_dt(struct platform_device *pdev,= u8 > *mac) plat->pmt =3D 1; > } >=20 > - if (of_device_is_compatible(np, "snps,dwmac-4.00") || > - of_device_is_compatible(np, "snps,dwmac-4.10a") || > - of_device_is_compatible(np, "snps,dwmac-4.20a") || > - of_device_is_compatible(np, "snps,dwmac-5.10a") || > - of_device_is_compatible(np, "snps,dwmac-5.20")) { > + if (of_device_compatible_match(np, stmmac_gmac4_compats)) { > plat->has_gmac4 =3D 1; > plat->has_gmac =3D 0; > plat->pmt =3D 1; LGTM Reviewed-by: Romain Gantois --nextPart6136790.lOV4Wx5bFT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEYFZBShRwOvLlRRy+3R9U/FLj284FAmepzzgACgkQ3R9U/FLj 286J5g//fmDyVJafzX14tHwfj8aI+uwgNu7ZJxduC9DnxnYWy+EN+dby2S6/rlPN T4ypshgRrmYqPoji5FJKurYu3LHwUE/V8N2z06jexZaWXA8/VW+aNUkHoIbyHHko fYFD4Op0fKrWBGBHR+Hj8qJv2QbWFBc8vo4Swzk3PjbzLTx36g3gFWb/CUkP569I 12TrG1wPA0ZBtugewKlLSdXOFVtDqsh0mTfCpQ8dsRjTc4TrVrcFDaxIW1aENksw 0SIncY9LUMPnCW+IHHB7E8Ln6y84/ipUGsySMvtUOg/cnobji2ehcScRVh+QpuZQ L/P1dWf83kE5M1Kll9HPhs0R1qtrK2bWAaBamcDl79AW6c+4MPdBPxk9gaQmMuov /tiHVI0LagpoFV+Y/hXy7mMMRmqLAhlwwkmNiJuzYPnBJOReYcJ5kJ4QvCr+n0I9 YQ+zLGBWxvi0aQk8p+qh8a6VZ+8I1aGmjGDluy9M+7f1wl1Rj3RMOOL8G86M4ZxD BnbNszU+FrI1fZObie8NsvvQwunu/bJcR1Mhn9RcyVcc/b6bIpAekcjcctz07P7B KWTz8PjEv0dHTX7k40Lr9GhZjKIQeVR3YMCNjzqvANzcCeEcSnnIY/r+U/hpK5jp ShGT0E6pno6LqL/YVkx+G1N/T736ljcC/BCLeQvGusrPc6Md3Aw= =KCpu -----END PGP SIGNATURE----- --nextPart6136790.lOV4Wx5bFT--