* [PATCH 1/3] ARM64: dts: exynos5433: add DECON_TV node [not found] <CGME20170105152604eucas1p25340c974fa7f375905c958e2bff6d96f@eucas1p2.samsung.com> @ 2017-01-05 15:25 ` Andrzej Hajda [not found] ` <CGME20170105152604eucas1p2092deeb660630f09b857cd1f8d1e4dea@eucas1p2.samsung.com> ` (4 more replies) 0 siblings, 5 replies; 10+ messages in thread From: Andrzej Hajda @ 2017-01-05 15:25 UTC (permalink / raw) To: linux-samsung-soc, Krzysztof Kozlowski Cc: Andrzej Hajda, Bartlomiej Zolnierkiewicz, Marek Szyprowski, Inki Dae, Rob Herring, Mark Rutland, Javier Martinez Canillas, devicetree DECON_TV is 2nd display controller on Exynos5433, used in HDMI path or 2nd DSI path. Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433.dtsi | 44 ++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi index 8cbfd1d..b47951b 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi @@ -821,6 +821,28 @@ }; }; + decon_tv: decon@13880000 { + compatible = "samsung,exynos5433-decon-tv"; + reg = <0x13880000 0x20B8>; + clocks = <&cmu_disp CLK_PCLK_DECON_TV>, + <&cmu_disp CLK_ACLK_DECON_TV>, + <&cmu_disp CLK_ACLK_SMMU_TV0X>, + <&cmu_disp CLK_ACLK_XIU_TV0X>, + <&cmu_disp CLK_PCLK_SMMU_TV0X>, + <&cmu_disp CLK_SCLK_DECON_TV_VCLK>, + <&cmu_disp CLK_SCLK_DECON_TV_ECLK>; + clock-names = "pclk", "aclk_decon", "aclk_smmu_decon0x", + "aclk_xiu_decon0x", "pclk_smmu_decon0x", + "sclk_decon_vclk", "sclk_decon_eclk"; + samsung,disp-sysreg = <&syscon_disp>; + interrupt-names = "fifo", "vsync", "lcd_sys"; + interrupts = <0 210 0>, <0 211 0>, <0 212 0>; + power-domains = <&pd_disp>; + status = "disabled"; + iommus = <&sysmmu_tv0x>, <&sysmmu_tv1x>; + iommu-names = "m0", "m1"; + }; + syscon_disp: syscon@13b80000 { compatible = "syscon"; reg = <0x13b80000 0x1010>; @@ -926,6 +948,28 @@ power-domains = <&pd_disp>; }; + sysmmu_tv0x: sysmmu@0x13a20000 { + compatible = "samsung,exynos-sysmmu"; + reg = <0x13a20000 0x1000>; + interrupts = <0 214 0>; + clock-names = "pclk", "aclk"; + clocks = <&cmu_disp CLK_PCLK_SMMU_TV0X>, + <&cmu_disp CLK_ACLK_SMMU_TV0X>; + #iommu-cells = <0>; + power-domains = <&pd_disp>; + }; + + sysmmu_tv1x: sysmmu@0x13a30000 { + compatible = "samsung,exynos-sysmmu"; + reg = <0x13a30000 0x1000>; + interrupts = <0 216 0>; + clock-names = "pclk", "aclk"; + clocks = <&cmu_disp CLK_PCLK_SMMU_TV1X>, + <&cmu_disp CLK_ACLK_SMMU_TV1X>; + #iommu-cells = <0>; + power-domains = <&pd_disp>; + }; + sysmmu_gscl0: sysmmu@0x13C80000 { compatible = "samsung,exynos-sysmmu"; reg = <0x13C80000 0x1000>; -- 2.7.4 ^ permalink raw reply related [flat|nested] 10+ messages in thread
[parent not found: <CGME20170105152604eucas1p2092deeb660630f09b857cd1f8d1e4dea@eucas1p2.samsung.com>]
[parent not found: <1483629943-31183-1-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>]
* [PATCH 2/3] ARM64: dts: exynos5433: add HDMI node [not found] ` <1483629943-31183-1-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> @ 2017-01-05 15:25 ` Andrzej Hajda 2017-01-05 16:21 ` Javier Martinez Canillas [not found] ` <1483629943-31183-2-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> 0 siblings, 2 replies; 10+ messages in thread From: Andrzej Hajda @ 2017-01-05 15:25 UTC (permalink / raw) To: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA, Krzysztof Kozlowski Cc: Andrzej Hajda, Bartlomiej Zolnierkiewicz, Marek Szyprowski, Inki Dae, Rob Herring, Mark Rutland, Javier Martinez Canillas, devicetree-u79uwXL29TY76Z2rM5mHXA HDMI converts RGB/I80 signal from DECON_TV to HDMI/TMDS video stream. Signed-off-by: Andrzej Hajda <a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> --- arch/arm64/boot/dts/exynos/exynos5433.dtsi | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi index b47951b..cf45446 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi @@ -843,6 +843,36 @@ iommu-names = "m0", "m1"; }; + hdmi: hdmi@13970000 { + compatible = "samsung,exynos5433-hdmi"; + reg = <0x13970000 0x70000>; + interrupts = <0 208 0>; + clocks = <&cmu_disp CLK_PCLK_HDMI>, + <&cmu_disp CLK_PCLK_HDMIPHY>, + <&cmu_disp CLK_PHYCLK_HDMIPHY_TMDS_CLKO>, + <&cmu_disp CLK_PHYCLK_HDMI_PIXEL>, + <&cmu_disp CLK_PHYCLK_HDMIPHY_TMDS_CLKO_PHY>, + <&cmu_disp CLK_MOUT_PHYCLK_HDMIPHY_TMDS_CLKO_USER>, + <&cmu_disp CLK_PHYCLK_HDMIPHY_PIXEL_CLKO_PHY>, + <&cmu_disp CLK_MOUT_PHYCLK_HDMIPHY_PIXEL_CLKO_USER>, + <&xxti>, <&cmu_disp CLK_SCLK_HDMI_SPDIF>; + clock-names = "hdmi_pclk", "hdmi_i_pclk", + "i_tmds_clk", "i_pixel_clk", + "tmds_clko", "tmds_clko_user", + "pixel_clko", "pixel_clko_user", + "oscclk", "i_spdif_clk"; + phy = <&hdmiphy>; + ddc = <&hsi2c_11>; + samsung,syscon-phandle = <&pmu_system_controller>; + samsung,sysreg-phandle = <&syscon_disp>; + power-domains = <&pd_disp>; + status = "disabled"; + }; + + hdmiphy: hdmiphy@13af0000 { + reg = <0x13af0000 0x80>; + }; + syscon_disp: syscon@13b80000 { compatible = "syscon"; reg = <0x13b80000 0x1010>; -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 2/3] ARM64: dts: exynos5433: add HDMI node 2017-01-05 15:25 ` [PATCH 2/3] ARM64: dts: exynos5433: add HDMI node Andrzej Hajda @ 2017-01-05 16:21 ` Javier Martinez Canillas [not found] ` <1483629943-31183-2-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> 1 sibling, 0 replies; 10+ messages in thread From: Javier Martinez Canillas @ 2017-01-05 16:21 UTC (permalink / raw) To: Andrzej Hajda, linux-samsung-soc, Krzysztof Kozlowski Cc: Bartlomiej Zolnierkiewicz, Marek Szyprowski, Inki Dae, Rob Herring, Mark Rutland, devicetree Hello Andrzej, On 01/05/2017 12:25 PM, Andrzej Hajda wrote: > HDMI converts RGB/I80 signal from DECON_TV to HDMI/TMDS video stream. > > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > --- Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America ^ permalink raw reply [flat|nested] 10+ messages in thread
[parent not found: <1483629943-31183-2-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>]
* Re: [PATCH 2/3] ARM64: dts: exynos5433: add HDMI node [not found] ` <1483629943-31183-2-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> @ 2017-01-06 3:43 ` Chanwoo Choi 0 siblings, 0 replies; 10+ messages in thread From: Chanwoo Choi @ 2017-01-06 3:43 UTC (permalink / raw) To: Andrzej Hajda, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA, Krzysztof Kozlowski Cc: Bartlomiej Zolnierkiewicz, Marek Szyprowski, Inki Dae, Rob Herring, Mark Rutland, Javier Martinez Canillas, devicetree-u79uwXL29TY76Z2rM5mHXA Hi Andrzej, On 2017년 01월 06일 00:25, Andrzej Hajda wrote: > HDMI converts RGB/I80 signal from DECON_TV to HDMI/TMDS video stream. > > Signed-off-by: Andrzej Hajda <a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> > --- > arch/arm64/boot/dts/exynos/exynos5433.dtsi | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi > index b47951b..cf45446 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi > @@ -843,6 +843,36 @@ > iommu-names = "m0", "m1"; > }; > > + hdmi: hdmi@13970000 { > + compatible = "samsung,exynos5433-hdmi"; > + reg = <0x13970000 0x70000>; > + interrupts = <0 208 0>; Need touse the interrupt definitions. > + clocks = <&cmu_disp CLK_PCLK_HDMI>, > + <&cmu_disp CLK_PCLK_HDMIPHY>, > + <&cmu_disp CLK_PHYCLK_HDMIPHY_TMDS_CLKO>, > + <&cmu_disp CLK_PHYCLK_HDMI_PIXEL>, > + <&cmu_disp CLK_PHYCLK_HDMIPHY_TMDS_CLKO_PHY>, > + <&cmu_disp CLK_MOUT_PHYCLK_HDMIPHY_TMDS_CLKO_USER>, > + <&cmu_disp CLK_PHYCLK_HDMIPHY_PIXEL_CLKO_PHY>, > + <&cmu_disp CLK_MOUT_PHYCLK_HDMIPHY_PIXEL_CLKO_USER>, > + <&xxti>, <&cmu_disp CLK_SCLK_HDMI_SPDIF>; > + clock-names = "hdmi_pclk", "hdmi_i_pclk", > + "i_tmds_clk", "i_pixel_clk", > + "tmds_clko", "tmds_clko_user", > + "pixel_clko", "pixel_clko_user", > + "oscclk", "i_spdif_clk"; > + phy = <&hdmiphy>; > + ddc = <&hsi2c_11>; > + samsung,syscon-phandle = <&pmu_system_controller>; > + samsung,sysreg-phandle = <&syscon_disp>; > + power-domains = <&pd_disp>; The Exynos5433 has not yet supported the power domain. You need to remove this property. > + status = "disabled"; > + }; > + > + hdmiphy: hdmiphy@13af0000 { > + reg = <0x13af0000 0x80>; > + }; > + > syscon_disp: syscon@13b80000 { > compatible = "syscon"; > reg = <0x13b80000 0x1010>; > -- Best Regards, Chanwoo Choi S/W Center, Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 10+ messages in thread
[parent not found: <CGME20170105152604eucas1p12c1a964b5299a5a41305b00b80a09f36@eucas1p1.samsung.com>]
* [PATCH 3/3] ARM64: dts: exynos5433-tm2: enable HDMI/TV path [not found] ` <CGME20170105152604eucas1p12c1a964b5299a5a41305b00b80a09f36@eucas1p1.samsung.com> @ 2017-01-05 15:25 ` Andrzej Hajda [not found] ` <1483629943-31183-3-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> 0 siblings, 1 reply; 10+ messages in thread From: Andrzej Hajda @ 2017-01-05 15:25 UTC (permalink / raw) To: linux-samsung-soc, Krzysztof Kozlowski Cc: Andrzej Hajda, Bartlomiej Zolnierkiewicz, Marek Szyprowski, Inki Dae, Rob Herring, Mark Rutland, Javier Martinez Canillas, devicetree TV path consist of following interconnected components: - DECON_TV - display controller, - HDMI - video signal converter RGB / HDMI, - MHL - video signal converter HDMI / MHL, - DDC - i2c slave device for EDID reading (on hsi2c_11 bus). The same path/configuration is used by TM2E board and is automatically applied thanks to dts file inclusion. Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 71 +++++++++++++++++++++++++++ 1 file changed, 71 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts index 060adbf..0a87670 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts @@ -236,6 +236,22 @@ }; }; +&decon_tv { + status = "okay"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + tv_to_hdmi: endpoint { + remote-endpoint = <&hdmi_to_tv>; + }; + }; + }; +}; + &dsi { status = "okay"; vddcore-supply = <&ldo6_reg>; @@ -294,6 +310,33 @@ }; }; +&hdmi { + hpd-gpio = <&gpa3 0 0>; + status = "okay"; + vdd-supply = <&ldo6_reg>; + vdd_osc-supply = <&ldo7_reg>; + vdd_pll-supply = <&ldo6_reg>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + hdmi_to_tv: endpoint { + remote-endpoint = <&tv_to_hdmi>; + }; + }; + + port@1 { + reg = <1>; + hdmi_to_mhl: endpoint { + remote-endpoint = <&mhl_to_hdmi>; + }; + }; + }; +}; + &hsi2c_0 { status = "okay"; clock-frequency = <2500000>; @@ -708,6 +751,30 @@ }; }; +&hsi2c_7 { + status = "okay"; + + sii8620@39 { + reg = <0x39>; + compatible = "sil,sii8620"; + cvcc10-supply = <&ldo36_reg>; + iovcc18-supply = <&ldo34_reg>; + interrupt-parent = <&gpf0>; + interrupts = <2 0>; + reset-gpios = <&gpv7 0 GPIO_ACTIVE_LOW>; + clocks = <&pmu_system_controller 0>; + clock-names = "xtal"; + assigned-clocks = <&pmu_system_controller 0>; + assigned-clock-parents = <&xxti>; + + port { + mhl_to_hdmi: endpoint { + remote-endpoint = <&hdmi_to_mhl>; + }; + }; + }; +}; + &hsi2c_8 { status = "okay"; @@ -751,6 +818,10 @@ }; }; +&hsi2c_11 { + status = "okay"; +}; + &i2s0 { status = "okay"; }; -- 2.7.4 ^ permalink raw reply related [flat|nested] 10+ messages in thread
[parent not found: <1483629943-31183-3-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>]
* Re: [PATCH 3/3] ARM64: dts: exynos5433-tm2: enable HDMI/TV path [not found] ` <1483629943-31183-3-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> @ 2017-01-05 16:33 ` Javier Martinez Canillas 2017-01-06 4:51 ` Andi Shyti 1 sibling, 0 replies; 10+ messages in thread From: Javier Martinez Canillas @ 2017-01-05 16:33 UTC (permalink / raw) To: Andrzej Hajda, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA, Krzysztof Kozlowski Cc: Bartlomiej Zolnierkiewicz, Marek Szyprowski, Inki Dae, Rob Herring, Mark Rutland, devicetree-u79uwXL29TY76Z2rM5mHXA Hello Andrzej, On 01/05/2017 12:25 PM, Andrzej Hajda wrote: > TV path consist of following interconnected components: > - DECON_TV - display controller, > - HDMI - video signal converter RGB / HDMI, > - MHL - video signal converter HDMI / MHL, > - DDC - i2c slave device for EDID reading (on hsi2c_11 bus). > > The same path/configuration is used by TM2E board and is > automatically applied thanks to dts file inclusion. > > Signed-off-by: Andrzej Hajda <a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> > --- > arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 71 +++++++++++++++++++++++++++ > 1 file changed, 71 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts [snip] > > +&hdmi { > + hpd-gpio = <&gpa3 0 0>; Same comment than interrupts, please use the GPIO_ACTIVE_HIGH here. The rest looks good to me. Reviewed-by: Javier Martinez Canillas <javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 3/3] ARM64: dts: exynos5433-tm2: enable HDMI/TV path [not found] ` <1483629943-31183-3-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> 2017-01-05 16:33 ` Javier Martinez Canillas @ 2017-01-06 4:51 ` Andi Shyti 1 sibling, 0 replies; 10+ messages in thread From: Andi Shyti @ 2017-01-06 4:51 UTC (permalink / raw) To: Andrzej Hajda Cc: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz, Marek Szyprowski, Inki Dae, Rob Herring, Mark Rutland, Javier Martinez Canillas, devicetree-u79uwXL29TY76Z2rM5mHXA Hi Andrzej, On Thu, Jan 05, 2017 at 04:25:43PM +0100, Andrzej Hajda wrote: > TV path consist of following interconnected components: > - DECON_TV - display controller, > - HDMI - video signal converter RGB / HDMI, > - MHL - video signal converter HDMI / MHL, > - DDC - i2c slave device for EDID reading (on hsi2c_11 bus). > > The same path/configuration is used by TM2E board and is > automatically applied thanks to dts file inclusion. > > Signed-off-by: Andrzej Hajda <a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> > --- > arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 71 +++++++++++++++++++++++++++ > 1 file changed, 71 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > index 060adbf..0a87670 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts same here, this patch will conflict with the previous patches on the exynos5433-tm2.dts Could you please rebase them on top of this one: https://lkml.org/lkml/2017/1/5/887 which is rebased on top of: https://lkml.org/lkml/2016/12/29/319 Thanks, Andi -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/3] ARM64: dts: exynos5433: add DECON_TV node 2017-01-05 15:25 ` [PATCH 1/3] ARM64: dts: exynos5433: add DECON_TV node Andrzej Hajda [not found] ` <CGME20170105152604eucas1p2092deeb660630f09b857cd1f8d1e4dea@eucas1p2.samsung.com> [not found] ` <CGME20170105152604eucas1p12c1a964b5299a5a41305b00b80a09f36@eucas1p1.samsung.com> @ 2017-01-05 16:11 ` Javier Martinez Canillas 2017-01-05 17:26 ` Krzysztof Kozlowski 2017-01-06 3:41 ` Chanwoo Choi 4 siblings, 0 replies; 10+ messages in thread From: Javier Martinez Canillas @ 2017-01-05 16:11 UTC (permalink / raw) To: Andrzej Hajda, linux-samsung-soc, Krzysztof Kozlowski Cc: Bartlomiej Zolnierkiewicz, Marek Szyprowski, Inki Dae, Rob Herring, Mark Rutland, devicetree Hello Andrzej, It seems the subject line "arm64" is more common than the capitalized "ARM64". On 01/05/2017 12:25 PM, Andrzej Hajda wrote: > DECON_TV is 2nd display controller on Exynos5433, used in HDMI path > or 2nd DSI path. > > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > --- > arch/arm64/boot/dts/exynos/exynos5433.dtsi | 44 ++++++++++++++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi > index 8cbfd1d..b47951b 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi > @@ -821,6 +821,28 @@ > }; > }; > > + decon_tv: decon@13880000 { > + compatible = "samsung,exynos5433-decon-tv"; > + reg = <0x13880000 0x20B8>; > + clocks = <&cmu_disp CLK_PCLK_DECON_TV>, > + <&cmu_disp CLK_ACLK_DECON_TV>, > + <&cmu_disp CLK_ACLK_SMMU_TV0X>, > + <&cmu_disp CLK_ACLK_XIU_TV0X>, > + <&cmu_disp CLK_PCLK_SMMU_TV0X>, > + <&cmu_disp CLK_SCLK_DECON_TV_VCLK>, > + <&cmu_disp CLK_SCLK_DECON_TV_ECLK>; > + clock-names = "pclk", "aclk_decon", "aclk_smmu_decon0x", > + "aclk_xiu_decon0x", "pclk_smmu_decon0x", > + "sclk_decon_vclk", "sclk_decon_eclk"; > + samsung,disp-sysreg = <&syscon_disp>; > + interrupt-names = "fifo", "vsync", "lcd_sys"; > + interrupts = <0 210 0>, <0 211 0>, <0 212 0>; You can use the GIC_SPI macro for the interrupt type instead. Also, I think IRQ_TYPE_NONE (0) isn't a valid flag for GIC interrupts. AFAIU the platform supports both IRQ_TYPE_EDGE_RISING and IRQ_TYPE_LEVEL_HIGH, and the latter is what's used consistently in the other Exynos DTS. Besides this comment, patch looks good to me. Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/3] ARM64: dts: exynos5433: add DECON_TV node 2017-01-05 15:25 ` [PATCH 1/3] ARM64: dts: exynos5433: add DECON_TV node Andrzej Hajda ` (2 preceding siblings ...) 2017-01-05 16:11 ` [PATCH 1/3] ARM64: dts: exynos5433: add DECON_TV node Javier Martinez Canillas @ 2017-01-05 17:26 ` Krzysztof Kozlowski 2017-01-06 3:41 ` Chanwoo Choi 4 siblings, 0 replies; 10+ messages in thread From: Krzysztof Kozlowski @ 2017-01-05 17:26 UTC (permalink / raw) To: Andrzej Hajda Cc: linux-samsung-soc, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz, Marek Szyprowski, Inki Dae, Rob Herring, Mark Rutland, Javier Martinez Canillas, devicetree On Thu, Jan 05, 2017 at 04:25:41PM +0100, Andrzej Hajda wrote: > DECON_TV is 2nd display controller on Exynos5433, used in HDMI path > or 2nd DSI path. > > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > --- > arch/arm64/boot/dts/exynos/exynos5433.dtsi | 44 ++++++++++++++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi > index 8cbfd1d..b47951b 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi > @@ -821,6 +821,28 @@ > }; > }; > > + decon_tv: decon@13880000 { > + compatible = "samsung,exynos5433-decon-tv"; > + reg = <0x13880000 0x20B8>; > + clocks = <&cmu_disp CLK_PCLK_DECON_TV>, > + <&cmu_disp CLK_ACLK_DECON_TV>, > + <&cmu_disp CLK_ACLK_SMMU_TV0X>, > + <&cmu_disp CLK_ACLK_XIU_TV0X>, > + <&cmu_disp CLK_PCLK_SMMU_TV0X>, > + <&cmu_disp CLK_SCLK_DECON_TV_VCLK>, > + <&cmu_disp CLK_SCLK_DECON_TV_ECLK>; > + clock-names = "pclk", "aclk_decon", "aclk_smmu_decon0x", > + "aclk_xiu_decon0x", "pclk_smmu_decon0x", > + "sclk_decon_vclk", "sclk_decon_eclk"; > + samsung,disp-sysreg = <&syscon_disp>; > + interrupt-names = "fifo", "vsync", "lcd_sys"; > + interrupts = <0 210 0>, <0 211 0>, <0 212 0>; > + power-domains = <&pd_disp>; > + status = "disabled"; > + iommus = <&sysmmu_tv0x>, <&sysmmu_tv1x>; > + iommu-names = "m0", "m1"; > + }; > + > syscon_disp: syscon@13b80000 { > compatible = "syscon"; > reg = <0x13b80000 0x1010>; > @@ -926,6 +948,28 @@ > power-domains = <&pd_disp>; > }; > > + sysmmu_tv0x: sysmmu@0x13a20000 { Without the '0x' in the address, please. I see that you copied it from existing nodes, so maybe you could fix them as well in following patch. Beside that (and Javier's comments) looks okay, but please choose suitable subject prefix matching recent commits. I think it is the third time I am mentioning this recently (to different Samsung folks, though)... Best regards, Krzysztof ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/3] ARM64: dts: exynos5433: add DECON_TV node 2017-01-05 15:25 ` [PATCH 1/3] ARM64: dts: exynos5433: add DECON_TV node Andrzej Hajda ` (3 preceding siblings ...) 2017-01-05 17:26 ` Krzysztof Kozlowski @ 2017-01-06 3:41 ` Chanwoo Choi 4 siblings, 0 replies; 10+ messages in thread From: Chanwoo Choi @ 2017-01-06 3:41 UTC (permalink / raw) To: Andrzej Hajda, linux-samsung-soc, Krzysztof Kozlowski Cc: Bartlomiej Zolnierkiewicz, Marek Szyprowski, Inki Dae, Rob Herring, Mark Rutland, Javier Martinez Canillas, devicetree Hi Andrej, When I applied these patch on next-branch(20170105) for test, these patch have the conflict. On 2017년 01월 06일 00:25, Andrzej Hajda wrote: > DECON_TV is 2nd display controller on Exynos5433, used in HDMI path > or 2nd DSI path. > > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > --- > arch/arm64/boot/dts/exynos/exynos5433.dtsi | 44 ++++++++++++++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi > index 8cbfd1d..b47951b 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi > @@ -821,6 +821,28 @@ > }; > }; > > + decon_tv: decon@13880000 { > + compatible = "samsung,exynos5433-decon-tv"; > + reg = <0x13880000 0x20B8>; As I knew, the maintainer prefer to use the small letter on offset instead of capital letter. - 0x20B8 -> 0x20b8 > + clocks = <&cmu_disp CLK_PCLK_DECON_TV>, > + <&cmu_disp CLK_ACLK_DECON_TV>, > + <&cmu_disp CLK_ACLK_SMMU_TV0X>, > + <&cmu_disp CLK_ACLK_XIU_TV0X>, > + <&cmu_disp CLK_PCLK_SMMU_TV0X>, > + <&cmu_disp CLK_SCLK_DECON_TV_VCLK>, > + <&cmu_disp CLK_SCLK_DECON_TV_ECLK>; > + clock-names = "pclk", "aclk_decon", "aclk_smmu_decon0x", > + "aclk_xiu_decon0x", "pclk_smmu_decon0x", > + "sclk_decon_vclk", "sclk_decon_eclk"; > + samsung,disp-sysreg = <&syscon_disp>; > + interrupt-names = "fifo", "vsync", "lcd_sys"; > + interrupts = <0 210 0>, <0 211 0>, <0 212 0>; Use the interrupt definitions with GIC_SPI. Also, decon of Exynos5433 uses the IRQ_TYPE_LEVEL_HIGH intead of IRQ_TYPE_NONE(0). I think you need to check it. > + power-domains = <&pd_disp>; The exynos5433.dtsi has not yet supported the power domains. Exynos5433.dtsi does not include the all of power domains. > + status = "disabled"; > + iommus = <&sysmmu_tv0x>, <&sysmmu_tv1x>; > + iommu-names = "m0", "m1"; > + }; > + > syscon_disp: syscon@13b80000 { > compatible = "syscon"; > reg = <0x13b80000 0x1010>; > @@ -926,6 +948,28 @@ > power-domains = <&pd_disp>; ditto. > }; > > + sysmmu_tv0x: sysmmu@0x13a20000 { > + compatible = "samsung,exynos-sysmmu"; > + reg = <0x13a20000 0x1000>; > + interrupts = <0 214 0>; Use the interrupt definitions with GIC_SPI. Also, other sysmmu of Exynos5433 uses the IRQ_TYPE_LEVEL_HIGH intead of IRQ_TYPE_NONE(0). I think you need to check it. > + clock-names = "pclk", "aclk"; > + clocks = <&cmu_disp CLK_PCLK_SMMU_TV0X>, > + <&cmu_disp CLK_ACLK_SMMU_TV0X>; > + #iommu-cells = <0>; > + power-domains = <&pd_disp>; ditto. > + }; > + > + sysmmu_tv1x: sysmmu@0x13a30000 { > + compatible = "samsung,exynos-sysmmu"; > + reg = <0x13a30000 0x1000>; > + interrupts = <0 216 0>; ditto. Use the interrupt definitions. > + clock-names = "pclk", "aclk"; > + clocks = <&cmu_disp CLK_PCLK_SMMU_TV1X>, > + <&cmu_disp CLK_ACLK_SMMU_TV1X>; > + #iommu-cells = <0>; > + power-domains = <&pd_disp>; ditto. > + }; > + > sysmmu_gscl0: sysmmu@0x13C80000 { ditto. - 0x13C80000 -> 0x13c80000 > compatible = "samsung,exynos-sysmmu"; > reg = <0x13C80000 0x1000>; ditto. - 0x13C80000 -> 0x13c80000 > -- Best Regards, Chanwoo Choi S/W Center, Samsung Electronics ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2017-01-06 4:51 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20170105152604eucas1p25340c974fa7f375905c958e2bff6d96f@eucas1p2.samsung.com>
2017-01-05 15:25 ` [PATCH 1/3] ARM64: dts: exynos5433: add DECON_TV node Andrzej Hajda
[not found] ` <CGME20170105152604eucas1p2092deeb660630f09b857cd1f8d1e4dea@eucas1p2.samsung.com>
[not found] ` <1483629943-31183-1-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2017-01-05 15:25 ` [PATCH 2/3] ARM64: dts: exynos5433: add HDMI node Andrzej Hajda
2017-01-05 16:21 ` Javier Martinez Canillas
[not found] ` <1483629943-31183-2-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2017-01-06 3:43 ` Chanwoo Choi
[not found] ` <CGME20170105152604eucas1p12c1a964b5299a5a41305b00b80a09f36@eucas1p1.samsung.com>
2017-01-05 15:25 ` [PATCH 3/3] ARM64: dts: exynos5433-tm2: enable HDMI/TV path Andrzej Hajda
[not found] ` <1483629943-31183-3-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2017-01-05 16:33 ` Javier Martinez Canillas
2017-01-06 4:51 ` Andi Shyti
2017-01-05 16:11 ` [PATCH 1/3] ARM64: dts: exynos5433: add DECON_TV node Javier Martinez Canillas
2017-01-05 17:26 ` Krzysztof Kozlowski
2017-01-06 3:41 ` Chanwoo Choi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).