devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RFC PATCH] ARM: dts: rockchip: increase the mclk_fs to 512 for kylin board
@ 2016-01-29  8:49 Xing Zheng
  2016-02-02 21:43 ` Heiko Stübner
  0 siblings, 1 reply; 2+ messages in thread
From: Xing Zheng @ 2016-01-29  8:49 UTC (permalink / raw)
  To: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
  Cc: keescook-hpIqsD4AKlfQT0dZR+AlfA, leozwang-hpIqsD4AKlfQT0dZR+AlfA,
	heiko-4mtYJXux2i+zQB+pC5nmwQ, Xing Zheng, Rob Herring, Pawel Moll,
	Mark Rutland, Ian Campbell, Kumar Gala, Russell King,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

If we playback the 8KHz FS audio with the 256 mclk_fs, we need the
mclk = 256 * 8000 = 2.048MHz, the frac div is 594 / 2.048 = 290,
the frac div value 0x00809015 set to the CRU_CLKSEL7_CON will cause
to hang.

We increase the mclk_fs to 512, will get the mclk = 512 * 8000 =
4.096MHz, use 0x01009015 instead of 0x00809015 to work around this
issue. We will keep tracking it.

Signed-off-by: Xing Zheng <zhengxing-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
---

 arch/arm/boot/dts/rk3036-kylin.dts |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/rk3036-kylin.dts b/arch/arm/boot/dts/rk3036-kylin.dts
index 190f22c..be468f9 100644
--- a/arch/arm/boot/dts/rk3036-kylin.dts
+++ b/arch/arm/boot/dts/rk3036-kylin.dts
@@ -67,7 +67,7 @@
 		compatible = "simple-audio-card";
 		simple-audio-card,format = "i2s";
 		simple-audio-card,name = "rockchip,rt5616-codec";
-		simple-audio-card,mclk-fs = <256>;
+		simple-audio-card,mclk-fs = <512>;
 		simple-audio-card,widgets =
 			"Microphone", "Microphone Jack",
 			"Headphone", "Headphone Jack";
-- 
1.7.9.5


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [RFC PATCH] ARM: dts: rockchip: increase the mclk_fs to 512 for kylin board
  2016-01-29  8:49 [RFC PATCH] ARM: dts: rockchip: increase the mclk_fs to 512 for kylin board Xing Zheng
@ 2016-02-02 21:43 ` Heiko Stübner
  0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stübner @ 2016-02-02 21:43 UTC (permalink / raw)
  To: Xing Zheng
  Cc: linux-rockchip, keescook, leozwang, Rob Herring, Pawel Moll,
	Mark Rutland, Ian Campbell, Kumar Gala, Russell King,
	linux-arm-kernel, devicetree, linux-kernel

Am Freitag, 29. Januar 2016, 16:49:21 schrieb Xing Zheng:
> If we playback the 8KHz FS audio with the 256 mclk_fs, we need the
> mclk = 256 * 8000 = 2.048MHz, the frac div is 594 / 2.048 = 290,
> the frac div value 0x00809015 set to the CRU_CLKSEL7_CON will cause
> to hang.
> 
> We increase the mclk_fs to 512, will get the mclk = 512 * 8000 =
> 4.096MHz, use 0x01009015 instead of 0x00809015 to work around this
> issue. We will keep tracking it.
> 
> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>

applied to my dts32 branch for 4.6


Thanks
Heiko

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-02-02 21:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-29  8:49 [RFC PATCH] ARM: dts: rockchip: increase the mclk_fs to 512 for kylin board Xing Zheng
2016-02-02 21:43 ` Heiko Stübner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).