From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19067C433F5 for ; Mon, 6 Sep 2021 13:36:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ECE8160F21 for ; Mon, 6 Sep 2021 13:36:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234414AbhIFNhI (ORCPT ); Mon, 6 Sep 2021 09:37:08 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:16541 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242561AbhIFNhI (ORCPT ); Mon, 6 Sep 2021 09:37:08 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1630935363; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: To: Subject: Sender; bh=VJqyOAQM63NCKoLXJVRl7+vm46IbeShVloXZfhv2BBg=; b=kJGFmdj6uWUMuOf6soTWvKm7lkF4wl1CniJj/1MRCJIAf3cwpxemgh9V3cMLtBjv1oQ94zLJ A8FT/QRqnn+ZLobxjb+Y65MOldXsFtmw8WKiS6YNy/iYoNLCh/sFsiNSqMvHoEV93zIG9J8l NYYAVwsr4ZfR3W8wys4FIa4EL+U= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI1YmJiNiIsICJkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-west-2.postgun.com with SMTP id 6136193b40d2129ac1dde34d (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 06 Sep 2021 13:35:55 GMT Sender: srivasam=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 07E72C43618; Mon, 6 Sep 2021 13:35:55 +0000 (UTC) Received: from [10.242.137.170] (unknown [202.46.23.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: srivasam) by smtp.codeaurora.org (Postfix) with ESMTPSA id 3FC82C4338F; Mon, 6 Sep 2021 13:35:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 3FC82C4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org Subject: Re: [PATCH] ASoC: qcom: lpass-platform: Reset irq clear reg post handling interrupts To: Stephen Boyd , agross@kernel.org, alsa-devel@alsa-project.org, bgoswami@codeaurora.org, bjorn.andersson@linaro.org, broonie@kernel.org, devicetree@vger.kernel.org, judyhsiao@chromium.org, lgirdwood@gmail.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, perex@perex.cz, plai@codeaurora.org, robh+dt@kernel.org, rohitkr@codeaurora.org, srinivas.kandagatla@linaro.org, tiwai@suse.com References: <20210903100153.9137-1-srivasam@codeaurora.org> From: Srinivasa Rao Mandadapu Organization: Qualcomm India Private Limited. Message-ID: <587ed6fd-0203-cb7d-338f-185185d88f76@codeaurora.org> Date: Mon, 6 Sep 2021 19:05:46 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Thanks for Your time Stephen!! On 9/4/2021 12:10 AM, Stephen Boyd wrote: > Quoting Srinivasa Rao Mandadapu (2021-09-03 03:01:53) >> Update interrupt clear register with reset value after addressing >> all interrupts. This is to fix playback or capture hanging issue in >> simultaneous playback and capture usecase. >> >> Signed-off-by: Srinivasa Rao Mandadapu >> --- > Any Fixes tag? Actually it's incremental change. I will add base commit of this function. > >> sound/soc/qcom/lpass-platform.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/sound/soc/qcom/lpass-platform.c b/sound/soc/qcom/lpass-platform.c >> index f9df76d37858..1a0a4b0b1a03 100644 >> --- a/sound/soc/qcom/lpass-platform.c >> +++ b/sound/soc/qcom/lpass-platform.c >> @@ -749,6 +749,12 @@ static irqreturn_t lpass_platform_lpaif_irq(int irq, void *data) >> } >> } >> >> + rv = regmap_write(drvdata->lpaif_map, LPAIF_IRQCLEAR_REG(v, LPAIF_IRQ_PORT_HOST), 0x0); >> + if (rv) { >> + pr_err("error writing to irqstat reg: %d\n", rv); >> + return IRQ_NONE; > I was thinking we should return IRQ_HANDLED still, but then I guess > failing to clear the irq be treated as a spurious irq so that if we fail > enough times we'll shut off the irq at the irqchip. Things are going bad > if the write fails. Here bit confusing. Could You please suggest How to go ahead on this? > >> + } >> + >> return IRQ_HANDLED; >> } >> -- Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.