From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F0EB32C85; Tue, 29 Apr 2025 14:52:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745938324; cv=none; b=TxMV/Q3RGl1FUpFxRaPm0OtYiOSCtj7zPMyJpJrDdCHbZMshNs/du5+sXEe57M4flG6n4iiO2o2UosJHTPwXviCy1NWDpLXWvOjEvPy5KGQ7t7iWz4XoZE7MfPIF0QzRgMT8/xlOaGWN+oayz3NOudaEptjwdMzw1vLzU+rsu9E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745938324; c=relaxed/simple; bh=ujLWWkmaRLLveVflcOWu68G29t6oIIc6pHVq9Ko9pzs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=a1pVRV7rJ0BaYv+yV2MqIq9TYx3hlRXE7oaSh8jKe08ZSLo6DJ0yDNzYOp2ID+PtOhDbFyp/C3po8FpEDEuUnNQ+O87azggUaZDX03T2U9hQgfbbCR/KJzzVeDK/cPFCZ/27vAmUciQvsmjMAEO5YX5izziABE2zuYpHy/Qhf6A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gVt8DhaK; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gVt8DhaK" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-5e8be1bdb7bso9796670a12.0; Tue, 29 Apr 2025 07:52:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745938321; x=1746543121; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2j3vmWcblMpAFi5MSBk2qMdY2/rE/Q+wya2rcoXjQ98=; b=gVt8DhaKo8cSQSPIe0mihl+A5hVEfoOHEpnZuwJRRfaBG2o2OIyDwvk/USbuul4E6H U6/7pSVLY0jLBMIEnk2HNM5huaGP7H4cf28JnX4aPGI2OosdF2xB/d8KOnO2LUzA2NsN fwt1ItFxBxNKcM533GmpyOSS+tJacffdxoyl5ltfqmC+13GadgxzGkCBda1eAXH4KEm7 /NojkfexEZt15D43CYyITgxslxp0TnBIjMnWkJh56wt5HuBSQMr6Hm//Si+my2xoqdt/ arYQMXUg3Ycdr9IFmXkhmXyUhjuTSVKqnor9CAsk70ngo90+D3jfyIKlbAd0X0BL9FTW 01iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745938321; x=1746543121; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2j3vmWcblMpAFi5MSBk2qMdY2/rE/Q+wya2rcoXjQ98=; b=jMcirGL20E2pB7p1DiSmsGzc6VAY+RR7EMu8Z9v3q7KVbQtYziTAvMz3CD9F7JJYmg nnTJOxtuNbS2IRasV8nGMOBrYL35F/19do887kr14JPS+rZujBZkn+CcZFh23Y63PZ+9 CneKdliQXNZ0yVUanZabzcquK2kbZbkNhE7CfOQnTdAoG/WTTC7n5kIJiKQLoUTq3c5H kpGOZ8xrN2RmzkVwbvM2ofo3SClZCzwTp1xfrC7sCcj7xK2HecF0Xk6/OPWCM20r9NVG pT/Az6yqYCymOlQ2UNE31HfehcWMu1XzvGIx4qqonDaLN0zls84UWRkJw1TX6LQC6L/G YD6Q== X-Forwarded-Encrypted: i=1; AJvYcCUt47MKjBYlxxN9DssUvdPiPqtERfWwj+0AvNmpfsn+WnxGPlGYQ2DIAufN6TtowTCGz6+Ig6DCmzlZrsCI@vger.kernel.org, AJvYcCV97TZtIJstxbLyfYHkUWlZCEmAu5m7ca32xYrqu2XwImlTtOyQmgNZSkMF+41KDtudn910Nv50swav@vger.kernel.org X-Gm-Message-State: AOJu0YzcIvng1nBqHOJIkUke4l0zTZFQ5sq9Sf3C44/HiLRHfG1/reTA XyyRshVVywwyKf2YjgR29BAGMZF5fecFKT1Pci8ktOxF5URfeSGm X-Gm-Gg: ASbGncu77QGDoVzAOiaw7zCVWHgWKrZd3RlefTvsplY6vIJ5LiYmHy7KLnNez9grMKn ugDuCkm2fYON4wofw7yzmN7poCzfkmNsHujasRO1+uMpJ4KyUX/kG7Hl1YHjwDu7PZGsm8HwC9A fAHEAleSMHBhxIkvxb6uveU0+BF53ZIGFudRjIXJ4waGx2psOxxZj/XuxKktHknTfiG/zm+5Flk eTyPUp4aLFaFEvbeyEeyAJMkj9xiqJqiHnOINpTqEU3eZ+gmN7hec7/qAY/NAIkKcC+9h/inZ1s ghFemLBNRZtG8TWJGtBUTiWcNxJe6bdK85IsUuo0Opvh1gsLBp7shhQxQupp2jyQIjJdLHoKC/u kyyXwLpJE5+lGMgm9 X-Google-Smtp-Source: AGHT+IEz06/+DeCVuRvMFYjbMCHdLWSGqTMxg/VP6erFPSJQ+to0uxlq6imsOijDrrRMdG90WDzVxA== X-Received: by 2002:a05:6402:348f:b0:5f8:2436:1df9 with SMTP id 4fb4d7f45d1cf-5f83afc1b49mr2846758a12.10.1745938321060; Tue, 29 Apr 2025 07:52:01 -0700 (PDT) Received: from jernej-laptop.localnet (86-58-6-171.dynamic.telemach.net. [86.58.6.171]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5f7038340b7sm7414214a12.79.2025.04.29.07.52.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Apr 2025 07:52:00 -0700 (PDT) From: Jernej =?UTF-8?B?xaBrcmFiZWM=?= To: Andrew Lunn Cc: Andre Przywara , robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, wens@csie.org, samuel@sholland.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] arm64: dts: allwinner: h6: Add OrangePi 3 LTS DTS Date: Tue, 29 Apr 2025 16:51:59 +0200 Message-ID: <5880182.DvuYhMxLoT@jernej-laptop> In-Reply-To: <34e30bf2-6f80-4c43-9e52-c1ebe0521c43@lunn.ch> References: <20250413134318.66681-1-jernej.skrabec@gmail.com> <2219754.irdbgypaU6@jernej-laptop> <34e30bf2-6f80-4c43-9e52-c1ebe0521c43@lunn.ch> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Dne ponedeljek, 28. april 2025 ob 14:37:48 Srednjeevropski poletni =C4=8Das= je Andrew Lunn napisal(a): > On Sat, Apr 26, 2025 at 08:00:49PM +0200, Jernej =C5=A0krabec wrote: > > Dne petek, 25. april 2025 ob 17:34:14 Srednjeevropski poletni =C4=8Das = je Andrew Lunn napisal(a): > > > > > +&emac { > > > > > + pinctrl-names =3D "default"; > > > > > + pinctrl-0 =3D <&ext_rgmii_pins>; > > > > > + phy-mode =3D "rgmii-rxid"; > > > >=20 > > > > So relating to what Andrew said earlier today, should this read rgm= ii-id > > > > instead? Since the strap resistors just set some boot-up value, but= we > > > > want the PHY driver to enable both RX and TX delay programmatically? > > >=20 > > > Yes. > > >=20 > > > There is a checkpatch.pl patch working its way through the system > > > which will add warning about any rgmii value other than rgmii-id. Such > > > values need a comment that the PCB has extra long clock > > > lines. Hopefully that will make people actually stop and think about > > > this, rather than just copy broken vendor code. > >=20 > > I spent quite some time working on ethernet support for this board. Once > > I've found PHY datasheet, I confirmed that there is added delay. So this > > particular board needs "rgmii-rxid" mode. >=20 > There have been numerous discussions about what these rgmii modes > mean, because DT developers frequently get them wrong. >=20 > Does the PCB have an extra long clock line in the TX direction? That > is what rgmii-rxid means, the PCB is providing the TX delay, the > MAC/PHY pair needs to add the RX delay. While schematic is accessible, AFAIK PCB/gerbers are not, so I can't really tell how long it is. But without this extra delay, ethernet doesn't work. >=20 > Ignore strapping. That is just a power on default which gets over > ridden once the PHY driver is running. >=20 > What PHY is this? Motorcomm YT8531C. Best regards, Jernej >=20 > Andrew >=20