From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Sakari Ailus <sakari.ailus@linux.intel.com>,
Jason Chen <jason.z.chen@intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v5 2/4] media: dt-bindings: Add OmniVision OV08X40
Date: Wed, 9 Oct 2024 14:02:48 +0100 [thread overview]
Message-ID: <58958e05-882d-4866-809b-1daec897f59a@linaro.org> (raw)
In-Reply-To: <20241005-b4-master-24-11-25-ov08x40-v5-2-5f1eb2e11036@linaro.org>
On 05/10/2024 11:31, Bryan O'Donoghue wrote:
> +
> + properties:
> + endpoint:
> + $ref: /schemas/media/video-interfaces.yaml#
> + unevaluatedProperties: false
> +
> + properties:
> + data-lanes:
> + oneOf:
> + - items:
> + - const: 1
> + - const: 2
> + - items:
> + - const: 1
> + - const: 2
> + - const: 3
> + - const: 4
> +
> + required:
> + - data-lanes
> + - link-frequencies
I had some offline discussion with Laurent about this since, the logical
conclusion of this would be anything from
schemas/media/video-interfaces.yaml# would be valid.
And I'll admit I looked @ upstream examples and copied/pasted which also
implies that the upstream examples aren't correct.
So, I'll v6 this with
properties:
endpoint:
$ref: /schemas/media/video-interfaces.yaml#
_additionalProperties_: false
properties:
link-frequencies: true
data-lanes:
oneOf:
- items:
- const: 1
- const: 2
- items:
- const: 1
- const: 2
- const: 3
- const: 4
required:
- data-lanes
- link-frequencies
and then change the relevant upstream examples of unevaluatedProperties:
false to additionalProperties: false.
---
bod
next prev parent reply other threads:[~2024-10-09 13:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-05 10:31 [PATCH v5 0/4] ov08x40: Enable use of ov08x40 on Qualcomm X1E80100 CRD Bryan O'Donoghue
2024-10-05 10:31 ` [PATCH v5 1/4] media: ov08x40: Fix burst write sequence Bryan O'Donoghue
2024-10-05 10:31 ` [PATCH v5 2/4] media: dt-bindings: Add OmniVision OV08X40 Bryan O'Donoghue
2024-10-09 13:02 ` Bryan O'Donoghue [this message]
2024-10-05 10:31 ` [PATCH v5 3/4] media: ov08x40: Rename ext_clk to xvclk Bryan O'Donoghue
2024-10-05 10:31 ` [PATCH v5 4/4] media: ov08x40: Add OF probe support Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58958e05-882d-4866-809b-1daec897f59a@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jason.z.chen@intel.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).