From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Mark Jackson" <mpfj@newflow.co.uk>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: Update Nanobone DTS
Date: Wed, 9 Nov 2022 15:33:53 +0100 [thread overview]
Message-ID: <58c2ca66-94cf-292a-5973-cb2add0ab964@linaro.org> (raw)
In-Reply-To: <20221109143003.81463-1-mpfj@newflow.co.uk>
On 09/11/2022 15:30, Mark Jackson wrote:
> Update Nanobone DTS file as follows:-
Drop trailing dash.
Use subject prefixes matching the subsystem (git log --oneline -- ...).
> - Fix GPIO settings for RTS/CTS pins on UART3 & 4
> - Enable RS485 mode for UART3 & 4
> - Enable LM75 temperature sensor
> - Fix GPIO settings for MMC pins
> - Enable USB
Split patch per logical changes so your subject summarizes the change,
not just "update".
Missing Signed-off-by, so you also did not run checkpatch. Please run
scripts/checkpatch.pl and fix reported warnings.
> ---
> arch/arm/boot/dts/am335x-nano.dts | 33 +++++++++++++++++++++++++------
> 1 file changed, 27 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am335x-nano.dts b/arch/arm/boot/dts/am335x-nano.dts
> index b6f2567bd65a..1f613e879c53 100644
> --- a/arch/arm/boot/dts/am335x-nano.dts
> +++ b/arch/arm/boot/dts/am335x-nano.dts
> @@ -120,8 +120,8 @@ AM33XX_PADCONF(AM335X_PIN_SPI0_D0, PIN_OUTPUT, MUX_MODE1) /* spi0_d0.uart2_txd
>
> uart3_pins: uart3_pins {
> pinctrl-single,pins = <
> - AM33XX_PADCONF(AM335X_PIN_LCD_DATA10, PIN_INPUT_PULLUP, MUX_MODE6) /* lcd_data10.uart3_ctsn */
> - AM33XX_PADCONF(AM335X_PIN_LCD_DATA11, PIN_OUTPUT, MUX_MODE6) /* lcd_data11.uart3_rtsn */
> + AM33XX_PADCONF(AM335X_PIN_LCD_DATA10, PIN_INPUT_PULLUP, MUX_MODE7) /* lcd_data10.gpio2[16] */
> + AM33XX_PADCONF(AM335X_PIN_LCD_DATA11, PIN_OUTPUT, MUX_MODE7) /* lcd_data11.gpio2[17] */
> AM33XX_PADCONF(AM335X_PIN_SPI0_CS1, PIN_INPUT, MUX_MODE1) /* spi0_cs1.uart3_rxd */
> AM33XX_PADCONF(AM335X_PIN_ECAP0_IN_PWM0_OUT, PIN_OUTPUT, MUX_MODE1) /* ecap0_in_pwm0_out.uart3_txd */
> >;
> @@ -129,8 +129,8 @@ AM33XX_PADCONF(AM335X_PIN_ECAP0_IN_PWM0_OUT, PIN_OUTPUT, MUX_MODE1) /* ecap0_in
>
> uart4_pins: uart4_pins {
> pinctrl-single,pins = <
> - AM33XX_PADCONF(AM335X_PIN_LCD_DATA12, PIN_INPUT_PULLUP, MUX_MODE6) /* lcd_data12.uart4_ctsn */
> - AM33XX_PADCONF(AM335X_PIN_LCD_DATA13, PIN_OUTPUT, MUX_MODE6) /* lcd_data13.uart4_rtsn */
> + AM33XX_PADCONF(AM335X_PIN_LCD_DATA12, PIN_INPUT_PULLUP, MUX_MODE7) /* lcd_data12.gpio0[8] */
> + AM33XX_PADCONF(AM335X_PIN_LCD_DATA13, PIN_OUTPUT, MUX_MODE7) /* lcd_data13.gpio0[9] */
> AM33XX_PADCONF(AM335X_PIN_UART0_CTSN, PIN_INPUT, MUX_MODE1) /* uart0_ctsn.uart4_rxd */
> AM33XX_PADCONF(AM335X_PIN_UART0_RTSN, PIN_OUTPUT, MUX_MODE1) /* uart0_rtsn.uart4_txd */
> >;
> @@ -188,12 +188,22 @@ &uart3 {
> pinctrl-names = "default";
> pinctrl-0 = <&uart3_pins>;
> status = "okay";
Status is the last property.
> + rts-gpio = <&gpio2 17 GPIO_ACTIVE_HIGH>;
> + rs485-rts-active-high;
> + rs485-rx-during-tx;
> + rs485-rts-delay = <1 1>;
> + linux,rs485-enabled-at-boot-time;
> };
>
> &uart4 {
> pinctrl-names = "default";
> pinctrl-0 = <&uart4_pins>;
> status = "okay";
Ditto
> + rts-gpio = <&gpio0 9 GPIO_ACTIVE_HIGH>;
> + rs485-rts-active-high;
> + rs485-rx-during-tx;
> + rs485-rts-delay = <1 1>;
> + linux,rs485-enabled-at-boot-time;
> };
>
> &uart5 {
> @@ -220,6 +230,12 @@ tps: tps@24 {
> reg = <0x24>;
> };
>
> + lm75@48 {
Generic node names, so probably "temperature-sensor". Check existing
sources.
> + compatible = "lm75";
> + reg = <0x48>;
> + status = "okay";
No need, drop.
Best regards,
Krzysztof
prev parent reply other threads:[~2022-11-09 14:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 14:30 [PATCH] ARM: dts: Update Nanobone DTS Mark Jackson
2022-11-09 14:33 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58c2ca66-94cf-292a-5973-cb2add0ab964@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mpfj@newflow.co.uk \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox