From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Peng Fan <peng.fan@nxp.com>, Rob Herring <robh@kernel.org>,
"Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: Abel Vesa <abelvesa@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"imx@lists.linux.dev" <imx@lists.linux.dev>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] dt-bindindgs: clock: support NXP i.MX95 BLK CTL module
Date: Tue, 5 Mar 2024 08:14:26 +0100 [thread overview]
Message-ID: <58cdfa7c-5483-4193-a5de-bb5fa72de637@linaro.org> (raw)
In-Reply-To: <DU0PR04MB941740A36E953A0E1AD690EC88222@DU0PR04MB9417.eurprd04.prod.outlook.com>
On 05/03/2024 05:13, Peng Fan wrote:
>>> +
>>> +examples:
>>> + # Clock Control Module node:
>>> + - |
>>> + #include <dt-bindings/clock/nxp,imx95-clock.h>
>>> +
>>> + syscon@4c410000 {
>>
>> clock-controller@...
>
> But this is a syscon, using clock-controller will trigger dt
> check warning.
Which warning?
>>
>> As that is the main feature/function.
>>
>>> + compatible = "nxp,imx95-vpumix-csr", "syscon";
>>> + reg = <0x4c410000 0x10000>;
>>> + #clock-cells = <1>;
>>
>> Please make the example as full as possible. For example, add mux-controller
>> node. Do some of the blocks not have mux ctrl?
>
> Yes. The blk ctrl is not just for clock, some registers has mux ctrl,
> such as Pixel_link_sel.
Then mux-controller should not be allowed for them.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-03-05 7:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 7:48 [PATCH v3 0/2] Add support i.MX95 BLK CTL module clock features Peng Fan (OSS)
2024-02-28 7:48 ` [PATCH v3 1/2] dt-bindindgs: clock: support NXP i.MX95 BLK CTL module Peng Fan (OSS)
2024-03-04 14:39 ` Rob Herring
2024-03-04 14:59 ` Krzysztof Kozlowski
2024-03-05 4:13 ` Peng Fan
2024-03-05 7:14 ` Krzysztof Kozlowski [this message]
2024-03-05 7:18 ` Peng Fan
2024-03-05 7:29 ` Krzysztof Kozlowski
2024-03-05 7:30 ` Krzysztof Kozlowski
2024-02-28 7:48 ` [PATCH v3 2/2] clk: imx: add i.MX95 BLK CTL clk driver Peng Fan (OSS)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58cdfa7c-5483-4193-a5de-bb5fa72de637@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=abelvesa@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).