From: Rohit Kumar <rohitkr@codeaurora.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Vinod <vkoul@kernel.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, bgoswami@codeaurora.org,
lgirdwood@gmail.com, plai@codeaurora.org,
linux-kernel@vger.kernel.org, tiwai@suse.com, robh+dt@kernel.org,
broonie@kernel.org
Subject: Re: [PATCH v2 2/2] ASoC: qcom: add sdm845 sound card support
Date: Fri, 22 Jun 2018 16:06:17 +0530 [thread overview]
Message-ID: <58db39ee-d2a7-1cdf-c7e2-eea020c8a2c6@codeaurora.org> (raw)
In-Reply-To: <46f1a6af-a180-2568-d203-87323379c2fd@linaro.org>
On 6/21/2018 8:39 PM, Srinivas Kandagatla wrote:
>
>
> On 21/06/18 13:35, Vinod wrote:
>> And this one is generic DT parsing and seems quite similar to one in
>> apq8096.c
>> Can we move these into a lib and use them instead of duplicating.
> I totally agree with Vinod, We should probably come up with a library
> functions something like common.c so that we do not duplicate code.
> This code is going be exactly same for most of the SoCs using qdsp.
>
Sure, I will add a new file, qcom_snd_common.c, which will have these
common functions and will update apq8096 and sdm845 machine driver to use
APIs exposed by qcom_snd_common.c
> thanks,
> srini
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Regards,
Rohit
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2018-06-22 10:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 10:53 [PATCH v2 0/2] Add support for audio on SDM845 SoC Rohit kumar
2018-06-21 10:53 ` [PATCH v2 1/2] ASoC: qcom: dt-bindings: Add sdm845 machine bindings Rohit kumar
2018-06-25 19:17 ` Rob Herring
2018-06-28 6:20 ` Rohit Kumar
2018-06-28 14:04 ` [alsa-devel] " Rob Herring
2018-06-21 10:53 ` [PATCH v2 2/2] ASoC: qcom: add sdm845 sound card support Rohit kumar
2018-06-21 12:35 ` [alsa-devel] " Vinod
2018-06-21 15:09 ` Srinivas Kandagatla
2018-06-22 10:36 ` Rohit Kumar [this message]
2018-06-22 12:32 ` [alsa-devel] " Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58db39ee-d2a7-1cdf-c7e2-eea020c8a2c6@codeaurora.org \
--to=rohitkr@codeaurora.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=plai@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).