From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Varada Pavani <v.pavani@samsung.com>,
mturquette@baylibre.com, sboyd@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, s.nawrocki@samsung.com,
tomasz.figa@gmail.com
Cc: linux-samsung-soc@vger.kernel.org, alim.akhtar@samsung.com,
aswani.reddy@samsung.com, pankaj.dubey@samsung.com
Subject: Re: [PATCH 2/2] clk: samsung: Fix typo error and extra space
Date: Tue, 19 Dec 2023 13:06:25 +0100 [thread overview]
Message-ID: <58ded02d-a5d2-40e2-b575-dc520a7553cf@linaro.org> (raw)
In-Reply-To: <20231219115834.65720-2-v.pavani@samsung.com>
On 19/12/2023 12:58, Varada Pavani wrote:
> Remove extra spaces and fix spelling mistakes in 'drivers/
> clk/samsung/clk-cpu.c' and 'drivers/clk/samsung/clk-cpu.h'
>
> Signed-off-by: Varada Pavani <v.pavani@samsung.com>
> ---
> drivers/clk/samsung/clk-cpu.c | 6 +++---
> drivers/clk/samsung/clk-cpu.h | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/clk/samsung/clk-cpu.c b/drivers/clk/samsung/clk-cpu.c
> index 3e62ade120c5..18568b8b1b9b 100644
> --- a/drivers/clk/samsung/clk-cpu.c
> +++ b/drivers/clk/samsung/clk-cpu.c
> @@ -19,7 +19,7 @@
> * clock and the corresponding rate changes of the auxillary clocks of the CPU
> * domain. The platform clock driver provides a clock register configuration
> * for each configurable rate which is then used to program the clock hardware
> - * registers to acheive a fast co-oridinated rate change for all the CPU domain
> + * registers to achieve a fast co-oridinated rate change for all the CPU domain
> * clocks.
> *
> * On a rate change request for the CPU clock, the rate change is propagated
> @@ -181,7 +181,7 @@ static int exynos_cpuclk_pre_rate_change(struct clk_notifier_data *ndata,
> * If the old parent clock speed is less than the clock speed of
> * the alternate parent, then it should be ensured that at no point
> * the armclk speed is more than the old_prate until the dividers are
> - * set. Also workaround the issue of the dividers being set to lower
> + * set. Also workaround the issue of the dividers being set to lower
Why? The double-space is correct.
> * values before the parent clock speed is set to new lower speed
> * (this can result in too high speed of armclk output clocks).
> */
> @@ -303,7 +303,7 @@ static int exynos5433_cpuclk_pre_rate_change(struct clk_notifier_data *ndata,
> * If the old parent clock speed is less than the clock speed of
> * the alternate parent, then it should be ensured that at no point
> * the armclk speed is more than the old_prate until the dividers are
> - * set. Also workaround the issue of the dividers being set to lower
> + * set. Also workaround the issue of the dividers being set to lower
Why?
> * values before the parent clock speed is set to new lower speed
> * (this can result in too high speed of armclk output clocks).
> */
> diff --git a/drivers/clk/samsung/clk-cpu.h b/drivers/clk/samsung/clk-cpu.h
> index fc9f67a3b22e..e0a1651174e6 100644
> --- a/drivers/clk/samsung/clk-cpu.h
> +++ b/drivers/clk/samsung/clk-cpu.h
> @@ -33,7 +33,7 @@ struct exynos_cpuclk_cfg_data {
> * @hw: handle between CCF and CPU clock.
> * @alt_parent: alternate parent clock to use when switching the speed
> * of the primary parent clock.
> - * @ctrl_base: base address of the clock controller.
> + * @ctrl_base: base address of the clock controller.
Why only here and not in other places?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-19 12:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20231219115856epcas5p371abeb4264f60309e597b90954e6d58c@epcas5p3.samsung.com>
2023-12-19 11:58 ` [PATCH 1/2] dt-bindings: clock: Fix spelling mistake in 'tesla,fsd-clock.yaml' Varada Pavani
2023-12-19 11:58 ` [PATCH 2/2] clk: samsung: Fix typo error and extra space Varada Pavani
2023-12-19 12:06 ` Krzysztof Kozlowski [this message]
2023-12-26 17:05 ` Varada Pavani
2023-12-27 11:40 ` Krzysztof Kozlowski
2023-12-19 12:07 ` [PATCH 1/2] dt-bindings: clock: Fix spelling mistake in 'tesla,fsd-clock.yaml' Krzysztof Kozlowski
2023-12-26 16:57 ` Varada Pavani
2023-12-26 18:57 ` Krzysztof Kozlowski
2024-01-23 8:21 ` Krzysztof Kozlowski
2024-01-23 9:54 ` (subset) " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58ded02d-a5d2-40e2-b575-dc520a7553cf@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=aswani.reddy@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=pankaj.dubey@samsung.com \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=tomasz.figa@gmail.com \
--cc=v.pavani@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox