devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Sylvain Petinot <sylvain.petinot@foss.st.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	<linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] media: dt-bindings: Add ST VD55G1 camera sensor binding
Date: Wed, 2 Apr 2025 15:39:59 +0200	[thread overview]
Message-ID: <58e6a6a1-7f7c-4232-a212-59850ab03a41@foss.st.com> (raw)
In-Reply-To: <6f832ce4-03d3-46bc-afcc-86983b2ec47a@kernel.org>



On 4/2/25 14:55, Krzysztof Kozlowski wrote:
> On 02/04/2025 14:46, Laurent Pinchart wrote:
>> On Wed, Apr 02, 2025 at 12:27:08PM +0200, Krzysztof Kozlowski wrote:
>>> On 02/04/2025 11:41, Benjamin Mugnier wrote:
>>>> On 4/2/25 11:38, Benjamin Mugnier wrote:
>>>>> On 4/2/25 11:11, Krzysztof Kozlowski wrote:
>>>>>> On 02/04/2025 10:34, Benjamin Mugnier wrote:
>>>>>>> Hi Krzysztof,
>>>>>>>
>>>>>>> On 4/2/25 09:08, Krzysztof Kozlowski wrote:
>>>>>>>> On Tue, Apr 01, 2025 at 01:05:58PM +0200, Benjamin Mugnier wrote:
>>>>>>>>> +    properties:
>>>>>>>>> +      endpoint:
>>>>>>>>> +        $ref: /schemas/media/video-interfaces.yaml#
>>>>>>>>> +        unevaluatedProperties: false
>>>>>>>>> +
>>>>>>>>> +        properties:
>>>>>>>>> +          data-lanes:
>>>>>>>>> +            items:
>>>>>>>>> +              const: 1
>>>>>>>>
>>>>>>>> Not what I asked. Now you miss number of items. Just use the syntax I
>>>>>>>> proposed. Or was there any issue with it?
>>>>>>>
>>>>>>> No issue I just misunderstood and thought const: 1 was impliying
>>>>>>> maxItems: 1. I'll add maxItems back.
>>>>>>
>>>>>> That's just longer way to express what I asked for. So I repeat the
>>>>>> question: why not using the syntax I asked for?
>>>>>
>>>>> I guess I didn't understand what you asked for.
>>>>> May I ask you to write it ? That will help me a lot.
>>>>
>>>> By 'it' I mean the binding.
>>>
>>> I wrote it last time. I don't think that copying the same here would
>>> change anything. If I can look at v1, you can do as well.
>>
>> Reading your comment on v1, I would have come up with the exact same
>> result as Benjamin's v2. I can't figure out what alternative description
>> you meant.
> What do you mean by description? I pasted code. The *exact* code to use.
> Benjamin used different code. Two times I asked why you cannot use the
> code I pasted. Still no answer.

I'm sorry, thanks to the help over #linux-media we realized I missed the
'-' before const. I'm not very knowledgeable in device tree binding syntax.
I'll push a v4 with that.

> 
> Best regards,
> Krzysztof

-- 
Regards,
Benjamin

  reply	other threads:[~2025-04-02 13:41 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-01 11:05 [PATCH v2 0/2] media: Add support for ST VD55G1 camera sensor Benjamin Mugnier
2025-04-01 11:05 ` [PATCH v2 1/2] media: dt-bindings: Add ST VD55G1 camera sensor binding Benjamin Mugnier
2025-04-02  7:08   ` Krzysztof Kozlowski
2025-04-02  8:34     ` Benjamin Mugnier
2025-04-02  9:11       ` Krzysztof Kozlowski
2025-04-02  9:38         ` Benjamin Mugnier
2025-04-02  9:41           ` Benjamin Mugnier
2025-04-02 10:27             ` Krzysztof Kozlowski
2025-04-02 12:46               ` Laurent Pinchart
2025-04-02 12:55                 ` Krzysztof Kozlowski
2025-04-02 13:39                   ` Benjamin Mugnier [this message]
2025-04-02 13:41                 ` Rob Herring
2025-04-02  7:08   ` Krzysztof Kozlowski
2025-04-02  8:35     ` Benjamin Mugnier
2025-04-01 11:05 ` [PATCH v2 2/2] media: i2c: Add driver for ST VD55G1 camera sensor Benjamin Mugnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58e6a6a1-7f7c-4232-a212-59850ab03a41@foss.st.com \
    --to=benjamin.mugnier@foss.st.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=robh@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=sylvain.petinot@foss.st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).