From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2446C46467 for ; Mon, 28 Nov 2022 12:37:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230462AbiK1Mha (ORCPT ); Mon, 28 Nov 2022 07:37:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230397AbiK1Mh2 (ORCPT ); Mon, 28 Nov 2022 07:37:28 -0500 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86E821A069 for ; Mon, 28 Nov 2022 04:37:27 -0800 (PST) Received: by mail-lf1-x12d.google.com with SMTP id s8so17116528lfc.8 for ; Mon, 28 Nov 2022 04:37:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3zsuy+0KAbon34PjD50ab0w1ynNsD0k56NpcI5wUZZY=; b=nNowC5tN1eKFJBmunGJikmsjqeJ/RZ8kp06qtd4uCbDB1SPM2VZThIjAMQRzCJ48Zc XruHi5Q8q1FrwX0F2jQdhznu3cP6nBBS8CN8/lZr8MWZTa0vyGhF6CCqLPXfaT8BDSnw GLnP+NkrbqP+K8Lf4l3ht12LlKKWaxugQUq1otVv2Z+kEtP7RGcJz6ApOz0yXHeYIwSc KvFtaXxN23QskFC5ezXWO3F/pFocLY5cTITZShvYs03ygkmkg14n+jtBlC92pTu0xzU2 ZCMjSRNF5GyZKdcSMk/TdLO62Apm7f+xSABKXB3hp1Xe6RXazm3Pm7QHTwMBDoH+SkT2 v50Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3zsuy+0KAbon34PjD50ab0w1ynNsD0k56NpcI5wUZZY=; b=oG/caHKF74NT8lmnA5R0DbnVIBDbre7PGYAkJcjTIwPetVZ2dFzuJ+5egyxBk5H/o/ rGY/vv/CX+47/fNjszl7lCzdpiSFbTWUeWBV38kijc+vAfyhh4N4nLF8BCjKB+QjBfDp /6xm1LoydguEqvAYSB4OBJ7NHiPwpMhZnO1s66Z/yQIZY/OMvIUe4PHg9nNZWx6pIe/S 50djZwP4+S9iMKrYTYSEYQOJA5uAQdOIhyOXZG71h81U2a57jN7nmPS7dUb0J8I+bMj8 OEoM39raJVKFGAoEITrRj8UIAf757VI6hqVBmr9LfiT+Fu6g1ubHq26FnVzbNR/rZfDo lNow== X-Gm-Message-State: ANoB5png9j+0QbirFm74A78lfgWXCFCRicOzE3uP19josZKq0avBFG1p W25040f0g1AUgqCaA/NlRHYl0uaTlU5TMAZa X-Google-Smtp-Source: AA0mqf4wQN/ZHP/4bc7HcoQXJzIU87tAaHbkDsXSPAwaz8rWU+HBFFrbh++nFRy+SN9XCqBEi3d0Hg== X-Received: by 2002:ac2:41c6:0:b0:4b0:4b08:6873 with SMTP id d6-20020ac241c6000000b004b04b086873mr18360398lfi.329.1669639045898; Mon, 28 Nov 2022 04:37:25 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id x21-20020a056512047500b00492ca820e15sm1673362lfd.270.2022.11.28.04.37.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Nov 2022 04:37:25 -0800 (PST) Message-ID: <58febf4d-05c8-e06e-04c1-6f10322e29c8@linaro.org> Date: Mon, 28 Nov 2022 13:37:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH V3 3/5] dt-bindings: i2c: add bindings for Loongson LS2X I2C Content-Language: en-US To: Binbin Zhou , Wolfram Sang , Wolfram Sang , Mika Westerberg , linux-i2c@vger.kernel.org Cc: loongarch@lists.linux.dev, devicetree@vger.kernel.org, Huacai Chen , WANG Xuerui , Andy Shevchenko , Arnd Bergmann , Rob Herring , Krzysztof Kozlowski , Jianmin Lv References: <57339e73b6c0bfe446e19a7f55a48b7ca640b9ec.1669359515.git.zhoubinbin@loongson.cn> <61541d15-fbfd-3f99-fc05-663ebf4a2b54@linaro.org> <654be437-f4f0-4c98-b124-ac2d8f78fdbe@loongson.cn> From: Krzysztof Kozlowski In-Reply-To: <654be437-f4f0-4c98-b124-ac2d8f78fdbe@loongson.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 28/11/2022 13:24, Binbin Zhou wrote: > >>> + >>> + reg: >>> + maxItems: 1 >>> + >> No clocks? I2C controller without clocks? Are you sure the binding is >> complete? > > We previously set the default CLOCK in the driver. Of course, we also > provide the path to read the clock-frequency field for redo. In any > case, I will add the clock-frequency field to the V4 patchset. I am not thinking here about the driver. What your bindings said, is that device does not have any clocks and I have doubts about it... I also do not say anything about clock-frequency because it is already there via i2c-controller.yaml. Best regards, Krzysztof