devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Claudiu Beznea <claudiu.beznea@microchip.com>,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, nicolas.ferre@microchip.com,
	alexandre.belloni@bootlin.com, daniel.lezcano@linaro.org,
	tglx@linutronix.de, wim@linux-watchdog.org, linux@roeck-us.net
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
	Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH v3 3/3] dt-bindings: timer: atmel,at91rm9200-st: convert to yaml
Date: Wed, 31 May 2023 10:58:11 +0200	[thread overview]
Message-ID: <5908a6d6-e93f-d6b3-ee8e-d923663a80ed@linaro.org> (raw)
In-Reply-To: <20230530090758.1652329-4-claudiu.beznea@microchip.com>

On 30/05/2023 11:07, Claudiu Beznea wrote:
> Convert Microchip AT91 system timer to YAML.
> 
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> ---

Thank you for your patch. There is something to discuss/improve.

> +properties:
> +  compatible:
> +    items:
> +      - const: atmel,at91rm9200-st
> +      - const: syscon
> +      - const: simple-mfd
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    description:
> +      Contain interrupt for the ST which is the IRQ line shared across all
> +      system controller members (memory controller, debug unit, system timer,
> +      real-time clock, power management controller).
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  watchdog:
> +    $ref: ../watchdog/atmel,at91rm9200-wdt.yaml

Full path, so /schemas/watchdog/atmel....

> +    description:
> +      Child node describing watchdog.
> +


Best regards,
Krzysztof


  reply	other threads:[~2023-05-31  8:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-30  9:07 [PATCH v3 0/3] dt-bindings: timer: Microchip AT91 convert to YAML Claudiu Beznea
2023-05-30  9:07 ` [PATCH v3 1/3] dt-bindings: timer: atmel,at91sam9260-pit: convert to yaml Claudiu Beznea
2023-05-31  8:55   ` Krzysztof Kozlowski
2023-06-09 10:22     ` Claudiu.Beznea
2023-06-09 10:48       ` Krzysztof Kozlowski
2023-06-09 12:09         ` Claudiu.Beznea
2023-06-09 12:18           ` Krzysztof Kozlowski
2023-06-09 12:21             ` Claudiu.Beznea
2023-05-30  9:07 ` [PATCH v3 2/3] dt-bindings: watchdog: atmel,at91rm9200-wdt: " Claudiu Beznea
2023-05-31  8:56   ` Krzysztof Kozlowski
2023-05-30  9:07 ` [PATCH v3 3/3] dt-bindings: timer: atmel,at91rm9200-st: " Claudiu Beznea
2023-05-31  8:58   ` Krzysztof Kozlowski [this message]
2023-05-30 12:29 ` [PATCH v3 0/3] dt-bindings: timer: Microchip AT91 convert to YAML Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5908a6d6-e93f-d6b3-ee8e-d923663a80ed@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=claudiu.beznea@microchip.com \
    --cc=conor+dt@kernel.org \
    --cc=conor.dooley@microchip.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=nicolas.ferre@microchip.com \
    --cc=robh+dt@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).