From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frank Rowand Subject: Re: [PATCH] of/unittest: Missing unlocks on error Date: Wed, 3 May 2017 17:05:29 -0700 Message-ID: <590A7049.3070108@gmail.com> References: <20170503194950.4xbdbwybvx6dkadx@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170503194950.4xbdbwybvx6dkadx@mwanda> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dan Carpenter , Rob Herring Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 05/03/17 12:49, Dan Carpenter wrote: > Static checkers complain that we should unlock before returning. Which > is true. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c > index 12597ff8cfb0..425338d6286d 100644 > --- a/drivers/of/unittest.c > +++ b/drivers/of/unittest.c > @@ -2210,14 +2210,14 @@ static __init void of_unittest_overlay_high_level(void) > unittest(0, > "duplicate property '%s' in overlay_base node __symbols__", > prop->name); > - return; > + goto err_unlock; > } > ret = __of_add_property_sysfs(of_symbols, prop); > if (ret) { > unittest(0, > "unable to add property '%s' in overlay_base node __symbols__ to sysfs", > prop->name); > - return; > + goto err_unlock; > } > } > } > @@ -2232,6 +2232,10 @@ static __init void of_unittest_overlay_high_level(void) > > unittest(overlay_data_add(2), > "Adding overlay 'overlay_bad_phandle' failed\n"); > + return; > + > +err_unlock: > + mutex_unlock(&of_mutex); > } > > #else > Thanks Dan. Reviewed-by: Frank Rowand -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html