From: "Heiko Stübner" <heiko@sntech.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Cc: kernel@collabora.com, linux-input@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Subject: Re: [PATCH 1/4] dt-bindings: input: adc-keys: allow linux,input-type property
Date: Mon, 30 Jun 2025 13:37:32 +0200 [thread overview]
Message-ID: <5913630.hdfAi7Kttb@diego> (raw)
In-Reply-To: <20250630-rock4d-audio-v1-1-0b3c8e8fda9c@collabora.com>
Am Montag, 30. Juni 2025, 12:19:24 Mitteleuropäische Sommerzeit schrieb Nicolas Frattaroli:
> adc-keys, unlike gpio-keys, does not allow linux,input-type as a valid
> property. This makes it impossible to model devices that have ADC inputs
> that should generate switch events.
>
> Add the property to the binding with the same default as gpio-keys.
>
> Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
> ---
> Documentation/devicetree/bindings/input/adc-keys.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/input/adc-keys.yaml b/Documentation/devicetree/bindings/input/adc-keys.yaml
> index 7aa078dead37816294732501e1983ab869f38311..e372ebc23d1651d73ef3749a56d54872067037b5 100644
> --- a/Documentation/devicetree/bindings/input/adc-keys.yaml
> +++ b/Documentation/devicetree/bindings/input/adc-keys.yaml
> @@ -42,6 +42,9 @@ patternProperties:
>
> linux,code: true
>
> + linux,input-type:
> + default: 1 # EV_KEY
> +
having both adc- and gpio-keys behave the same in that regard makes a lot
of sense, and the addition matches gpio-keys.yaml, so
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> press-threshold-microvolt:
> description:
> Voltage above or equal to which this key is considered pressed. No
>
>
next prev parent reply other threads:[~2025-06-30 11:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-30 10:19 [PATCH 0/4] ROCK 4D audio enablement Nicolas Frattaroli
2025-06-30 10:19 ` [PATCH 1/4] dt-bindings: input: adc-keys: allow linux,input-type property Nicolas Frattaroli
2025-06-30 11:37 ` Heiko Stübner [this message]
2025-06-30 10:19 ` [PATCH 2/4] Input: adc-keys - support types that aren't just keyboard keys Nicolas Frattaroli
2025-06-30 11:49 ` Heiko Stübner
2025-06-30 10:19 ` [PATCH 3/4] arm64: dts: rockchip: add analog audio to ROCK 4D Nicolas Frattaroli
2025-07-02 9:49 ` Cristian Ciocaltea
2025-06-30 10:19 ` [PATCH 4/4] arm64: dts: rockchip: add HDMI audio on " Nicolas Frattaroli
2025-07-02 8:57 ` Cristian Ciocaltea
2025-07-10 9:27 ` (subset) [PATCH 0/4] ROCK 4D audio enablement Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5913630.hdfAi7Kttb@diego \
--to=heiko@sntech.de \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=nicolas.frattaroli@collabora.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).