From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A03B256C9E; Wed, 1 Oct 2025 07:12:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759302733; cv=none; b=AGUKyYGPenru0XogmrJDhaYOFUIvGRKEmMKcMFjwuRbcxaldvbyc6FnQw/ORx8cCKj9CJeIx0Ra/hIptAJJjD+NZKwumXwnjC5lv2a8jH7T+oUmEUHOmpOsv/RSH5scxujdtkfncGVCjpuxfCxfRuPgbHfd2JUfWu+3miFrScuE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759302733; c=relaxed/simple; bh=t7LQvWDoawtcjynybyV6CpESEqmrVI+X1jX9CcdZPZ0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=cSe2yQdR5GPp6uVWL8htQ4Vj6c0ygiOq+fBU9CXsE1dLJHfkH2EdIU4zTUlMLdkTGrd73YxWKBpiWk68jK4U3gNl2aX7w6UHtKmxfgQiuykL7PzObfxol7P4M5ALCGiqabY/dvlnuAwCHSe8fa+zHEzNP5TCaLt0nmSD0bsD8SY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=cdrQs0tf; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="cdrQs0tf" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 253784E40DE7; Wed, 1 Oct 2025 07:12:06 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id E7227606BF; Wed, 1 Oct 2025 07:12:05 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 82FD1102F1854; Wed, 1 Oct 2025 09:11:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1759302725; h=from:subject:date:message-id:to:cc:mime-version:content-type: in-reply-to:references; bh=GnVI4ZR4JkJ5vv9WaP33l3msfPu596SbGWUzbRdFAx4=; b=cdrQs0tfjiD2vmtme9KllctTecE2Rl9XGw801EbGjiI6ek+2YXXUv586pPfLCdZ4B/hcvn EaiO/8Vvgtl1Mv9E/TN+suIX8xnA6W4i6UM50/Zl+a/MrO9Ez98fL9gtawa5ARotKhvPot 8LM7VFkEXsonjXF6GmRwLFcthj9PVEPfd7HzrsjWVhIQjdyis2xLzSk1AAX5XJkYt49WEM X8CGD863aML1KQvQBMVNrRZvBJYHCMJrkjZlrq2Af3yztGrqVxuCIY0zeb74+ri0mlnEiL CM4NdfXn51oPYdPQkBA6dbdhTZxlysutzPXNGth1iKOe9gSxRIpBKdlPnm97Ow== From: Romain Gantois To: Conor Dooley Cc: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Cameron , David Lechner , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , Hans de Goede , Thomas Petazzoni , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-iio@vger.kernel.org Subject: Re: [PATCH v2 1/5] regulator: dt-bindings: Add Linear Technology LTM8054 regulator Date: Wed, 01 Oct 2025 09:11:51 +0200 Message-ID: <5926760.DvuYhMxLoT@fw-rgant> In-Reply-To: <20250927-spoon-yearning-c1a8df796173@spud> References: <20250925-ltm8054-driver-v2-0-bb61a401a0dc@bootlin.com> <5331035.LvFx2qVVIh@fw-rgant> <20250927-spoon-yearning-c1a8df796173@spud> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart6197909.lOV4Wx5bFT"; micalg="pgp-sha512"; protocol="application/pgp-signature" X-Last-TLS-Session-Version: TLSv1.3 --nextPart6197909.lOV4Wx5bFT Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8"; protected-headers="v1" From: Romain Gantois To: Conor Dooley Date: Wed, 01 Oct 2025 09:11:51 +0200 Message-ID: <5926760.DvuYhMxLoT@fw-rgant> In-Reply-To: <20250927-spoon-yearning-c1a8df796173@spud> MIME-Version: 1.0 On Sunday, 28 September 2025 00:31:05 CEST Conor Dooley wrote: ... > > > > > > > + lltc,fb-voltage-divider: > > > Why does this property have a ?linear? vendor prefix? > > > Shouldn't it be adi to match the other property and compatible? > > > > This component was originally from Linear Technology, before it was > > acquired by Analog Devices. The new properties and compatibles have the > > Analog Devices prefix, but the "fb-voltage-divider" property is already > > used by the LTC3676 and LTC3589 regulators, so I left the Linear > > Technology prefix for this one to avoid introducing a new property just > > to specify a vendor prefix change. > > > > I don't have a strong opinion about this though. > > Do they share the same driver? They do not. However, they use it in the exact same way, and I would've liked to factor out the handling of this property in a future patch. This would also make it easier to handle other types of feedback pin circuits and have a generic binding for "regulators using a feedback pin connected to some kind of analog circuit". For example: Vout----+ | | +++ | | | | Rtop | | +++ | | FB ----+ | +--+--+ | | | | | |CCS +--v--+ | | -+- - This is all speculation at this point though, so I don't mind changing the property to "adi,fb-voltage-divider" and handling the different compatibles when it comes to it. Thanks, -- Romain Gantois, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --nextPart6197909.lOV4Wx5bFT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEIcCsAScRrtr7W0x0KCYAIARzeA4FAmjc1DcACgkQKCYAIARz eA6qTg/+Kkilr24s4UFOMInNmOfoTXbYDRNnY1G9d2/sXjYcwqNTtmnoK/iwyuta wsf8Aw9kycn8Daw1ra4fAdARNjHU/ky1ciPZPDRqRcuhgSoyxP2TbKHDjoKBYIBK KhOx9Ow267KOnJRooUbhNdX0CRwOr6PgPc2qE1ZQatDKriNc1SRkeGarUqdeyITq GBMGJi/uhMMVgrjsXRxGaDiDjZT9PxGGc7lGoOq0/QxdOPsFfuJmzgH/1MY6jj7b qRePQELC4N4So3jAGvUZgqWS+o2A7EOMGXO9MBSOi9oUwFQODYMWD1+a4QEAQN7t lM15POGGAhxTb2406ez8chEMamBOr+CU2Q7zsCrJfYc4+2D3qPhojxm2WAb44dOq x+qJS88Su6lA/b8DRUcxuem7EUSUpjKTXy2g4ox4FBbfxZqr+J4tws7xBp/wpBv9 jsw20G74ycrru6povudm5ge5P7XVQF9BArHxjW++vNMdE9Dd0+2cqn8eZhu8rXlh qVQDOLzGINZUccX0b/QeA2G2JmQ3Sb/FCZQuLA/CTyNIZLF0yjPXg9MR02/hNBR9 JI/IQ8Y/thn6+1TtAzDRPRJWzkMbJAnCXYRs92d4IRpxdbthytgI5OXN10j2H9gr nMS3sbxSbsJRGOmMCwuRjuki6DcHcmUZFvpg83QKJ5+oxiWuUtg= =/Mf9 -----END PGP SIGNATURE----- --nextPart6197909.lOV4Wx5bFT--