From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Caleb Connolly <caleb.connolly@linaro.org>
Cc: Luca Weiss <luca@z3ntu.xyz>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
devicetree@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH 1/5] arm64: dts: qcom: pmi8998: add rradc node
Date: Sun, 16 Oct 2022 21:10:26 -0400 [thread overview]
Message-ID: <5929051d-d2be-5b51-0cf9-294affa51df2@linaro.org> (raw)
In-Reply-To: <20221016180330.1912214-2-caleb.connolly@linaro.org>
On 16/10/2022 14:03, Caleb Connolly wrote:
> Add a DT node for the Round Robin ADC found in the PMI8998 PMIC.
>
> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/pmi8998.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/pmi8998.dtsi b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> index 6d3d212560c1..5a479259c041 100644
> --- a/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> @@ -18,6 +18,14 @@ pmi8998_gpio: gpios@c000 {
> interrupt-controller;
> #interrupt-cells = <2>;
> };
> +
> + pmi8998_rradc: adc@4500 {
> + compatible = "qcom,pmi8998-rradc";
> + reg = <0x4500>;
> + #io-channel-cells = <1>;
> +
> + status = "disabled";
Why disabling it? It does not need any external/board resources, so
maybe it should be just like other adcs - enabled by default? What does
it measure? What is its input?
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-10-17 1:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-16 18:03 [PATCH 0/5] arm64: dts: qcom: add and enable the pmi8998 RRADC Caleb Connolly
2022-10-16 18:03 ` [PATCH 1/5] arm64: dts: qcom: pmi8998: add rradc node Caleb Connolly
2022-10-17 1:10 ` Krzysztof Kozlowski [this message]
2022-10-17 15:29 ` Caleb Connolly
2022-10-17 17:22 ` Krzysztof Kozlowski
2022-10-16 18:03 ` [PATCH 2/5] arm64: dts: qcom: sdm845-oneplus: enable rradc Caleb Connolly
2022-10-16 18:03 ` [PATCH 3/5] arm64: dts: qcom: sdm845-db845c: " Caleb Connolly
2022-10-16 18:03 ` [PATCH 4/5] arm64: dts: qcom: sdm845-xiaomi-beryllium: " Caleb Connolly
2022-10-16 18:03 ` [PATCH 5/5] arm64: dts: qcom: msm8998-oneplus-common: enable RRADC Caleb Connolly
2022-11-07 3:11 ` [PATCH 0/5] arm64: dts: qcom: add and enable the pmi8998 RRADC Bjorn Andersson
2022-11-07 3:23 ` Caleb Connolly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5929051d-d2be-5b51-0cf9-294affa51df2@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=caleb.connolly@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).