From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D5D3C4332F for ; Mon, 17 Oct 2022 01:10:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229995AbiJQBKc (ORCPT ); Sun, 16 Oct 2022 21:10:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229805AbiJQBKa (ORCPT ); Sun, 16 Oct 2022 21:10:30 -0400 Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 570172B63F for ; Sun, 16 Oct 2022 18:10:29 -0700 (PDT) Received: by mail-qt1-x830.google.com with SMTP id bb5so6895869qtb.11 for ; Sun, 16 Oct 2022 18:10:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=u37Oc8Xrxoc/KwYwTXixeQOuxbzurVoYLNJ9kGdS1Zo=; b=fRfMawN2iik541nYnkVavvjZWI7Cf44Q2jUlAKJyQNcnuFAuA4DO+i81W9tqdFOiou qmT/qSOLkw0xA0q0mMCkJsXTZG4yhIoWxDgOgVCgx9Q4oXDo2VM0rQYBpR906FptR2G2 of60mBGXhk6VweX7lxH5nW063qtbCpNCFV/eyEz/H18kZfHiRJl/A4jycu5C2ldYvbnq 0tXbOMubsFqrUJRxNQSsvjEiRwmQAomCTuoiY1P+Gj/zB5Dky6WgFygur88h7d0c1dNJ ZOKTjjWLsLUm8081UwJ1hqNbl8NHDCcD+DrGMgv8/NH/Dc8JPhx05fvTe3xcNulRicHT xJRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=u37Oc8Xrxoc/KwYwTXixeQOuxbzurVoYLNJ9kGdS1Zo=; b=klz86dpnDK35esoJAnhlr/cFH/X6akm/wvQ/MdV0h1isPe0JHCW3EvvSU5+g0+Y+Gk dIPyDkfQxPKWlzKJdauNTONpEQKpiN7Iu/A4ydxbKMJMYvNLf2TxnzoRnl6DlsZEvikL hJQ+Jz/uPssnqpZPhtejtYEn/kgbUxhU4fTsvSM7ivGdlLkDDZ+hQzGnVrEn+zbpl8mF S9Hg4zAjW1m0Wqc9emN8j+2EZ/wdQO8uW2ZaXN8dsstFQHn7N/jDGxuMiObnK5OyJdBB DtuGY0z+6FSOuYzjEJplk/fxAYItJ5VyIbIvwSeXUF94m8GnIb0tBQV2ZbQm9y2RVm/u uoWw== X-Gm-Message-State: ACrzQf1XbIPdcerPFVgL46WGRq60XDqAkQLM3v10B/prOOUsuLDHypNi NVdmh+FRBFUgAfZc7UvbqOYOXg== X-Google-Smtp-Source: AMsMyM691uEuJd3rwOenpPlDO1LeLgZascRVEtwjX9N1DX7KDNpEo4KIjr28XnRmc957SBjt/YEefg== X-Received: by 2002:a05:622a:90:b0:39c:e637:912 with SMTP id o16-20020a05622a009000b0039ce6370912mr3847331qtw.109.1665969028353; Sun, 16 Oct 2022 18:10:28 -0700 (PDT) Received: from ?IPV6:2601:42:0:3450:bb7d:1aa4:bef8:ec27? ([2601:42:0:3450:bb7d:1aa4:bef8:ec27]) by smtp.gmail.com with ESMTPSA id f1-20020ac84701000000b00397101ac0f2sm6558051qtp.3.2022.10.16.18.10.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Oct 2022 18:10:27 -0700 (PDT) Message-ID: <5929051d-d2be-5b51-0cf9-294affa51df2@linaro.org> Date: Sun, 16 Oct 2022 21:10:26 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH 1/5] arm64: dts: qcom: pmi8998: add rradc node Content-Language: en-US To: Caleb Connolly Cc: Luca Weiss , Andy Gross , Bjorn Andersson , devicetree@vger.kernel.org, Konrad Dybcio , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring References: <20221016180330.1912214-1-caleb.connolly@linaro.org> <20221016180330.1912214-2-caleb.connolly@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20221016180330.1912214-2-caleb.connolly@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 16/10/2022 14:03, Caleb Connolly wrote: > Add a DT node for the Round Robin ADC found in the PMI8998 PMIC. > > Signed-off-by: Caleb Connolly > --- > arch/arm64/boot/dts/qcom/pmi8998.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/pmi8998.dtsi b/arch/arm64/boot/dts/qcom/pmi8998.dtsi > index 6d3d212560c1..5a479259c041 100644 > --- a/arch/arm64/boot/dts/qcom/pmi8998.dtsi > +++ b/arch/arm64/boot/dts/qcom/pmi8998.dtsi > @@ -18,6 +18,14 @@ pmi8998_gpio: gpios@c000 { > interrupt-controller; > #interrupt-cells = <2>; > }; > + > + pmi8998_rradc: adc@4500 { > + compatible = "qcom,pmi8998-rradc"; > + reg = <0x4500>; > + #io-channel-cells = <1>; > + > + status = "disabled"; Why disabling it? It does not need any external/board resources, so maybe it should be just like other adcs - enabled by default? What does it measure? What is its input? Best regards, Krzysztof