From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jagan Teki <jagan@amarulasolutions.com>,
Heiko Stuebner <heiko@sntech.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Chukun Pan <amadeus@jmu.edu.cn>, FUKAUMI Naoki <naoki@radxa.com>
Subject: Re: [PATCH 3/7] dt-bindings: arm: rockchip: Fix description and compatible for Radxa CM3i
Date: Tue, 17 Jan 2023 12:06:37 +0100 [thread overview]
Message-ID: <592dab00-9e4d-4445-2f77-ecff12b8ca70@linaro.org> (raw)
In-Reply-To: <20230117105504.18296-3-jagan@amarulasolutions.com>
On 17/01/2023 11:55, Jagan Teki wrote:
> Fix the dt-bindings for Radxa CM3i SoM based boards with proper
> description and compatible strings recommended by Radxa.
>
> Fixes: ae9fbe0b1f96 ("dt-bindings: arm: rockchip: add Radxa CM3I E25")
> Cc: Chukun Pan <amadeus@jmu.edu.cn>
> Reported-by: FUKAUMI Naoki <naoki@radxa.com>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Documentation/devicetree/bindings/arm/rockchip.yaml | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 3d3c59624483..6f276d787e50 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -628,11 +628,11 @@ properties:
> - const: radxa,radxa-cm3 # Radxa Compute Module 3(CM3)
> - const: rockchip,rk3566
>
> - - description: Radxa CM3 Industrial
> + - description: Radxa Compute Module 3 Industrial(CM3i) SoM based boards
> items:
> - enum:
> - - radxa,e25
> - - const: radxa,cm3i
> + - radxa,radxa-e25 # Radxa E25 Carrier Board
> + - const: radxa,radxa-cm3i # Radxa Compute Module 3 Industrial(CM3i)
No, it does not match your patch 2/7. It also does not make sense to
duplicate vendor prefix.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-01-17 11:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 10:54 [PATCH 1/7] dt-bindings: arm: rockchip: Add meaningful comments for Radxa CM3 Jagan Teki
2023-01-17 10:54 ` [PATCH 2/7] arm64: dts: rockchip: Add missing CM3i fallback compatible for Radxa E25 Jagan Teki
2023-01-17 10:55 ` [PATCH 3/7] dt-bindings: arm: rockchip: Fix description and compatible for Radxa CM3i Jagan Teki
2023-01-17 11:06 ` Krzysztof Kozlowski [this message]
2023-01-17 12:55 ` Jagan Teki
2023-01-17 20:32 ` Rob Herring
2023-01-17 10:55 ` [PATCH 4/7] arm64: dts: rockchip: Fix compatible and model " Jagan Teki
2023-01-17 11:07 ` Krzysztof Kozlowski
2023-01-17 12:52 ` Jagan Teki
2023-01-17 12:58 ` Krzysztof Kozlowski
2023-01-18 7:20 ` Jagan Teki
2023-01-17 10:55 ` [PATCH 5/7] arm64: dts: rockchip: Drop unneeded " Jagan Teki
2023-01-17 10:55 ` [PATCH 6/7] arm64: dts: rockchip: Update eMMC, SD aliases for Radxa SoM boards Jagan Teki
2023-01-17 10:55 ` [PATCH 7/7] arm64: dts: rockchip: Update eMMC, SD aliases for Radxa SBC boards Jagan Teki
2023-01-17 11:05 ` [PATCH 1/7] dt-bindings: arm: rockchip: Add meaningful comments for Radxa CM3 Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=592dab00-9e4d-4445-2f77-ecff12b8ca70@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=amadeus@jmu.edu.cn \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jagan@amarulasolutions.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=naoki@radxa.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).