From: Konrad Dybcio <konradybcio@kernel.org>
To: srinivas.kandagatla@linaro.org, andersson@kernel.org
Cc: konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
abel.vesa@linaro.org
Subject: Re: [PATCH v2] arm64: dts: qcom: x1e80100-t14s: add another trackpad support
Date: Wed, 18 Sep 2024 01:32:34 +0200 [thread overview]
Message-ID: <5932fc68-3afd-448b-99b8-65ee9ef5dda6@kernel.org> (raw)
In-Reply-To: <20240917150049.3110-1-srinivas.kandagatla@linaro.org>
On 17.09.2024 5:00 PM, srinivas.kandagatla@linaro.org wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>
> Trackpad HID device on some of the T14s Product Models 21N2ZC5PUS is
> at I2C address 0x2c add this to be able to get it working on these laptops.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> Changes since v1:
> - moved pinctrl to parent node so that pinctrl can be claimed globally.
>
> .../dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts | 17 +++++++++++++----
> 1 file changed, 13 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts
> index 08ec2419f95f..45a77c1fb6f4 100644
> --- a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts
> @@ -551,6 +551,9 @@ zap-shader {
> &i2c0 {
> clock-frequency = <400000>;
>
> + pinctrl-0 = <&tpad_default>;
> + pinctrl-names = "default";
You're dropping the QUP pins, please include them too (like in c630.dtsi)
Konrad
next prev parent reply other threads:[~2024-09-17 23:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-17 15:00 [PATCH v2] arm64: dts: qcom: x1e80100-t14s: add another trackpad support srinivas.kandagatla
2024-09-17 15:32 ` Dmitry Baryshkov
2024-09-17 23:32 ` Konrad Dybcio [this message]
2024-09-18 9:29 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5932fc68-3afd-448b-99b8-65ee9ef5dda6@kernel.org \
--to=konradybcio@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).