From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57A4FC41513 for ; Thu, 10 Aug 2023 12:57:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231240AbjHJM5v (ORCPT ); Thu, 10 Aug 2023 08:57:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230458AbjHJM5u (ORCPT ); Thu, 10 Aug 2023 08:57:50 -0400 Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24242C5; Thu, 10 Aug 2023 05:57:50 -0700 (PDT) Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 37ACvTcK049535; Thu, 10 Aug 2023 07:57:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1691672249; bh=SRjRe34ehad5M7YRy/nqD3E5u+nolVOaUEPJlquRXus=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=T33uo7GyZVN3KQ9oPUdDikxNHd9TLkmpRr3i6Hk2A0B6i5oLbAgBsVJat0mcDWvvv L4G3TuwScjbhOtK065v67tGaJo9bybobDDMnrV2yNLHILqM13sBMJ8BkkFrBZE8kP9 uwC6Zhc/CvdQwPjWEHcaG+q1j5o8owVIq7RpOg5U= Received: from DLEE113.ent.ti.com (dlee113.ent.ti.com [157.170.170.24]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 37ACvTKT109279 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 10 Aug 2023 07:57:29 -0500 Received: from DLEE111.ent.ti.com (157.170.170.22) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Thu, 10 Aug 2023 07:57:29 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE111.ent.ti.com (157.170.170.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Thu, 10 Aug 2023 07:57:29 -0500 Received: from [172.24.227.217] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 37ACvMRd013085; Thu, 10 Aug 2023 07:57:23 -0500 Message-ID: <593b3505-9c1e-47e6-e856-f299fc257fa8@ti.com> Date: Thu, 10 Aug 2023 18:27:22 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v3 1/5] dt-bindings: net: Add ICSS IEP Content-Language: en-US To: Conor Dooley CC: Conor Dooley , MD Danish Anwar , Randy Dunlap , Roger Quadros , Simon Horman , Vignesh Raghavendra , Andrew Lunn , Richard Cochran , Conor Dooley , Krzysztof Kozlowski , Rob Herring , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , , , , , , , References: <20230809114906.21866-1-danishanwar@ti.com> <20230809114906.21866-2-danishanwar@ti.com> <20230809-cardboard-falsify-6cc9c09d8577@spud> <0b619ec5-9a86-a449-e8db-b12cca115b93@ti.com> <20230810-drippy-draw-8e8a63164e46@wendy> From: Md Danish Anwar Organization: Texas Instruments In-Reply-To: <20230810-drippy-draw-8e8a63164e46@wendy> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 10/08/23 6:22 pm, Conor Dooley wrote: > On Thu, Aug 10, 2023 at 03:23:11PM +0530, Md Danish Anwar wrote: >> On 10/08/23 3:07 am, Conor Dooley wrote: >>> On Wed, Aug 09, 2023 at 05:19:02PM +0530, MD Danish Anwar wrote: >>>> Add DT binding documentation for ICSS IEP module. >>>> >>>> Signed-off-by: MD Danish Anwar >>>> --- >>>> .../devicetree/bindings/net/ti,icss-iep.yaml | 37 +++++++++++++++++++ >>>> 1 file changed, 37 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/net/ti,icss-iep.yaml >>>> >>>> diff --git a/Documentation/devicetree/bindings/net/ti,icss-iep.yaml b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml >>>> new file mode 100644 >>>> index 000000000000..adae240cfd53 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml >>>> @@ -0,0 +1,37 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>> +%YAML 1.2 >>>> +--- >>>> +$id: http://devicetree.org/schemas/net/ti,icss-iep.yaml# >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>> + >>>> +title: Texas Instruments ICSS Industrial Ethernet Peripheral (IEP) module >>> >>> Does the module here refer to the hw component or to the linux kernel >>> module? >>> >> >> The module here refers to the hardware component. > > Sweet, thanks. > >>>> + >>>> +maintainers: >>>> + - Md Danish Anwar >>>> + >>>> +properties: >>>> + compatible: >>>> + enum: >>>> + - ti,am654-icss-iep # for all TI K3 SoCs >>> >>> *sigh* Please at least give me a chance to reply to the conversation on >>> the previous versions of the series before sending more, that's the >>> second time with this series :/ >> >> My bad, I should have waited for your response. I will hold on posting next >> version until your response is received. >> >>> Right now this looks worse to me than what we started with given the >>> comment is even broader. I have not changed my mind re: what I said on >>> the previous version. >>> >> >> OK, so in the previous version [1] your reply was to have specific compatibles >> as bindings with "ti-am654-icss-iep" as a fall back. I will go with this only. >> >> Does the below looks good to you? Here "ti,am642-icss-iep" and >> "ti,j721e-icss-iep" are different compatibles for different SoCs where as >> "ti,am654-icss-iep" is the fall back. Compatible "ti,am654-icss-iep" will go in >> the driver. >> >> properties: >> compatible: >> oneOf: >> - items: >> - enum: >> - ti,am642-icss-iep >> - ti,j721e-icss-iep >> - const: ti,am654-icss-iep >> >> - items: >> - const: ti,am654-icss-iep > > This one doesn't need to be an items list, since there is only one item. > It should be able to just be const:. I much prefer this approach. > > Thanks, > Conor. Sure Conor, I will remove items from the last one and make it just const like below. Please let me know if this is ok. properties: compatible: oneOf: - items: - enum: - ti,am642-icss-iep - ti,j721e-icss-iep - const: ti,am654-icss-iep - const: ti,am654-icss-iep -- Thanks and Regards, Danish.