From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F9581FF7C7; Fri, 27 Mar 2026 13:23:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774617816; cv=none; b=hockOMxZEd7DyvERaczpowYCsc+9ml9K5B+2AU0dM4B5iKs7ElF2NK22aCCVmObgvSKFofnc2zI875ITCLEgHOupfHjZFhjBJYGiVgSFdpk6EZPuJt4uxx543PUSsqDZ9O2OpNj+F618C6+8rLBMmmW5l5Q4jmFv/JWIi5Gw3u0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774617816; c=relaxed/simple; bh=h8cbQSK/dRlh8uqSMs3yZsAF3RmFXVtMTJ3CiE/wf0Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QKJktB6+khG77AcNnKqbD1kV4nDTV/eZO6P9+yAVD5270j7xKCbTJi6wSvyzi5SkNe2PmmSU/sEsNljEVFzvs4t4cVbX9zBuCOR5ea/EYx0Tm9dpIBvRtyNey3c9fQT9bS+o8CqOpCL6sOHXyEp+i8DO5l5H31mkAmcOWjNqIGg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HmaOm3Xp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HmaOm3Xp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6363EC19423; Fri, 27 Mar 2026 13:23:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774617816; bh=h8cbQSK/dRlh8uqSMs3yZsAF3RmFXVtMTJ3CiE/wf0Q=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=HmaOm3Xpssr1ZfpuveIc3DPruruVButeon4DT1x6oUoLDCie2AUK60jzer0/NcQU/ 2FuXCEliWyTSRZ49R6E/rTUDjXATrH6RSdFBTyVXDDKo8K4SPftZxHUySZj+EmhOga zwIpCcablnQOqU8KT20vaLRIEHEYHy8KHIE/CbfhOPOWRvqUGJPF/y28mnD3BhOc1+ c9fFm4QfGDZWBnQ9egtAbBZ5tQGcc6ViATxRaLCIPke3a0MipUPKlBcwN8DZ+OiVhS b1sIqFPuV77uzPloDh0pxBLwhhXZILCkqmzLCd8b0mqGkiLE2VIIyOHLqvXU2P8WZM rLsXzbf9ol7hA== Message-ID: <5941830f-5892-4e75-bc27-04095b5ca28f@kernel.org> Date: Fri, 27 Mar 2026 14:23:31 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/4] ASoC: dt-bindings: qcom,q6apm-lpass-dais: Document DAI subnode To: Mohammad Rafi Shaik Cc: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Srinivas Kandagatla References: <20260309111300.2484262-1-mohammad.rafi.shaik@oss.qualcomm.com> <20260309111300.2484262-2-mohammad.rafi.shaik@oss.qualcomm.com> <20260310-crazy-screeching-angelfish-297bab@quoll> <138dee9e-56e7-43a0-bcbd-0e4db4d5b5af@oss.qualcomm.com> <376ad62e-e6b5-438b-a23a-0988b6489e5c@kernel.org> <2e03441e-4353-4927-8630-aa7730c4033e@oss.qualcomm.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <2e03441e-4353-4927-8630-aa7730c4033e@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 27/03/2026 14:16, Mohammad Rafi Shaik wrote: >> >>> >>> In other words, DAI ↔ MCLK is not a fixed mapping. >>> >>> Examples: >>> On Talos‑EVK, the speaker is connected via Primary MI2S, but the >>> corresponding MCLK line wired to the codec is LPASS_CLK_ID_MCLK_2. >>> >>> On Kodiak, the customer connected an SGTL5000 codec via Quaternary MI2S, >>> yet the required MCLK is still LPASS_CLK_ID_MCLK_2. >>> >>> Instead, the kernel must vote for the MCLK that is physically connected >>> to the external codec on that specific board. >> >> No, the external codec driver must vote for that MCLK. >> > > I agree that when the MCLK provider is external, it is appropriate for > the codec driver to manage that clock. However, in this case the MCLK > provider is the LPASS/DSP subsystem itself, and the external codec is > only a consumer. > > LPASS MCLKs configurations inside the DSP can be lost or reprogrammed > during DSP power collapse or subsystem restart (SSR). > > Without visibility into LPASS lifecycle(SSR) events, a third‑party codec > driver cannot reliably perform clock voting or restoration, resulting in > broken or inconsistent audio behavior. > > For these reasons, MCLK voting needs to remain owned by the LPASS/HLOS > drivers, which have awareness of DSP power state and board wiring, Sounds like you just brought driver model as the arguments here, so not correct for DT. But even if we speak about drivers, then I think I also assumption that only clock consumer driver can manage the clock is not true. The provider, so LPASS/DSP knows what is happening with entire audio so it tracks the usage of its clocks and can perform clock disable/unprepare/prepare/restoration or whatever there is needed. Anyway, that's not important here. First argument is - you just wrote stuff for drivers and that we don't want. Best regards, Krzysztof